This queue is for tickets about the Business-Hours CPAN distribution.

Report information
The Basics
Id:
87106
Status:
resolved
Priority:
Low/Low

People
Owner:
Nobody in particular
Requestors:
ppisar [...] redhat.com
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
0.10

Attachments


Subject: t/99-pod.t fails due to non-escaped slash in the link
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.13-17155-1374335637-1018.0-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 760
0.10 POD test fails with perl 5.18 that has stricter POD parser: $ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/1-business-hours.t .. ok t/2-holidays.t ........ ok t/99-pod-coverage.t ... ok t/99-pod.t ............ 1/1 # Failed test 'POD test for blib/lib/Business/Hours.pm' # at /usr/share/perl5/vendor_perl/Test/Pod.pm line 186. # blib/lib/Business/Hours.pm (157): alternative text '/"holidays ARRAY"' contains non-escaped | or / # blib/lib/Business/Hours.pm (179): alternative text '/"business_hours HASH"' contains non-escaped | or / # Looks like you failed 1 test of 1. t/99-pod.t ............ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests
MIME-Version: 1.0
In-Reply-To: <rt-4.0.13-17155-1374335637-1018.0-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: API
References: <rt-4.0.13-17155-1374335637-1018.0-0-0@rt.cpan.org>
Content-Type: multipart/mixed; boundary="----------=_1374335983-15780-3"
Message-ID: <rt-4.0.13-15780-1374335983-467.0-0-0@rt.cpan.org>
Message-ID: <rt-4.0.13-15780-1374335983-734.87106-0-0@rt.cpan.org>
X-RT-Original-Encoding: utf-8
From: ppisar@redhat.com
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 141
Dne So 20.čec.2013 11:53:57, ppisar napsal(a):
Show quoted text
> 0.10 POD test fails with perl 5.18 that has stricter POD parser:
Fix is attached. -- Petr
MIME-Version: 1.0
Subject: Business-Hours-0.10-Fix-POD-syntax.patch
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Type: text/x-patch; name="Business-Hours-0.10-Fix-POD-syntax.patch"
Content-Disposition: inline; filename="Business-Hours-0.10-Fix-POD-syntax.patch"
Content-Transfer-Encoding: binary
Content-Length: 1313
From 8ba47e61ff99b7225445224149f89d376dd6bda7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Sat, 20 Jul 2013 17:53:47 +0200 Subject: [PATCH] Fix POD syntax MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit <https://rt.cpan.org/Public/Bug/Display.html?id=87106> Signed-off-by: Petr Písař <ppisar@redhat.com> --- lib/Business/Hours.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Business/Hours.pm b/lib/Business/Hours.pm index 28704cf..28c967e 100644 --- a/lib/Business/Hours.pm +++ b/lib/Business/Hours.pm @@ -154,7 +154,7 @@ an array reference value, for example: holidays => [qw(01-01 12-25 2009-05-08)], ); -Read more about holidays specification below in L</"holidays ARRAY"|holidays>. +Read more about holidays specification below in L<"holidays ARRAY"|holidays>. =cut @@ -176,7 +176,7 @@ Specification with year defined may be required when a holiday matches Sunday or Saturday. In many countries days are shifted in such case. -Holidays can be set via L</"business_hours HASH"|business_hours> method +Holidays can be set via L<"business_hours HASH"|business_hours> method as well, so you can use this feature without changing your code. =cut -- 1.8.1.4
From alex@chmrr.net Sat Jul 20 12: 06:54 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-5.905 tagged_above=-99.9 required=10 tests=[AWL=0.994, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_FAIL=0.001] autolearn=ham
In-Reply-To: <rt-4.0.13-15780-1374335983-1445.87106-5-0@rt.cpan.org>
X-Mailer: Evolution 3.2.3-0ubuntu6
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-87106@rt.cpan.org> <rt-4.0.13-17155-1374335637-1018.87106-5-0@rt.cpan.org> <rt-4.0.13-15780-1374335983-1445.87106-5-0@rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <1374336392.20188.18.camel@umgah.localdomain>
content-type: text/plain; charset="utf-8"
X-Connected-Ip: 65.96.172.157:42377
X-Date: 2013-07-20 12:07:12
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.905
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id E77722404FA for <cpan-bug+Business-Hours@hipster.bestpractical.com>; Sat, 20 Jul 2013 12:06:54 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R1GH041NgHSD for <cpan-bug+Business-Hours@hipster.bestpractical.com>; Sat, 20 Jul 2013 12:06:54 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id E16B424038F for <bug-Business-Hours@rt.cpan.org>; Sat, 20 Jul 2013 12:06:53 -0400 (EDT)
Received: (qmail 20278 invoked by alias); 20 Jul 2013 16:06:53 -0000
Received: from chmrr.net (HELO utwig.chmrr.net) (209.67.253.66) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Sat, 20 Jul 2013 09:06:47 -0700
Received: from c-65-96-172-157.hsd1.ma.comcast.net ([65.96.172.157] helo=[10.0.1.28]) by utwig.chmrr.net with esmtpsa (SSLv3:CAMELLIA256-SHA:256) (Exim 4.76) (envelope-from <alex@chmrr.net>) id 1V0ZgZ-0004em-Kf for bug-Business-Hours@rt.cpan.org; Sat, 20 Jul 2013 12:07:12 -0400
Delivered-To: cpan-bug+Business-Hours@hipster.bestpractical.com
Subject: Re: [rt.cpan.org #87106] t/99-pod.t fails due to non-escaped slash in the link
Return-Path: <alex@chmrr.net>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Business-Hours@hipster.bestpractical.com
X-RT-Mail-Extension: business-hours
Date: Sat, 20 Jul 2013 12:06:32 -0400
X-Spam-Level:
X-Authenticated-User: chmrr
X-Sender-Verify: SUCCEEDED (sender exists & accepts mail)
To: bug-Business-Hours@rt.cpan.org
Content-Transfer-Encoding: quoted-printable
X-Authenticator: plain
X-Exim-Version: 4.76 (build at 25-May-2011 17:04:25)
From: Alex Vandiver <alex@chmrr.net>
RT-Message-ID: <rt-4.0.13-17155-1374336415-1374.87106-0-0@rt.cpan.org>
Content-Length: 416
On Sat, 2013-07-20 at 11:59 -0400, Petr Pisar via RT wrote:
Show quoted text
> Queue: Business-Hours > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=87106 > > > Dne So 20.čec.2013 11:53:57, ppisar napsal(a):
> > 0.10 POD test fails with perl 5.18 that has stricter POD parser:
> > Fix is attached.
Thanks for the report. I've pushed a slightly more correct fix, and 0.11 will be on its way to PAUSE shortly. - Alex


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.