Skip Menu |
 

This queue is for tickets about the Math-Int128 CPAN distribution.

Report information
The Basics
Id: 87041
Status: resolved
Worked: 1 hour (60 min)
Priority: 0/
Queue: Math-Int128

People
Owner: Nobody in particular
Requestors: d.thomas [...] its.uq.edu.au
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: doesn't recognize RHEL6 gcc 4.4.7; also patch to silence warnings
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
Message-ID: <rt-4.0.13-583-1374222789-553.0-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1374222789-583-2"
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
Content-Length: 1869
Download (untitled) / with headers
text/plain 1.8k
NB using locally built perl-5.16.3 (without threads) root@noble$ cat /etc/redhat-release Red Hat Enterprise Linux Server release 6.4 (Santiago) root@noble$ cc --version --verbose 2>&1 cc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-3) Copyright (C) 2010 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. root@noble$ gcc --version --verbose 2>&1 gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-3) Copyright (C) 2010 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. changing line 35 of Makefile.PL to unless ($cc_version =~ /^g?cc\s+\(GCC\)\s+(4\.(\d+)\S*)/im and $2 >= 4) { NB I don't have ready access to clang/llvm which has become the first practical alternative to gcc and is now the default compiler on OSX & FreeBSD. I don't have acess to clang/llvm include files but googling "llvm __int128_t" suggests it has been supported for a while http://llvm.org/bugs/show_bug.cgi?id=9659 root@noble$ perl Makefile.PL Checking if your kit is complete... Looks good Writing Makefile for Math::Int128 Writing MYMETA.yml and MYMETA.json GNU C compiler version 4.4.7 found, good! "make test" PASSes Submitted patch which silences all but warning in strtoint128.h. Applying that initialization of upper_mul_limit results in t/Math-Int128.t ... No subtests run t/Math-UInt128.t .. No subtests run Anyway, all tests PASS after applying patch. NB there were a similar set of warnings with Math::Int64 I don't think it's actually used, but both Math-UInt128.t and Math-Int128.t start "#!/usr/bin/perl" which is certainly NOT the perl I'm building against. Bonus points for pod tests being author-only
Subject: Math-Int128-0.11.patch
MIME-Version: 1.0
Content-Type: application/octet-stream; name="Math-Int128-0.11.patch"
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline; filename="Math-Int128-0.11.patch"
Content-Transfer-Encoding: base64
Content-Length: 4564
diff -u Math-Int128-0.11.orig/Int128.xs Math-Int128-0.11/Int128.xs --- Math-Int128-0.11.orig/Int128.xs 2013-07-18 16:52:14.000000000 +1000 +++ Math-Int128-0.11/Int128.xs 2013-07-19 18:01:22.923496286 +1000 @@ -121,10 +121,12 @@ static char *sub_error = "Subtraction overflows"; static char *inc_error = "Increment operation wraps"; static char *dec_error = "Decrement operation wraps"; +#if 0 /* prevent 4 cases of "‘xxxxx’ defined but not used" */ static char *left_b_error = "Left-shift right operand is out of bounds"; static char *left_error = "Left shift overflows"; static char *right_b_error = "Right-shift right operand is out of bounds"; static char *right_error = "Right shift overflows"; +#endif static char *div_by_0_error = "Illegal division by zero"; static void croak_string(pTHX_ const char *str) { @@ -200,6 +202,7 @@ return si128; } croak_string(aTHX_ "internal error: reference to int128_t expected"); + return 0; /* silence gcc "control reaches end of non-void function" */ } static SV * @@ -210,6 +213,7 @@ return su128; } croak_string(aTHX_ "internal error: reference to uint128_t expected"); + return 0; /* silence gcc "control reaches end of non-void function" */ } #define SvI128x(sv) SvI128Y(SvSI128(aTHX_ sv)) @@ -878,7 +882,7 @@ CODE: if (may_die_on_overflow) { int neg = 0; - uint128_t a, b, rl, rh; + uint128_t a, b; /* , rl, rh; */ if (a1 < 0) { a = -a1; neg ^= 1; @@ -1256,8 +1260,8 @@ SV * mi128_string(self, ...) SV *self -PREINIT: - STRLEN len; +# PREINIT: +# STRLEN len; CODE: RETVAL = newSV(I128STRLEN); SvPOK_on(RETVAL); @@ -1476,7 +1480,7 @@ SV *other SV *rev PREINIT: - int sign; +# int sign; uint128_t r; int128_t a, b; CODE: @@ -1693,8 +1697,8 @@ SV * mu128_string(self, ...) SV *self -PREINIT: - STRLEN len; +# PREINIT: +# STRLEN len; CODE: RETVAL = newSV(I128STRLEN); SvPOK_on(RETVAL); @@ -1761,7 +1765,7 @@ CODE: if (may_die_on_overflow) { int neg = 0; - uint128_t a, b, rl, rh; + uint128_t a, b; /* , rl, rh; */ if (a1 < 0) { a = -a1; neg ^= 1; Common subdirectories: Math-Int128-0.11.orig/benchmarks and Math-Int128-0.11/benchmarks diff -u Math-Int128-0.11.orig/c_api.h Math-Int128-0.11/c_api.h --- Math-Int128-0.11.orig/c_api.h 2012-09-10 21:21:21.000000000 +1000 +++ Math-Int128-0.11/c_api.h 2013-07-19 17:59:57.530721220 +1000 @@ -14,14 +14,14 @@ static void init_c_api(pTHX) { HV *hv = get_hv("Math::Int128::C_API", TRUE|GV_ADDMULTI); - hv_store(hv, "min_version", 11, newSViv(1), 0); - hv_store(hv, "max_version", 11, newSViv(1), 0); - hv_store(hv, "SvI128", 6, newSViv(PTR2IV(&SvI128)), 0); - hv_store(hv, "SvI128OK", 8, newSViv(PTR2IV(&SvI128OK)), 0); - hv_store(hv, "SvU128", 6, newSViv(PTR2IV(&SvU128)), 0); - hv_store(hv, "SvU128OK", 8, newSViv(PTR2IV(&SvU128OK)), 0); - hv_store(hv, "newSVi128", 9, newSViv(PTR2IV(&newSVi128)), 0); - hv_store(hv, "newSVu128", 9, newSViv(PTR2IV(&newSVu128)), 0); + (void) hv_store(hv, "min_version", 11, newSViv(1), 0); + (void) hv_store(hv, "max_version", 11, newSViv(1), 0); + (void) hv_store(hv, "SvI128", 6, newSViv(PTR2IV(&SvI128)), 0); + (void) hv_store(hv, "SvI128OK", 8, newSViv(PTR2IV(&SvI128OK)), 0); + (void) hv_store(hv, "SvU128", 6, newSViv(PTR2IV(&SvU128)), 0); + (void) hv_store(hv, "SvU128OK", 8, newSViv(PTR2IV(&SvU128OK)), 0); + (void) hv_store(hv, "newSVi128", 9, newSViv(PTR2IV(&newSVi128)), 0); + (void) hv_store(hv, "newSVu128", 9, newSViv(PTR2IV(&newSVu128)), 0); } Common subdirectories: Math-Int128-0.11.orig/c_api_client and Math-Int128-0.11/c_api_client Common subdirectories: Math-Int128-0.11.orig/lib and Math-Int128-0.11/lib diff -u Math-Int128-0.11.orig/strtoint128.h Math-Int128-0.11/strtoint128.h --- Math-Int128-0.11.orig/strtoint128.h 2012-09-10 21:14:26.000000000 +1000 +++ Math-Int128-0.11/strtoint128.h 2013-07-19 18:00:22.981250266 +1000 @@ -44,7 +44,7 @@ uint128_t acc = 0; int c, neg, between = 0; - uint128_t upper_mul_limit; + uint128_t upper_mul_limit;/* = (UINT128_MAX / base); /* ??? round-up needed when base not power of 2 */ /* * Skip white space and pick up leading +/- sign if any. Common subdirectories: Math-Int128-0.11.orig/t and Math-Int128-0.11/t
MIME-Version: 1.0
X-Spam-Flag: NO
X-Yahoo-Newman-ID: 277424.13409.bm [...] omp1003.mail.bf1.yahoo.com
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.999
X-Rocket-Mimeinfo: 002.001,CgoKCi0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0KPiBGcm9tOiAiZC50aG9tYXNAaXRzLnVxLmVkdS5hdSB2aWEgUlQiIDxidWctTWF0aC1JbnQxMjhAcnQuY3Bhbi5vcmc.Cj4gVG86IAo.IENjOiAKPiBTZW50OiBGcmlkYXksIEp1bHkgMTksIDIwMTMgMTA6MzMgQU0KPiBTdWJqZWN0OiBbcnQuY3Bhbi5vcmcgIzg3MDQxXSBkb2Vzbid0IHJlY29nbml6ZSBSSEVMNiBnY2MgNC40Ljc7IGFsc28gcGF0Y2ggdG8gc2lsZW5jZSB3YXJuaW5ncwoKSXQgc2VlbXMgZXZlcnkgdmVuZG9yIGxpa2VzIGNoYW5naW4BMAEBAQE-
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] yahoo.com
Authentication-Results: hipster.bestpractical.com (amavisd-new); domainkeys=pass header.from=sfandino [...] yahoo.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 31EA32403B0 for <cpan-bug+Math-Int128 [...] hipster.bestpractical.com>; Fri, 19 Jul 2013 06:58:45 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aiF3Ci8Qkp9K for <cpan-bug+Math-Int128 [...] hipster.bestpractical.com>; Fri, 19 Jul 2013 06:58:43 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id C2ACB240388 for <bug-Math-Int128 [...] rt.cpan.org>; Fri, 19 Jul 2013 06:58:42 -0400 (EDT)
Received: (qmail 5508 invoked by alias); 19 Jul 2013 10:58:42 -0000
Received: from nm8-vm0.bullet.mail.bf1.yahoo.com (HELO nm8-vm0.bullet.mail.bf1.yahoo.com) (98.139.213.95) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 19 Jul 2013 03:58:35 -0700
Received: from [98.139.215.140] by nm8.bullet.mail.bf1.yahoo.com with NNFMP; 19 Jul 2013 10:58:31 -0000
Received: from [98.139.212.194] by tm11.bullet.mail.bf1.yahoo.com with NNFMP; 19 Jul 2013 10:58:31 -0000
Received: from [127.0.0.1] by omp1003.mail.bf1.yahoo.com with NNFMP; 19 Jul 2013 10:58:31 -0000
Received: (qmail 73640 invoked by uid 60001); 19 Jul 2013 10:58:30 -0000
Received: from [92.56.140.25] by web163102.mail.bf1.yahoo.com via HTTP; Fri, 19 Jul 2013 03:58:29 PDT
Delivered-To: cpan-bug+Math-Int128 [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #87041] doesn't recognize RHEL6 gcc 4.4.7; also patch to silence warnings
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1374231510; bh=MhxJIkGaXcL+Sw+1qE4glHU17cT2E5lJWMaRfjOdssk=; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type; b=QaaxyD6jdZqBVKF0noGjUqHDyIgvsraCMN6AHUbVRLqkyLEWq1wDNNGjxjuHzsZ2htuiZfJ4S0LH3w1n0/LYOil28BKL7S3rWGhS6/FyW8kXfewDuxeRZ7BmshuXaZrXi8dW5bUR3YVkRr9WNa6zPfO9BEGY8PwvO3UPaFNMDbY=
X-Spam-Check-BY: la.mx.develooper.com
Date: Fri, 19 Jul 2013 03:58:29 -0700 (PDT)
X-Spam-Level:
To: "bug-Math-Int128 [...] rt.cpan.org" <bug-Math-Int128 [...] rt.cpan.org>
From sfandino [...] yahoo.com Fri Jul 19 06: 58:45 2013
X-Ymail-Osg: h69tnKQVM1nNMhYgccaZxPz5BBVoes5dfLAP9BJuLFe7E40 7LBJfxIviP18Hagc-
In-Reply-To: <rt-4.0.13-583-1374222789-836.87041-4-0 [...] rt.cpan.org>
X-Spam-Status: No, score=-6.999 tagged_above=-99.9 required=10 tests=[AWL=0.000, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5] autolearn=ham
X-Mailer: YahooMailWebService/0.8.149.560
X-RT-Interface: API
References: <RT-Ticket-87041 [...] rt.cpan.org> <rt-4.0.13-583-1374222789-836.87041-4-0 [...] rt.cpan.org>
Reply-To: Salvador Fandino <sfandino [...] yahoo.com>
Message-ID: <1374231509.73567.YahooMailNeo [...] web163102.mail.bf1.yahoo.com>
X-Yahoo-Newman-Property: ymail-3
Domainkey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type; b=Rmf7lwe2plPQ6F6skmTTpctWASkr9fS2WyEDaD8bcNU2DVjKRmUU/kYds4pQ9MpaITVeM+SIMGI6cHmAPlKz7T9WZ5o/TBgdDsa09oieJtBBC+Woe845lmK9Ufjvg3xxjBikPWSBT/Cvc1zLSXAHHR8fzsG4h9kgG36tzMU+hnk=;
Return-Path: <sfandino [...] yahoo.com>
X-RT-Mail-Extension: math-int128
X-Original-To: cpan-bug+Math-Int128 [...] hipster.bestpractical.com
From: Salvador Fandino <sfandino [...] yahoo.com>
RT-Message-ID: <rt-4.0.13-4028-1374231526-1815.87041-0-0 [...] rt.cpan.org>
Content-Length: 476
Download (untitled) / with headers
text/plain 476b
Show quoted text
----- Original Message -----
> From: "d.thomas@its.uq.edu.au via RT" <bug-Math-Int128@rt.cpan.org> > To: > Cc: > Sent: Friday, July 19, 2013 10:33 AM > Subject: [rt.cpan.org #87041] doesn't recognize RHEL6 gcc 4.4.7; also patch to silence warnings
It seems every vendor likes changing the way GCC reports its version. I have added support for the format you have described. Version 0.12 is now available from CPAN: https://metacpan.org/release/SALVA/Math-Int128-0.12
MIME-Version: 1.0
X-Spam-Flag: NO
X-Yahoo-Newman-ID: 120394.20727.bm [...] omp1022.mail.bf1.yahoo.com
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.999
X-Rocket-Mimeinfo: 002.001,CgoKCi0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0KPiBGcm9tOiAiU2FsdmFkb3IgXCJGYW5kacOxb1wi77u_IHZpYSBSVCIgPGJ1Zy1NYXRoLUludDEyOEBydC5jcGFuLm9yZz4KPiBUbzogCj4gQ2M6IAo.IFNlbnQ6IEZyaWRheSwgSnVseSAxOSwgMjAxMyAxMjo1OCBQTQo.IFN1YmplY3Q6IFJlOiBbcnQuY3Bhbi5vcmcgIzg3MDQxXSBkb2Vzbid0IHJlY29nbml6ZSBSSEVMNiBnY2MgNC40Ljc7IGFsc28gcGF0Y2ggdG8gc2lsZW5jZSB3YXJuaW5ncwo.IAo.IMKgIMKgIMKgICBRdWV1ZTogTWF0aC1JbnQBMAEBAQE-
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] yahoo.com
Authentication-Results: hipster.bestpractical.com (amavisd-new); domainkeys=pass header.from=sfandino [...] yahoo.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id EF6D72403B0 for <cpan-bug+Math-Int128 [...] hipster.bestpractical.com>; Fri, 19 Jul 2013 08:05:45 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TCsbTEPvHuYe for <cpan-bug+Math-Int128 [...] hipster.bestpractical.com>; Fri, 19 Jul 2013 08:05:43 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id E1FE324001F for <bug-Math-Int128 [...] rt.cpan.org>; Fri, 19 Jul 2013 08:05:42 -0400 (EDT)
Received: (qmail 10348 invoked by alias); 19 Jul 2013 12:05:42 -0000
Received: from nm39-vm5.bullet.mail.bf1.yahoo.com (HELO nm39-vm5.bullet.mail.bf1.yahoo.com) (72.30.239.149) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 19 Jul 2013 05:05:35 -0700
Received: from [98.139.215.140] by nm39.bullet.mail.bf1.yahoo.com with NNFMP; 19 Jul 2013 12:05:31 -0000
Received: from [98.139.212.213] by tm11.bullet.mail.bf1.yahoo.com with NNFMP; 19 Jul 2013 12:05:31 -0000
Received: from [127.0.0.1] by omp1022.mail.bf1.yahoo.com with NNFMP; 19 Jul 2013 12:05:31 -0000
Received: (qmail 52735 invoked by uid 60001); 19 Jul 2013 12:05:31 -0000
Received: from [92.56.140.25] by web163104.mail.bf1.yahoo.com via HTTP; Fri, 19 Jul 2013 05:05:29 PDT
Delivered-To: cpan-bug+Math-Int128 [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #87041] doesn't recognize RHEL6 gcc 4.4.7; also patch to silence warnings
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1374235530; bh=m8k1FF63HObtqEPJyEIGbypHPOHdZxlvVRB0oW80jVU=; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=5JDmHCG7IrL6Blx0dk+/NEpL1ouH6DaCLscvb7c/lo6fNhKHUQi3V5VY6OqpKtII1nqTL7uzdbIsIoEP21onmQHcT/r0KJcAY/g5KOkKsHm1cxg6XSc5cXc5wIM1o7PYscSmRIuxSCwFE06RVuTOsyjPMcbHk8GNAQJopGg4sVE=
X-Spam-Check-BY: la.mx.develooper.com
Date: Fri, 19 Jul 2013 05:05:29 -0700 (PDT)
X-Spam-Level:
To: "bug-Math-Int128 [...] rt.cpan.org" <bug-Math-Int128 [...] rt.cpan.org>
Content-Transfer-Encoding: quoted-printable
From sfandino [...] yahoo.com Fri Jul 19 08: 05:46 2013
X-Ymail-Osg: MT5HCBkVM1mrJVsXXk1OsXbz1yOD4WkMcmqq6D.WPSkwdll i6uz5FtlWyS5t0Ig-
In-Reply-To: <rt-4.0.13-4028-1374231526-1390.87041-5-0 [...] rt.cpan.org>
X-Spam-Status: No, score=-6.999 tagged_above=-99.9 required=10 tests=[AWL=0.000, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5] autolearn=ham
X-Mailer: YahooMailWebService/0.8.149.560
X-RT-Interface: API
References: <RT-Ticket-87041 [...] rt.cpan.org> <rt-4.0.13-583-1374222789-836.87041-4-0 [...] rt.cpan.org> <1374231509.73567.YahooMailNeo [...] web163102.mail.bf1.yahoo.com> <rt-4.0.13-4028-1374231526-1390.87041-5-0 [...] rt.cpan.org>
Reply-To: Salvador Fandino <sfandino [...] yahoo.com>
Message-ID: <1374235529.51154.YahooMailNeo [...] web163104.mail.bf1.yahoo.com>
X-Yahoo-Newman-Property: ymail-3
Domainkey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=OtjBXu73V3Aaq5mUQKSEgoPxU+0+OgtTEzD+FVAwRjxfDmYHXKhkifqPPPAS1nhCtetg9j5YHQWyJ5jcLn+VAiL0i0Q+dMVjdngKMTA6STZ1/5vosWixVczu6mt02alMzgVNicakN+SdlmQgWE7g06X5Fk2nWHbwEK4Yh/9TGb8=;
Return-Path: <sfandino [...] yahoo.com>
X-RT-Mail-Extension: math-int128
X-Original-To: cpan-bug+Math-Int128 [...] hipster.bestpractical.com
From: Salvador Fandino <sfandino [...] yahoo.com>
RT-Message-ID: <rt-4.0.13-25765-1374235546-62.87041-0-0 [...] rt.cpan.org>
Content-Length: 950
Download (untitled) / with headers
text/plain 950b
Show quoted text
----- Original Message -----
> From: "Salvador \"Fandiño\" via RT" <bug-Math-Int128@rt.cpan.org> > To: > Cc: > Sent: Friday, July 19, 2013 12:58 PM > Subject: Re: [rt.cpan.org #87041] doesn't recognize RHEL6 gcc 4.4.7; also patch to silence warnings > >       Queue: Math-Int128 > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=87041 > > > > > > > ----- Original Message -----
>> From: "d.thomas@its.uq.edu.au via RT"
> <bug-Math-Int128@rt.cpan.org>
>> To: >> Cc: >> Sent: Friday, July 19, 2013 10:33 AM >> Subject: [rt.cpan.org #87041] doesn't recognize RHEL6 gcc 4.4.7; also
> patch to silence warnings > > It seems every vendor likes changing the way GCC reports its version. > > I have added support for the format you have described. > > Version 0.12 is now available from CPAN: > https://metacpan.org/release/SALVA/Math-Int128-0.12
oops, I didn't notice your patch, will apply it on the next version
MIME-Version: 1.0
X-Spam-Flag: NO
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.448
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 2AB72240F8D for <cpan-bug+Math-Int128 [...] hipster.bestpractical.com>; Fri, 19 Jul 2013 14:59:48 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1W2HYGbPAE+2 for <cpan-bug+Math-Int128 [...] hipster.bestpractical.com>; Fri, 19 Jul 2013 14:59:46 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 602FB240F0F for <bug-Math-Int128 [...] rt.cpan.org>; Fri, 19 Jul 2013 14:59:45 -0400 (EDT)
Received: (qmail 10099 invoked by alias); 19 Jul 2013 18:59:45 -0000
Received: from mailhub2.soe.uq.edu.au (HELO newmailhub.uq.edu.au) (130.102.132.209) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 19 Jul 2013 11:59:37 -0700
Received: from smtp1.soe.uq.edu.au (smtp1.soe.uq.edu.au [10.138.113.40]) by newmailhub.uq.edu.au (8.14.5/8.14.5) with ESMTP id r6JIxVX7004565 for <bug-Math-Int128 [...] rt.cpan.org>; Sat, 20 Jul 2013 04:59:31 +1000
Received: from UQEXET2.soe.uq.edu.au (uqexet2.soe.uq.edu.au [130.102.129.39]) by smtp1.soe.uq.edu.au (8.14.5/8.14.5) with ESMTP id r6JIxVsA031246 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT) for <bug-Math-Int128 [...] rt.cpan.org>; Sat, 20 Jul 2013 04:59:31 +1000
Received: from UQEXHT1.soe.uq.edu.au (130.102.129.70) by UQEXET2.soe.uq.edu.au (130.102.129.39) with Microsoft SMTP Server (TLS) id 14.1.355.2; Sat, 20 Jul 2013 04:59:31 +1000
Received: from UQEXMDA6.soe.uq.edu.au ([169.254.6.17]) by UQEXHT1.soe.uq.edu.au ([130.102.129.70]) with mapi id 14.01.0355.002; Sat, 20 Jul 2013 04:59:30 +1000
Delivered-To: cpan-bug+Math-Int128 [...] hipster.bestpractical.com
Subject: RE: [rt.cpan.org #87041] doesn't recognize RHEL6 gcc 4.4.7; also patch to silence warnings
X-Spam-Check-BY: la.mx.develooper.com
Thread-Index: AQHOhHhNUfYGV8ihFkWAKK35mBp9PplsWein
Date: Fri, 19 Jul 2013 18:59:30 +0000
X-Spam-Level:
To: "bug-Math-Int128 [...] rt.cpan.org" <bug-Math-Int128 [...] rt.cpan.org>
X-Uq-Filtertime: 1374260371
Content-Transfer-Encoding: quoted-printable
X-Scanned-BY: MIMEDefang 2.73 on UQ Mailhub
From d.thomas [...] its.uq.edu.au Fri Jul 19 14: 59:48 2013
In-Reply-To: <rt-4.0.13-25765-1374235546-1060.87041-6-0 [...] rt.cpan.org>
X-Spam-Status: No, score=-6.448 tagged_above=-99.9 required=10 tests=[AWL=0.452, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
X-RT-Interface: API
Content-Language: en-AU
References: <RT-Ticket-87041 [...] rt.cpan.org> <rt-4.0.13-583-1374222789-836.87041-4-0 [...] rt.cpan.org> <1374231509.73567.YahooMailNeo [...] web163102.mail.bf1.yahoo.com> <rt-4.0.13-4028-1374231526-1390.87041-5-0 [...] rt.cpan.org> <1374235529.51154.YahooMailNeo [...] web163104.mail.bf1.yahoo.com>,<rt-4.0.13-25765-1374235546-1060.87041-6-0 [...] rt.cpan.org>
Message-ID: <E358D2AD85D24A44BFBA062E49DD13D98D9ECD [...] UQEXMDA6.soe.uq.edu.au>
X-MS-Tnef-Correlator:
Return-Path: <d.thomas [...] its.uq.edu.au>
X-RT-Mail-Extension: math-int128
X-Original-To: cpan-bug+Math-Int128 [...] hipster.bestpractical.com
X-MS-Has-Attach:
Thread-Topic: [rt.cpan.org #87041] doesn't recognize RHEL6 gcc 4.4.7; also patch to silence warnings
X-Originating-Ip: [172.18.1.206]
Accept-Language: en-AU, en-US
From: Danny Thomas <d.thomas [...] its.uq.edu.au>
RT-Message-ID: <rt-4.0.13-24244-1374260388-1714.87041-0-0 [...] rt.cpan.org>
Content-Length: 443
Download (untitled) / with headers
text/plain 443b
Show quoted text
________________________________________
>oops, I didn't notice your patch, will apply it on the next version
luckily these are mostly straightforward except the strtoint128.h one, which is definitely worth a carfeful look and maybe an explicit test. In terms of checking compiler versions, it might be better having a simple c file that checks for __int128_t functionality instead. The code would need to handle things like 4.4<=gcc<4.6.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.13-24244-1374260388-1714.87041-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: API
References: <RT-Ticket-87041 [...] rt.cpan.org> <rt-4.0.13-583-1374222789-836.87041-4-0 [...] rt.cpan.org> <1374231509.73567.YahooMailNeo [...] web163102.mail.bf1.yahoo.com> <rt-4.0.13-4028-1374231526-1390.87041-5-0 [...] rt.cpan.org> <1374235529.51154.YahooMailNeo [...] web163104.mail.bf1.yahoo.com>, <rt-4.0.13-25765-1374235546-1060.87041-6-0 [...] rt.cpan.org> <E358D2AD85D24A44BFBA062E49DD13D98D9ECD [...] UQEXMDA6.soe.uq.edu.au> <rt-4.0.13-24244-1374260388-1714.87041-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.13-32742-1374437221-1754.0-0-0 [...] rt.cpan.org>
Message-ID: <rt-4.0.13-32742-1374437221-1110.87041-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
From: d.thomas [...] its.uq.edu.au
Content-Length: 453
Download (untitled) / with headers
text/plain 453b
I removed it from my initial report, but here's the options RHEL6 uses gcc -c -I. -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -DVERSION=\"0.12\" -DXS_VERSION=\"0.12\" -fPIC "-I/opt/perl/cis.perl-base2.rhel6-5.16.3-20130425/lib/5.16.3/x86_64-linux/CORE" Int128.c
MIME-Version: 1.0
In-Reply-To: <rt-4.0.13-583-1374222789-553.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.13-583-1374222789-553.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.16-32292-1377693599-927.87041-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 64
patch applied. Thank you for reporting the issue and the patch!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.