Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 87032
Status: open
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.120



Subject: wrong return precedence in Perl::Critic::Utils::interpolate
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.13-19739-1374182595-1950.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 312
Download (untitled) / with headers
text/plain 312b
Please patch Perl::Critic::Utils, line 334: < return eval "\"$literal\"" or confess $EVAL_ERROR; ## no critic (StringyEval); Show quoted text
> return (eval "\"$literal\"" || confess $EVAL_ERROR); ## no critic (StringyEval);
the or confess is ignored otherwise. See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
From jeff [...] imaginative-software.com Fri Jul 26 18: 26:38 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.815 tagged_above=-99.9 required=10 tests=[AWL=0.084, BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-4.0.13-19739-1374182596-14.87032-4-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-87032 [...] rt.cpan.org> <rt-4.0.13-19739-1374182596-14.87032-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.194.158.130 with SMTP id wu2mr36392555wjb.12.1374877585284; Fri, 26 Jul 2013 15:26:25 -0700 (PDT)
Message-ID: <CABE6C1EyH8B8N04VXiVfG-qr8n5B2aqf+k-qNa1K+Pgd5NiSYA [...] mail.gmail.com>
Content-Type: multipart/alternative; boundary="089e013c6ab814b36b04e271a2e7"
X-Spam-Score: -6.815
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 20DD1241008 for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 26 Jul 2013 18:26:38 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9MdwaNv7k3hv for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 26 Jul 2013 18:26:36 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 05E74241006 for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 26 Jul 2013 18:26:35 -0400 (EDT)
Received: (qmail 20041 invoked by alias); 26 Jul 2013 22:26:35 -0000
Received: from mail-wi0-f180.google.com (HELO mail-wi0-f180.google.com) (209.85.212.180) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 26 Jul 2013 15:26:29 -0700
Received: by mail-wi0-f180.google.com with SMTP id c10so1386283wiw.7 for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 26 Jul 2013 15:26:25 -0700 (PDT)
Received: by 10.180.12.238 with HTTP; Fri, 26 Jul 2013 15:26:25 -0700 (PDT)
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #87032] wrong return precedence in Perl::Critic::Utils::interpolate
Return-Path: <jeff [...] imaginative-software.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:x-gm-message-state; bh=36nICZhPCqM1ObBVuAwHMnoAMMRmaw+gMnFf9ISqVUI=; b=oT8O8ho8NKmorKmU7MZjjUTPmXqQ1n5oqtECg4sIgWVk3AI2wQQ5D7JRIAk/e7NfKm 2qBNo1WyjQYx/fZpsU7fnCaAf4IZg5NI3ve/2ylqQZmZyHSBrRM26D4lAhrpwTguCKZR iVmTW/L9tFTgXDvgNut8CBY9CMLxhqqiLK1cdltDVxq+pvK7oZUdl3rMYigpK/ct4o9l cs2YDxBZnuofSGLaI5vV+iNsV/7aIMZgKvWGc3BNZv89t/ni+MOe/5HYVBwPGXJGx57y ogE4wV5G73WadLh5Owsdp8l3WYQdk6x1ipUaOKVDF2luM35bC2B/cIbCaRE7NBDwosma 6Zcw==
Date: Fri, 26 Jul 2013 15:26:25 -0700
X-Spam-Level:
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey" <jeff [...] imaginative-software.com>
X-GM-Message-State: ALoCoQk5gJf8U6rTOIaEOYmCduxrWiXH8ejPLECbnfV00I4PPREE/ovbQ0U7nHxB8YA4Rr9kAkjt
RT-Message-ID: <rt-4.0.14-5640-1374877599-688.87032-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 320
Download (untitled) / with headers
text/plain 320b
Good catch Reini. This will be the first bug we fix when we after we move to GitHub (should be any day now). https://rt.cpan.org/Public/Bug/Display.html?id=86973 I'll also make a TODO about writing a policy to detect this, since it doesn't seem like perl is ever going to warn about it. Have a great weekend! -Jeff
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 479
From reini.urban [...] gmail.com Mon Jul 29 13: 03:23 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-5.53 tagged_above=-99.9 required=10 tests=[AWL=0.590, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
In-Reply-To: <rt-4.0.14-5640-1374877599-1058.87032-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-87032 [...] rt.cpan.org> <rt-4.0.13-19739-1374182596-14.87032-4-0 [...] rt.cpan.org> <CABE6C1EyH8B8N04VXiVfG-qr8n5B2aqf+k-qNa1K+Pgd5NiSYA [...] mail.gmail.com> <rt-4.0.14-5640-1374877599-1058.87032-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.60.116.6 with SMTP id js6mr24462408oeb.4.1375117383622; Mon, 29 Jul 2013 10:03:03 -0700 (PDT)
Message-ID: <CAHiT=DHDC2fv2_q29kNq3Pt4OAOqxEh3G5OsV7QHC15=dXuXRQ [...] mail.gmail.com>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.53
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 0259224051F for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Mon, 29 Jul 2013 13:03:23 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SNBDd8Urb2ac for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Mon, 29 Jul 2013 13:03:19 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 79E4E24041D for <bug-Perl-Critic [...] rt.cpan.org>; Mon, 29 Jul 2013 13:03:19 -0400 (EDT)
Received: (qmail 26595 invoked by alias); 29 Jul 2013 17:03:18 -0000
Received: from mail-ob0-f169.google.com (HELO mail-ob0-f169.google.com) (209.85.214.169) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 29 Jul 2013 10:03:07 -0700
Received: by mail-ob0-f169.google.com with SMTP id wc20so3593278obb.28 for <bug-Perl-Critic [...] rt.cpan.org>; Mon, 29 Jul 2013 10:03:03 -0700 (PDT)
Received: by 10.182.18.68 with HTTP; Mon, 29 Jul 2013 10:03:03 -0700 (PDT)
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #87032] wrong return precedence in Perl::Critic::Utils::interpolate
Return-Path: <reini.urban [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=Er2vWE8Q+TTs5GuoTwOwDTV6hcLGnAcih36M5DX3Vtc=; b=DTlFFXv3h6MtvqwqMMUiYNo9aa5v9AeJYVox4gw/bTvfaNPv+i/6x1uEaSC3PwvqIs WUzLC551VeVPjbXwUV06r0cxbtBaHW1d7+XfephXyYEh/Bel0JSsGP2ipEqUhk9rwzE6 ZKHVR0xIbLtQDZ+0zRttg219ol31yK2Qkpj/QzeQ4yJhdTOYaVw/x7XAluPxJs/7fLIp iapO91RulAus+Q5KU2vzjkrQ9N+3us8cunBGca8CNX5FcI7Q03XtkrYi4hMPyYsu9SWd GSLWvZKytVhUJSjuXTH8mi4tWUubGl5OQ8iRXHDOIyAgPaKmmFPcYk+/WhRJqyYcaFvF v0Sw==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic
X-Google-Sender-Auth: LBACgvwiiQhdFKRdQyVhY-bcxU4
Sender: reini.urban [...] gmail.com
Date: Mon, 29 Jul 2013 12:03:03 -0500
X-Spam-Level:
To: bug-Perl-Critic [...] rt.cpan.org
From: Reini Urban <rurban [...] x-ray.at>
RT-Message-ID: <rt-4.0.14-3966-1375117403-1049.87032-0-0 [...] rt.cpan.org>
Content-Length: 761
Download (untitled) / with headers
text/plain 761b
On Fri, Jul 26, 2013 at 5:26 PM, Jeffrey Thalhammer via RT <bug-Perl-Critic@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=87032 > > > Good catch Reini. This will be the first bug we fix when we after we move > to GitHub (should be any day now). > https://rt.cpan.org/Public/Bug/Display.html?id=86973
Thanks Show quoted text
> I'll also make a TODO about writing a policy to detect this, since it > doesn't seem like perl is ever going to warn about it.
perl will warn about it soon :) That's how I detected it. See http://blogs.perl.org/users/rurban/2013/07/smoking-cpan.html and https://github.com/rurban/perl/commit/f86e1520a36f9b53a86479515c0e8e96814e20ee for the new warning. -- Reini Urban http://cpanel.net/ http://www.perl-compiler.org/
MIME-Version: 1.0
In-Reply-To: <rt-4.0.14-3966-1375117403-1049.87032-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-87032 [...] rt.cpan.org> <rt-4.0.13-19739-1374182596-14.87032-4-0 [...] rt.cpan.org> <CABE6C1EyH8B8N04VXiVfG-qr8n5B2aqf+k-qNa1K+Pgd5NiSYA [...] mail.gmail.com> <rt-4.0.14-5640-1374877599-1058.87032-6-0 [...] rt.cpan.org> <CAHiT=DHDC2fv2_q29kNq3Pt4OAOqxEh3G5OsV7QHC15=dXuXRQ [...] mail.gmail.com> <rt-4.0.14-3966-1375117403-1049.87032-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-1779-1383058268-318.87032-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
RT-Send-CC: jeff [...] imaginative-software.com
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1037
On Mon Jul 29 13:03:23 2013, rurban@x-ray.at wrote: Show quoted text
> On Fri, Jul 26, 2013 at 5:26 PM, Jeffrey Thalhammer via RT > <bug-Perl-Critic@rt.cpan.org> wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=87032 > > > > > Good catch Reini. This will be the first bug we fix when we after we > > move > > to GitHub (should be any day now). > > https://rt.cpan.org/Public/Bug/Display.html?id=86973
Hi Jeff, Reini, I ran into this issue when trying installing Perl::Cricit::Pulp on perl 5.19.5. This uses something like Test::Nowarnings in the test suite, so tests started failing for this module. I found this bug report and apparently there *is* a github repo but also I found a new release of Perl::Critic on CPAN which DOES have a fix for this RT in it, but apparently is still released from SVN because the github repo does NOT have the fix: https://github.com/Perl-Critic/Perl-Critic/blob/master/lib/Perl/Critic/Utils.pm#L334 So basically; 1.120 fixed this RT for me so it can be closed AND the github repo is not leading (yet).
From jeff [...] imaginative-software.com Thu Oct 31 14: 42:01 2013
MIME-Version: 1.0 (Apple Message framework v1283)
X-Spam-Status: No, score=-5.32 tagged_above=-99.9 required=10 tests=[AWL=1.579, BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-4.0.18-1779-1383058268-518.87032-5-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.1283)
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-87032 [...] rt.cpan.org> <rt-4.0.13-19739-1374182596-14.87032-4-0 [...] rt.cpan.org> <CABE6C1EyH8B8N04VXiVfG-qr8n5B2aqf+k-qNa1K+Pgd5NiSYA [...] mail.gmail.com> <rt-4.0.14-5640-1374877599-1058.87032-6-0 [...] rt.cpan.org> <CAHiT=DHDC2fv2_q29kNq3Pt4OAOqxEh3G5OsV7QHC15=dXuXRQ [...] mail.gmail.com> <rt-4.0.14-3966-1375117403-1049.87032-5-0 [...] rt.cpan.org> <rt-4.0.18-1779-1383058268-518.87032-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.68.171.5 with SMTP id aq5mr2727544pbc.21.1383244911534; Thu, 31 Oct 2013 11:41:51 -0700 (PDT)
Content-Type: multipart/alternative; boundary="Apple-Mail=_8B6827A9-7D4A-4662-9229-60A641B22C56"
Message-ID: <CF0E4C1C-B313-4930-8D38-3118B821BC0F [...] imaginative-software.com>
X-Spam-Score: -5.32
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id B377B240CC8 for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Thu, 31 Oct 2013 14:42:01 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3Q6eE3W+bLer for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Thu, 31 Oct 2013 14:42:00 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 82CE72408AC for <bug-Perl-Critic [...] rt.cpan.org>; Thu, 31 Oct 2013 14:42:00 -0400 (EDT)
Received: (qmail 27765 invoked by alias); 31 Oct 2013 18:41:59 -0000
Received: from mail-pb0-f47.google.com (HELO mail-pb0-f47.google.com) (209.85.160.47) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Thu, 31 Oct 2013 11:41:55 -0700
Received: by mail-pb0-f47.google.com with SMTP id rq2so3198611pbb.34 for <bug-Perl-Critic [...] rt.cpan.org>; Thu, 31 Oct 2013 11:41:51 -0700 (PDT)
Received: from [10.0.1.6] (c-24-6-40-53.hsd1.ca.comcast.net. [24.6.40.53]) by mx.google.com with ESMTPSA id hi5sm5715250pbb.43.2013.10.31.11.41.49 for <bug-Perl-Critic [...] rt.cpan.org> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 31 Oct 2013 11:41:50 -0700 (PDT)
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #87032] wrong return precedence in Perl::Critic::Utils::interpolate
Return-Path: <jeff [...] imaginative-software.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type:subject:date :in-reply-to:to:references:message-id; bh=QeKC6mzdXpj543L53e8KHvMCW62tRF7j4Hiv2oFg1CQ=; b=il1JkGUdfJh8rVsabZ6bKk/tjGMsD1jvTXtpVtta1gdsD+w6yrCxRknYTxt7iM6kDt TkhXPzSUuTiKA5GYZVpvIsgu4jnZpdrEodjcY8Lk9OVMtOKL8v0azJmW/C1EiqY8Im4x UYPZ4vMZ6FuYp6Ku98+o+HBZYGk0QZY/l2F4ltoOQYDywp3Q8HqOgseNC8ihbGUu0V57 rAYj+ppPnrYBNmaa1VAOIg9d2aDzPdSQa4qaFtKOiUI2HymjwJtceDIOq9tHaMhIpTvw SqRLl2Jc+pTnAFK9z+WNLWKae+20T+U2KKJg4jnxbjDnhAw/q2LMfHl1pyrt725qo35u Crew==
Date: Thu, 31 Oct 2013 11:41:47 -0700
X-Spam-Level:
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Ryan Thalhammer <jeff [...] imaginative-software.com>
X-GM-Message-State: ALoCoQnse6gh6yZYfJKa/o675tuQ+Uo4eJVHEVc5ewM/SVwArCFoKTZEgRAcgS0I7vjnR+SV3Qtq
RT-Message-ID: <rt-4.0.18-13308-1383244922-1512.87032-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 348
Download (untitled) / with headers
text/plain 348b
On Oct 29, 2013, at 7:51 AM, Michiel Beijen via RT wrote: Show quoted text
> So basically; 1.120 fixed this RT for me so it can be closed AND the github repo is not leading (yet).
The GitHub repo is now sync'd up with Subversion (actually, GitHub is now ahead). The next release (1.121) will come from GitHub. After that, the Subversion repo will be abandoned.
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1160


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.