Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Workflow CPAN distribution.

Report information
The Basics
Id: 85380
Status: resolved
Priority: 0/
Queue: Workflow

People
Owner: jonasbn [...] cpan.org
Requestors: kaynehril [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.38



From kaynehril [...] gmail.com Fri May 17 11: 26:40 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.219 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
X-Spam-Flag: NO
Content-Type: multipart/alternative; boundary="047d7b2e41e6bf1e8604dceb9ad9"
Message-ID: <CAAism74ZM9MbaPZZyTXALr5sUFvik6aE7O2OZ2+=36zFzhbKqA [...] mail.gmail.com>
X-Received: by 10.182.97.168 with SMTP id eb8mr21938617obb.89.1368804378481; Fri, 17 May 2013 08:26:18 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -6.219
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 10A25240992 for <cpan-bug+Workflow [...] hipster.bestpractical.com>; Fri, 17 May 2013 11:26:40 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ui5kDF9y0QNj for <cpan-bug+Workflow [...] hipster.bestpractical.com>; Fri, 17 May 2013 11:26:35 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id BE39E240700 for <bug-Workflow [...] rt.cpan.org>; Fri, 17 May 2013 11:26:34 -0400 (EDT)
Received: (qmail 2976 invoked by alias); 17 May 2013 15:26:33 -0000
Received: from mail-oa0-f54.google.com (HELO mail-oa0-f54.google.com) (209.85.219.54) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 17 May 2013 08:26:27 -0700
Received: by mail-oa0-f54.google.com with SMTP id o17so5353256oag.13 for <bug-Workflow [...] rt.cpan.org>; Fri, 17 May 2013 08:26:18 -0700 (PDT)
Received: by 10.182.96.9 with HTTP; Fri, 17 May 2013 08:26:18 -0700 (PDT)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Delivered-To: cpan-bug+Workflow [...] hipster.bestpractical.com
Subject: Possible bug in Workflow::Persister::DBI
Return-Path: <kaynehril [...] gmail.com>
X-RT-Mail-Extension: workflow
X-Original-To: cpan-bug+Workflow [...] hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to :content-type; bh=TdxfociXHGFAOmpz/gz+wiNLjTUnQZe39YOvU5HADKc=; b=Yv5GFsb9R/PastmCAXZo/MpzW+g01XZ4AF45gLHCvSUDikA74Yl5xnnn1q6SV2sEHr jsPiciAGBXupcnmp7Y3o00e8hPC/61AcgQWKLf68HP07+IcCZY0Lp6CMeo/by224F7PQ QOXF3zBsBKQxZ8ujxKiDGth6nhtDCap1tbLmbOvZhe0j6H+yQpxolNmi+Vvu62WQNoqf yp7N7kbZU+Pf3T2sr2P/gPDS/M2nY1kDJvdpPRG2Lc7/GXHKyI5jHnAOUiR+0xhME5fS 6FFDNfb3YXhr/TBQDTE8Uk64NZ+OzL4iZYgKcm6MQglk2oSLL8wfY3ZtqCykYhHPK4SF lv3Q==
Date: Fri, 17 May 2013 16:26:18 +0100
X-Spam-Level:
To: bug-Workflow [...] rt.cpan.org
From: Sérgio Alves <kaynehril [...] gmail.com>
X-RT-Interface: Email
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1010
Download (untitled) / with headers
text/plain 1010b
Greetings, I think I might have stumbled on a minor bug inside this module. When fetching the history, the DateTime created does not take into consideration the time zone of the defined workflow ( sub fetch_history ): my @history = (); while ( my $row = $sth->fetchrow_arrayref ) { my $hist = Workflow::History->new( { id => $row->[0], workflow_id => $row->[1], action => $row->[2], description => $row->[3], state => $row->[4], user => $row->[5], * date => $self->parser->parse_datetime( $row->[6] ),* } ); $log->is_debug && $log->debug("Fetched history object '$row->[0]'"); $hist->set_saved(); push @history, $hist; } The little patch I did to myself was to add the following line at the beginning of the sub: $self->parser()->time_zone($wf->time_zone); Best Regards, Sérgio Alves
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1664
MIME-Version: 1.0
In-Reply-To: <CAAism74ZM9MbaPZZyTXALr5sUFvik6aE7O2OZ2+=36zFzhbKqA [...] mail.gmail.com>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <CAAism74ZM9MbaPZZyTXALr5sUFvik6aE7O2OZ2+=36zFzhbKqA [...] mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.13-29543-1373196330-713.85380-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 127
Download (untitled) / with headers
text/plain 127b
Sorry for the delay, I will look into the issue and your proposed patch. Have a nice summer and thanks for reporting, jonasbn
MIME-Version: 1.0
In-Reply-To: <CAAism74ZM9MbaPZZyTXALr5sUFvik6aE7O2OZ2+=36zFzhbKqA [...] mail.gmail.com>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <CAAism74ZM9MbaPZZyTXALr5sUFvik6aE7O2OZ2+=36zFzhbKqA [...] mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.13-12598-1373212387-1886.85380-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 73
The patch is included in release 1.38. Thanks for contributing. jonasbn
MIME-Version: 1.0
In-Reply-To: <CAAism74ZM9MbaPZZyTXALr5sUFvik6aE7O2OZ2+=36zFzhbKqA [...] mail.gmail.com>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <CAAism74ZM9MbaPZZyTXALr5sUFvik6aE7O2OZ2+=36zFzhbKqA [...] mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.13-6673-1373268298-57.85380-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 91
The patch has been applied and is in release 1.38 Thank you for the contribution. jonasbn


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.