Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the Number-Fraction CPAN distribution.

Report information
The Basics
Id: 85333
Status: resolved
Priority: 0/
Queue: Number-Fraction

People
Owner: DAVECROSS [...] cpan.org
Requestors: jjwright [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 2.00
Fixed in: (no value)

Attachments


Subject: Reduce the Moose tax, perhaps use Moo
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.12-9827-1368652417-1869.0-0-0 [...] rt.cpan.org>
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 190
Not using the MOP, but with automatic upgrade to Moose when it's loaded, Moo would be a more lightweight, faster to load option, with very small modifcations to the isa arguments to has.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.12-9827-1368652417-1869.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.12-9827-1368652417-1869.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.12-27787-1368695359-301.85333-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 354
Download (untitled) / with headers
text/plain 354b
On Wed May 15 17:13:37 2013, JWRIGHT wrote: Show quoted text
> Not using the MOP, but with automatic upgrade to Moose when it's loaded, Moo > would be a more lightweight, faster to load option, with very small > modifcations to the isa arguments to has.
Is the "Moose tax" really that much of a problem? I'll do some tests over the weekend and decide what I want to do.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.12-27787-1368695359-301.85333-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
References: <rt-4.0.12-9827-1368652417-1869.0-0-0 [...] rt.cpan.org> <rt-4.0.12-27787-1368695359-301.85333-0-0 [...] rt.cpan.org>
Content-Type: multipart/mixed; boundary="----------=_1368697685-27793-3"
Message-ID: <rt-4.0.12-27793-1368697685-296.85333-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 1308
On Thu May 16 05:09:19 2013, DAVECROSS wrote:
Show quoted text
> Is the "Moose tax" really that much of a problem?

The problem is in scripts that need the speed, even using Number::Fraction once, increases the loading time.

Running prove -Q -l t/ with a patched Number/Fraction.pm (I also included MooX::Types::MooseLike for the Int type):

$ time prove -Q -l t/
All tests successful.
Files=14, Tests=161,  1 wallclock secs ( 0.11 usr  0.11 sys +  0.81 cusr  0.22 csys =  1.25 CPU)
Result: PASS
    0m1.27s real     0m1.00s user     0m0.34s system

and with the original:
$ time prove -Q -l t/                                  
All tests successful.
Files=14, Tests=161,  5 wallclock secs ( 0.06 usr  0.24 sys +  3.69 cusr  0.45 csys =  4.44 CPU)
Result: PASS
    0m4.48s real     0m3.83s user     0m0.70s system



Patch to Fraction.pm attached.
Subject: patch-lib-Number-Fraction_pm
MIME-Version: 1.0
Content-Type: application/octet-stream; name="patch-lib-Number-Fraction_pm"
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline; filename="patch-lib-Number-Fraction_pm"
Content-Transfer-Encoding: base64
Content-Length: 428
Download patch-lib-Number-Fraction_pm
application/octet-stream 428b

Message body not shown because it is not plain text.

MIME-Version: 1.0
In-Reply-To: <rt-4.0.12-9827-1368652417-1869.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.12-9827-1368652417-1869.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-12111-1607270374-5.85333-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 255
Download (untitled) / with headers
text/plain 255b
I'm reviewing all my CPAN RT queues before the service closes down next year. Sorry for taking seven years to resolve this! I suspect that you don't care any more. But version 2.1.0 is en route to CPAN now and uses Moo instead of Moose. Cheers, Dave...


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.