Skip Menu |
 

This queue is for tickets about the Net-Async-WebSocket CPAN distribution.

Report information
The Basics
Id: 85104
Status: open
Priority: 0/
Queue: Net-Async-WebSocket

People
Owner: Nobody in particular
Requestors: topazstorm [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From topazstorm [...] gmail.com Tue May 7 01: 33:18 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.219 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
X-Spam-Flag: NO
Content-Type: multipart/alternative; boundary="047d7bdc8bc6d6f4c104dc1a26af"
Message-ID: <CAKiqXBTfkM2Ea1CdeXZndw=5Tgw3s5ReQA0d7rA9hdud-01CVA [...] mail.gmail.com>
X-Received: by 10.220.253.8 with SMTP id my8mr282775vcb.23.1367904785722; Mon, 06 May 2013 22:33:05 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -6.219
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 9BE7124092F for <cpan-bug+Net-Async-WebSocket [...] hipster.bestpractical.com>; Tue, 7 May 2013 01:33:18 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3OK94xJbHfxW for <cpan-bug+Net-Async-WebSocket [...] hipster.bestpractical.com>; Tue, 7 May 2013 01:33:17 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id B2AAE2408FD for <bug-Net-Async-WebSocket [...] rt.cpan.org>; Tue, 7 May 2013 01:33:16 -0400 (EDT)
Received: (qmail 4878 invoked by alias); 7 May 2013 05:33:15 -0000
Received: from mail-vb0-f53.google.com (HELO mail-vb0-f53.google.com) (209.85.212.53) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 06 May 2013 22:33:09 -0700
Received: by mail-vb0-f53.google.com with SMTP id i3so140947vbh.12 for <bug-Net-Async-WebSocket [...] rt.cpan.org>; Mon, 06 May 2013 22:33:05 -0700 (PDT)
Received: by 10.52.240.140 with HTTP; Mon, 6 May 2013 22:33:05 -0700 (PDT)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Delivered-To: cpan-bug+Net-Async-WebSocket [...] hipster.bestpractical.com
Subject: Missing handler for close frames
Return-Path: <topazstorm [...] gmail.com>
X-RT-Mail-Extension: net-async-websocket
X-Original-To: cpan-bug+Net-Async-WebSocket [...] hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to :content-type; bh=thWsOWpVVFW0hQg00H8XXvU5cVWsDT1azGteNdzLxjk=; b=S6ylSMifAVqt2QVdAwe76wPbnnIRAKR/SFwLKcfWuZDCefhsS+aAJ0IpSlk+yIIvdU ENL+Z6LoPLfjc2ALy+ZNGy/R096dXP5uOMgp1p5EFPUciBiWu4hJbJLGG00Fs7olzW/K Bv3BLi39jkywAd0zIuh7k2F2RV68XTEbkAyVwjNdn6Rg8kjP0HaxukMucIX0xplCLy8Z zGUIpODU0qzdX4oWmlQq/Yar1XDjmL3uJZyupLB2sNkRbhCpsL22147FluvzpiG9eMnL 4NstKV+ER3ho9LSJW2wEg4qYu3V1J3wVD0JNJQLhpoFCSwnLx4iIvNL5SS3J7OTe8yL/ HWrA==
Date: Tue, 7 May 2013 01:33:05 -0400
X-Spam-Level:
To: bug-Net-Async-WebSocket [...] rt.cpan.org
From: Topaz <topazstorm [...] gmail.com>
X-RT-Interface: Email
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: iso-8859-1
Content-Length: 858
Download (untitled) / with headers
text/plain 858b
In Net::Async::WebSocket::Protocol::on_read, it seems like frames which indicate the end of WebSocket session are not handled; in my testing, the connections eventually time out, but I'd like to be able to respond to them immediately. The correct thing to do is probably to fabricate the appropriate response packet indicating that the socket is being shut down. However, in my testing, merely adding this code after the $framebuffer->next loop and before the return was sufficient: $self->close() if $framebuffer->is_close; I leave discerning the correct behavior according to the WebSocket spec to someone more familiar with it. Using: Net-Async-WebSocket-0.06 This is perl 5, version 14, subversion 2 (v5.14.2) built for x86_64-linux-gnu-thread-multi Linux 3.2.0-26-generic #41-Ubuntu SMP Thu Jun 14 17:49:24 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: iso-8859-1
Content-Length: 975
MIME-Version: 1.0
In-Reply-To: <CAKiqXBTfkM2Ea1CdeXZndw=5Tgw3s5ReQA0d7rA9hdud-01CVA [...] mail.gmail.com>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <CAKiqXBTfkM2Ea1CdeXZndw=5Tgw3s5ReQA0d7rA9hdud-01CVA [...] mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-27018-1512782718-268.85104-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 127
Download (untitled) / with headers
text/plain 127b
Version 0.12 adds a ->send_close_frame method and on_close_frame event. Will that be sufficient to solve this? -- Paul Evans
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-27018-1512782718-268.85104-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <CAKiqXBTfkM2Ea1CdeXZndw=5Tgw3s5ReQA0d7rA9hdud-01CVA [...] mail.gmail.com> <rt-4.0.18-27018-1512782718-268.85104-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-1695-1513580520-1382.85104-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 270
Download (untitled) / with headers
text/plain 270b
On Fri Dec 08 20:25:18 2017, PEVANS wrote: Show quoted text
> Version 0.12 adds a ->send_close_frame method and on_close_frame > event. Will that be sufficient to solve this?
Assuming that it triggers immediately upon a close event, and that the socket itself is also closed, probably.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.