Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 84098
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: Paul.Green [...] stratus.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.4003
Fixed in: (no value)



Subject: Update Base.pm in Module-Build to handle an executable extension
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1363806424-15524-7"
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 987
Download (untitled) / with headers
text/plain 987b
This bug report arises from my efforts to qualify Perl 5.14.2 against Stratus OpenVOS Release 17.1 and 17.2. The ACTION_installdeps routine in Base.pm (Version 0.4003) has code to verify that the file that it is about to execute is actually executable. This requires it to know how to convert a command name into a file name. The Stratus VOS / OpenVOS operating system, like Windows, requires that executable files end in the ".pm" suffix (yes, you read that correctly). The attached patch updates this routine to see if an executable suffix is available, and if so, to try using it first. If this fails, it goes ahead and tests without it. I coded it this way for maximum compatibility, but I think it could just as easily have been coded as an if-then-else. I'll leave that decision to you. I have tested this change on OpenVOS Releases 17.1 and 17.2 and it produces the desired behavior. If you have any questions or concerns about this proposeod change, please let me know. Thanks!
Subject: module_build.vos.exe.diff
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; name="module_build.vos.exe.diff"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline; filename="module_build.vos.exe.diff"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: ascii
Content-Length: 563
diff --git a/cpan/Module-Build/lib/Module/Build/Base.pm b/cpan/Module-Build/lib/Module/Build/Base.pm index cf42cc0..3b50597 100644 --- a/cpan/Module-Build/lib/Module/Build/Base.pm +++ b/cpan/Module-Build/lib/Module/Build/Base.pm @@ -3685,6 +3685,14 @@ sub ACTION_installdeps { } } + my $exe = Module::Build::Config->get('exe_ext'); + + if (defined $exe) { + if ( ! -x "$command$exe" ) { + die "cpan_client '$command$exe' is not executable\n"; + } + } + if ( ! -x $command ) { die "cpan_client '$command' is not executable\n"; }
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.13-16320-1369889483-1223.84098-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 256
Download (untitled) / with headers
text/plain 256b
Personally I think we should just get rid of the is-executable check altogether. It's really only there for testing purposes, and if we can't execute the command it will say so (in probably a more informative way) as soon as we try to. Sound reasonable?
MIME-Version: 1.0
In-Reply-To: <rt-4.0.13-16320-1369889483-1223.84098-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.13-16320-1369889483-1223.84098-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.13-13427-1369977311-1381.84098-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 70
I made this change as 7155ee8a48af09dd3cd805b52fc07971be18ba02 in git.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.