Skip Menu |
 

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 83340
Status: rejected
Priority: 0/
Queue: DBIx-Class

People
Owner: Nobody in particular
Requestors: dperrett [...] cambridge.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


From dperrett [...] cambridge.org Fri Feb 15 06: 55:06 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.12 tagged_above=-99.9 required=10 tests=[AWL=-0.000, BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
X-Mailer: Lotus Notes Release 8.5.2FP2 March 23, 2011
X-Spam-Flag: NO
X-Mimetrack: Serialize by Router on cammail2/cambridge(Release 8.5.3FP2|July 02, 2012) at 02/15/2013 11:54:55 AM
Content-Type: multipart/mixed; boundary="=_mixed 0041570880257B13_="
Message-ID: <OF749AB27E.C9614F39-ON80257B13.0040B2A2-80257B13.00415708 [...] cambridge.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -6.12
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id D431F24030F for <cpan-bug+DBIx-Class [...] hipster.bestpractical.com>; Fri, 15 Feb 2013 06:55:06 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HMhqqT9QrPsR for <cpan-bug+DBIx-Class [...] hipster.bestpractical.com>; Fri, 15 Feb 2013 06:55:04 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id A4562240387 for <bug-DBIx-Class [...] rt.cpan.org>; Fri, 15 Feb 2013 06:55:03 -0500 (EST)
Received: (qmail 16599 invoked by uid 103); 15 Feb 2013 11:55:02 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 15 Feb 2013 11:55:02 -0000
Received: from mx-west.cup.cam.ac.uk (HELO mx-west.cup.cam.ac.uk) (128.232.233.1) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Fri, 15 Feb 2013 03:54:59 -0800
Received: from cammail2.cup.cam.ac.uk ([131.111.154.162]) by mx-west.cup.cam.ac.uk (envelope-from <dperrett [...] cambridge.org>) with esmtp (Exim 4.69 #1) id 1U6JsV-0002uh-Lm for <bug-DBIx-Class [...] rt.cpan.org>; Fri, 15 Feb 2013 11:54:55 +0000
X-Keepsent: 749AB27E:C9614F39-80257B13:0040B2A2; type=4; name=$KeepSent
Delivered-To: cpan-bug+DBIx-Class [...] hipster.bestpractical.com
Subject: Test that DBIC Modules Load
Return-Path: <dperrett [...] cambridge.org>
X-RT-Mail-Extension: dbix-class
X-Original-To: cpan-bug+DBIx-Class [...] hipster.bestpractical.com
X-Spam-Check-BY: 16.mx.develooper.com
Date: Fri, 15 Feb 2013 11:54:54 +0000
X-Spam-Level:
To: bug-DBIx-Class [...] rt.cpan.org
From: Daniel Perrett <dperrett [...] cambridge.org>
Content-Length: 0
Content-Type: multipart/alternative; boundary="=_alternative 0041570880257B13_="
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: US-ASCII
Content-Length: 1783
Download (untitled) / with headers
text/plain 1.7k
BACKGROUND I installed DBIx::Class 0.08123 on Strawberry perl 5.12.3 using ppm (OS: XP Pro). The install was successful, but, while trying to run a minimal app (attached), DBIx::Class failed with this message: Can't locate Carp/Clan.pm in @INC (@INC contains: AudioDB/lib C:/strawberry/perl/site/lib C:/strawberry/perl/vendor/lib C:/strawberry/perl/lib .) at C:/strawberry/perl/site/lib/DBIx/Class/Exception.pm line 6. BEGIN failed--compilation aborted at C:/strawberry/perl/site/lib/DBIx/Class/Exception.pm line 6. Compilation failed in require at C:/strawberry/perl/site/lib/DBIx/Class/Schema.pm line 6. BEGIN failed--compilation aborted at C:/strawberry/perl/site/lib/DBIx/Class/Schema.pm line 6. Compilation failed in require at (eval 2) line 2. ...propagated at C:/strawberry/perl/lib/base.pm line 94. BEGIN failed--compilation aborted at AudioDB/lib/AudioDB/Schema.pm line 4. Compilation failed in require at adb-test.pl line 5. BEGIN failed--compilation aborted at adb-test.pl line 5. DBIx/Class/Exception.pm does indeed call Carp::Clan on line 6. I'm sure I can fix it by installing Carp::Clan, but I presume it ought to have gone in the DBIx::Class dependencies, as it's not a core module. DBIx::Class has now switched to a home-grown solution. I'm now upgrading using CPAN instead of ppm and have filed a bug with Strawberry separately to get a better DBIx::Class version. ACTION REQUESTED However, oddly, I also couldn't find any tests that guaranteed all the classes could be loaded ok, but the test suite is pretty big, so possibly I missed them. Nevertheless, clearly 0.8123 passed on a lot of machines, and where it failed, didn't necessarily say anything about Carp::Clan. Should such a test be included, if it is not already? Daniel
content-type: text/html; charset="utf-8"
X-RT-Original-Encoding: US-ASCII
Content-Length: 2640
content-type: application/zip; name="DBIx-Class-Requires-Carp-Clan.zip"
content-disposition: attachment; filename="DBIx-Class-Requires-Carp-Clan.zip"
Content-Transfer-Encoding: base64
Content-Length: 2243

Message body not shown because it is not plain text.

From rabbit [...] rabbit.us Fri Feb 15 07: 14:50 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.9 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-11145-1360929309-1640.83340-4-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
References: <RT-Ticket-83340 [...] rt.cpan.org> <OF749AB27E.C9614F39-ON80257B13.0040B2A2-80257B13.00415708 [...] cambridge.org> <rt-3.8.HEAD-11145-1360929309-1640.83340-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20130215121419.GA23404 [...] rabbit.us>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.9
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id C342524039F for <cpan-bug+DBIx-Class [...] hipster.bestpractical.com>; Fri, 15 Feb 2013 07:14:50 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M7UVlw+rnskT for <cpan-bug+DBIx-Class [...] hipster.bestpractical.com>; Fri, 15 Feb 2013 07:14:44 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 0F36524030F for <bug-DBIx-Class [...] rt.cpan.org>; Fri, 15 Feb 2013 07:14:43 -0500 (EST)
Received: (qmail 18372 invoked by uid 103); 15 Feb 2013 12:14:42 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 15 Feb 2013 12:14:42 -0000
Received: from mujunyku.leporine.io (HELO mujunyku.leporine.io) (113.212.96.195) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Fri, 15 Feb 2013 04:14:29 -0800
Received: by mujunyku.leporine.io (Postfix, from userid 1000) id 8FA8522815E; Fri, 15 Feb 2013 23:14:19 +1100 (EST)
Delivered-To: cpan-bug+DBIx-Class [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #83340] Test that DBIC Modules Load
User-Agent: Mutt/1.5.20 (2009-06-14)
Return-Path: <rabbit [...] rabbit.us>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+DBIx-Class [...] hipster.bestpractical.com
X-RT-Mail-Extension: dbix-class
Date: Fri, 15 Feb 2013 23:14:19 +1100
X-Spam-Level:
To: Daniel Perrett via RT <bug-DBIx-Class [...] rt.cpan.org>
From: Peter Rabbitson <ribasushi [...] cpan.org>
RT-Message-ID: <rt-3.8.HEAD-3979-1360930491-1674.83340-0-0 [...] rt.cpan.org>
Content-Length: 1806
Download (untitled) / with headers
text/plain 1.7k
On Fri, Feb 15, 2013 at 06:55:12AM -0500, Daniel Perrett via RT wrote: Show quoted text
> Fri Feb 15 06:55:08 2013: Request 83340 was acted upon. > Transaction: Ticket created by dperrett@cambridge.org > Queue: DBIx-Class > Subject: Test that DBIC Modules Load > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: dperrett@cambridge.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=83340 > > > > BACKGROUND > > I installed DBIx::Class 0.08123 on Strawberry perl 5.12.3 using ppm (OS: > XP Pro). The install was successful, but, while trying to run a minimal > app (attached), DBIx::Class failed with this message: > > Can't locate Carp/Clan.pm in @INC (@INC contains: AudioDB/lib > ... > > > However, oddly, I also couldn't find any tests that guaranteed all the > classes could be loaded ok, but the test suite is pretty big, so possibly > I missed them. Nevertheless, clearly 0.8123 passed on a lot of machines, > and where it failed, didn't necessarily say anything about Carp::Clan. > > Should such a test be included, if it is not already? >
Not really. DBIx::Class 0.08123 clearly indicates it requires Carp::Clan [1]. Having tests that verify that the necessary modules were indeed loaded is rather superfluous, because the impact of a broken toolchain is immediately apparent (as you saw). All in all whoever built the ppm screwed up royally, and it was not immediately apparent to you because ppm installs do not execute any tests. This is why it is always preferred to use the CPAN toolchain (cpan/cpanm/cpanp) as opposed to ppm. I will wait for you to confirm the above fully answers your question before closing this ticket. Cheers [1] https://metacpan.org/source/FREW/DBIx-Class-0.08123/META.yml#L34
From dperrett [...] cambridge.org Fri Feb 15 07: 28:55 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.12 tagged_above=-99.9 required=10 tests=[AWL=-0.000, BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-3979-1360930493-1546.83340-6-0 [...] rt.cpan.org>
X-Mailer: Lotus Notes Release 8.5.2FP2 March 23, 2011
X-Spam-Flag: NO
X-Mimetrack: Serialize by Router on cammail2/cambridge(Release 8.5.3FP2|July 02, 2012) at 02/15/2013 12:28:34 PM, Serialize complete at 02/15/2013 12:28:34 PM
References: <RT-Ticket-83340 [...] rt.cpan.org> <OF749AB27E.C9614F39-ON80257B13.0040B2A2-80257B13.00415708 [...] cambridge.org> <rt-3.8.HEAD-11145-1360929309-1640.83340-4-0 [...] rt.cpan.org> <20130215121419.GA23404 [...] rabbit.us> <rt-3.8.HEAD-3979-1360930493-1546.83340-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <OFBEE8DFC5.D762DFDA-ON80257B13.0043852D-80257B13.00446C4F [...] cambridge.org>
Content-Type: multipart/alternative; boundary="=_alternative 00446C4F80257B13_="
X-Spam-Score: -6.12
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 9F389240387 for <cpan-bug+DBIx-Class [...] hipster.bestpractical.com>; Fri, 15 Feb 2013 07:28:55 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id frWy26JRTlv8 for <cpan-bug+DBIx-Class [...] hipster.bestpractical.com>; Fri, 15 Feb 2013 07:28:44 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 68D9924030F for <bug-DBIx-Class [...] rt.cpan.org>; Fri, 15 Feb 2013 07:28:44 -0500 (EST)
Received: (qmail 19212 invoked by uid 103); 15 Feb 2013 12:28:43 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 15 Feb 2013 12:28:43 -0000
Received: from mx-west.cup.cam.ac.uk (HELO mx-west.cup.cam.ac.uk) (128.232.233.1) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Fri, 15 Feb 2013 04:28:38 -0800
Received: from cammail2.cup.cam.ac.uk ([131.111.154.162]) by mx-west.cup.cam.ac.uk (envelope-from <dperrett [...] cambridge.org>) with esmtp (Exim 4.69 #1) id 1U6KP5-0004Z0-BN for <bug-DBIx-Class [...] rt.cpan.org>; Fri, 15 Feb 2013 12:28:35 +0000
X-Keepsent: BEE8DFC5:D762DFDA-80257B13:0043852D; type=4; name=$KeepSent
Delivered-To: cpan-bug+DBIx-Class [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #83340] Test that DBIC Modules Load
Return-Path: <dperrett [...] cambridge.org>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+DBIx-Class [...] hipster.bestpractical.com
X-RT-Mail-Extension: dbix-class
Date: Fri, 15 Feb 2013 12:28:32 +0000
X-Spam-Level:
To: bug-DBIx-Class [...] rt.cpan.org
From: Daniel Perrett <dperrett [...] cambridge.org>
RT-Message-ID: <rt-3.8.HEAD-16387-1360931336-305.83340-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 2481
Download (untitled) / with headers
text/plain 2.4k
Thanks for the advice that best practice is to use cpan in the first instance instead of ppm: I'll do that in future. "Having tests that verify that the necessary modules were indeed loaded is rather superfluous" I agree loading the dependencies is redundant. I meant something like use_ok('DBIx::Class::Exception'), as distinct from duck-testing (if you know what I mean) the functionality of the module. Daniel From: "Peter Rabbitson via RT" <bug-DBIx-Class@rt.cpan.org> To: dperrett@cambridge.org Date: 15/02/2013 12:15 Subject: Re: [rt.cpan.org #83340] Test that DBIC Modules Load <URL: https://rt.cpan.org/Ticket/Display.html?id=83340 > On Fri, Feb 15, 2013 at 06:55:12AM -0500, Daniel Perrett via RT wrote: Show quoted text
> Fri Feb 15 06:55:08 2013: Request 83340 was acted upon. > Transaction: Ticket created by dperrett@cambridge.org > Queue: DBIx-Class > Subject: Test that DBIC Modules Load > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: dperrett@cambridge.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=83340 > > > > BACKGROUND > > I installed DBIx::Class 0.08123 on Strawberry perl 5.12.3 using ppm (OS:
Show quoted text
> XP Pro). The install was successful, but, while trying to run a minimal > app (attached), DBIx::Class failed with this message: > > Can't locate Carp/Clan.pm in @INC (@INC contains: AudioDB/lib > ... > > > However, oddly, I also couldn't find any tests that guaranteed all the > classes could be loaded ok, but the test suite is pretty big, so
possibly Show quoted text
> I missed them. Nevertheless, clearly 0.8123 passed on a lot of machines,
Show quoted text
> and where it failed, didn't necessarily say anything about Carp::Clan. > > Should such a test be included, if it is not already? >
Not really. DBIx::Class 0.08123 clearly indicates it requires Carp::Clan [1]. Having tests that verify that the necessary modules were indeed loaded is rather superfluous, because the impact of a broken toolchain is immediately apparent (as you saw). All in all whoever built the ppm screwed up royally, and it was not immediately apparent to you because ppm installs do not execute any tests. This is why it is always preferred to use the CPAN toolchain (cpan/cpanm/cpanp) as opposed to ppm. I will wait for you to confirm the above fully answers your question before closing this ticket. Cheers [1] https://metacpan.org/source/FREW/DBIx-Class-0.08123/META.yml#L34
Content-Type: text/html; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 3967
From rabbit [...] rabbit.us Fri Feb 15 08: 01:48 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.9 tagged_above=-99.9 required=10 tests=[AWL=0.000, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-16387-1360931337-573.83340-5-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
References: <RT-Ticket-83340 [...] rt.cpan.org> <OF749AB27E.C9614F39-ON80257B13.0040B2A2-80257B13.00415708 [...] cambridge.org> <rt-3.8.HEAD-11145-1360929309-1640.83340-4-0 [...] rt.cpan.org> <20130215121419.GA23404 [...] rabbit.us> <rt-3.8.HEAD-3979-1360930493-1546.83340-6-0 [...] rt.cpan.org> <OFBEE8DFC5.D762DFDA-ON80257B13.0043852D-80257B13.00446C4F [...] cambridge.org> <rt-3.8.HEAD-16387-1360931337-573.83340-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20130215130137.GB23663 [...] rabbit.us>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.9
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 330B224064C for <cpan-bug+DBIx-Class [...] hipster.bestpractical.com>; Fri, 15 Feb 2013 08:01:48 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hx2EOfdQYHRG for <cpan-bug+DBIx-Class [...] hipster.bestpractical.com>; Fri, 15 Feb 2013 08:01:45 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id D870824039F for <bug-DBIx-Class [...] rt.cpan.org>; Fri, 15 Feb 2013 08:01:44 -0500 (EST)
Received: (qmail 21397 invoked by uid 103); 15 Feb 2013 13:01:44 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 15 Feb 2013 13:01:44 -0000
Received: from mujunyku.leporine.io (HELO mujunyku.leporine.io) (113.212.96.195) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Fri, 15 Feb 2013 05:01:40 -0800
Received: by mujunyku.leporine.io (Postfix, from userid 1000) id 2E9D3228160; Sat, 16 Feb 2013 00:01:37 +1100 (EST)
Delivered-To: cpan-bug+DBIx-Class [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #83340] Test that DBIC Modules Load
User-Agent: Mutt/1.5.20 (2009-06-14)
Return-Path: <rabbit [...] rabbit.us>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+DBIx-Class [...] hipster.bestpractical.com
X-RT-Mail-Extension: dbix-class
Date: Sat, 16 Feb 2013 00:01:37 +1100
X-Spam-Level:
To: Daniel Perrett via RT <bug-DBIx-Class [...] rt.cpan.org>
From: Peter Rabbitson <ribasushi [...] cpan.org>
RT-Message-ID: <rt-3.8.HEAD-11145-1360933309-1060.83340-0-0 [...] rt.cpan.org>
Content-Length: 1137
Download (untitled) / with headers
text/plain 1.1k
On Fri, Feb 15, 2013 at 07:29:02AM -0500, Daniel Perrett via RT wrote: Show quoted text
> Queue: DBIx-Class > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=83340 > > > Thanks for the advice that best practice is to use cpan in the first > instance instead of ppm: I'll do that in future. > > "Having tests that verify that the necessary modules were indeed loaded is > rather superfluous" > I agree loading the dependencies is redundant. I meant something like > use_ok('DBIx::Class::Exception'), as distinct from duck-testing (if you > know what I mean) the functionality of the module.
Given that many critical parts of the distribution (e.g. DBIx::Class::Schema) use() DBIx::Class::Exception - a use_ok is just as redundant - 95% of your tests will fail anyway. One could argue that tests are cheap, and a use_ok wouldn't hurt, however as a counter-argument I shall present this: http://code.activestate.com/ppm/DBIx-Class/ The unavailability of latest DBIC on many of the platforms is because our test suite does not complete in under 5 minutes. Not because DBIC is horrifically slow, but because we have a lot of tests ;)
From dperrett [...] cambridge.org Fri Feb 15 08: 07:22 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.12 tagged_above=-99.9 required=10 tests=[AWL=-0.000, BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-11145-1360933311-1275.83340-6-0 [...] rt.cpan.org>
X-Mailer: Lotus Notes Release 8.5.2FP2 March 23, 2011
X-Spam-Flag: NO
X-Mimetrack: Serialize by Router on cammail2/cambridge(Release 8.5.3FP2|July 02, 2012) at 02/15/2013 01:07:02 PM, Serialize complete at 02/15/2013 01:07:02 PM
References: <RT-Ticket-83340 [...] rt.cpan.org> <OF749AB27E.C9614F39-ON80257B13.0040B2A2-80257B13.00415708 [...] cambridge.org> <rt-3.8.HEAD-11145-1360929309-1640.83340-4-0 [...] rt.cpan.org> <20130215121419.GA23404 [...] rabbit.us> <rt-3.8.HEAD-3979-1360930493-1546.83340-6-0 [...] rt.cpan.org> <OFBEE8DFC5.D762DFDA-ON80257B13.0043852D-80257B13.00446C4F [...] cambridge.org> <rt-3.8.HEAD-16387-1360931337-573.83340-5-0 [...] rt.cpan.org> <20130215130137.GB23663 [...] rabbit.us> <rt-3.8.HEAD-11145-1360933311-1275.83340-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <OFC278467C.E09565C0-ON80257B13.0047F1DB-80257B13.0047F180 [...] cambridge.org>
Content-Type: multipart/alternative; boundary="=_alternative 0047F18080257B13_="
X-Spam-Score: -6.12
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 3B2CB24064C for <cpan-bug+DBIx-Class [...] hipster.bestpractical.com>; Fri, 15 Feb 2013 08:07:22 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OmhToeP39-fc for <cpan-bug+DBIx-Class [...] hipster.bestpractical.com>; Fri, 15 Feb 2013 08:07:16 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id B708924039F for <bug-DBIx-Class [...] rt.cpan.org>; Fri, 15 Feb 2013 08:07:15 -0500 (EST)
Received: (qmail 21901 invoked by uid 103); 15 Feb 2013 13:07:15 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 15 Feb 2013 13:07:15 -0000
Received: from mx-east.cup.cam.ac.uk (HELO mx-east.cup.cam.ac.uk) (128.232.233.2) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Fri, 15 Feb 2013 05:07:06 -0800
Received: from cammail2.cup.cam.ac.uk ([131.111.154.162]) by mx-east.cup.cam.ac.uk (envelope-from <dperrett [...] cambridge.org>) with esmtp (Exim 4.69 #9) id 1U6L0I-0002Lv-Gb for <bug-DBIx-Class [...] rt.cpan.org>; Fri, 15 Feb 2013 13:07:02 +0000
X-Keepsent: C278467C:E09565C0-80257B13:0047F1DB; type=4; name=$KeepSent
Delivered-To: cpan-bug+DBIx-Class [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #83340] Test that DBIC Modules Load
Return-Path: <dperrett [...] cambridge.org>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+DBIx-Class [...] hipster.bestpractical.com
X-RT-Mail-Extension: dbix-class
Date: Fri, 15 Feb 2013 13:06:59 +0000
X-Spam-Level:
To: bug-DBIx-Class [...] rt.cpan.org
From: Daniel Perrett <dperrett [...] cambridge.org>
RT-Message-ID: <rt-3.8.HEAD-17716-1360933643-182.83340-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 1501
Download (untitled) / with headers
text/plain 1.4k
Ah, ok - no problem, then. I was just really checking if use_ok()s were missed off unintentionally! Daniel From: "Peter Rabbitson via RT" <bug-DBIx-Class@rt.cpan.org> To: dperrett@cambridge.org Date: 15/02/2013 13:02 Subject: Re: [rt.cpan.org #83340] Test that DBIC Modules Load <URL: https://rt.cpan.org/Ticket/Display.html?id=83340 > On Fri, Feb 15, 2013 at 07:29:02AM -0500, Daniel Perrett via RT wrote: Show quoted text
> Queue: DBIx-Class > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=83340 > > > Thanks for the advice that best practice is to use cpan in the first > instance instead of ppm: I'll do that in future. > > "Having tests that verify that the necessary modules were indeed loaded
is Show quoted text
> rather superfluous" > I agree loading the dependencies is redundant. I meant something like > use_ok('DBIx::Class::Exception'), as distinct from duck-testing (if you > know what I mean) the functionality of the module.
Given that many critical parts of the distribution (e.g. DBIx::Class::Schema) use() DBIx::Class::Exception - a use_ok is just as redundant - 95% of your tests will fail anyway. One could argue that tests are cheap, and a use_ok wouldn't hurt, however as a counter-argument I shall present this: http://code.activestate.com/ppm/DBIx-Class/ The unavailability of latest DBIC on many of the platforms is because our test suite does not complete in under 5 minutes. Not because DBIC is horrifically slow, but because we have a lot of tests ;)
Content-Type: text/html; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 2683
MIME-Version: 1.0
In-Reply-To: <OF749AB27E.C9614F39-ON80257B13.0040B2A2-80257B13.00415708 [...] cambridge.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <OF749AB27E.C9614F39-ON80257B13.0040B2A2-80257B13.00415708 [...] cambridge.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-17716-1360949136-1685.83340-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 57
Rejecting ticket - side effect of a faulty (ancient) ppm.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.