Skip Menu |
 

This queue is for tickets about the forks CPAN distribution.

Report information
The Basics
Id: 82781
Status: resolved
Priority: 0/
Queue: forks

People
Owner: RYBSKEJ [...] cpan.org
Requestors: CHORNY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.34
Fixed in: 0.35



Subject: questions in Makefile.PL
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 312
Download (untitled) / with headers
text/plain 312b
Questions in Makefile.PL prevent cpantesters smoker from functioning correctly: they cannot test this module and smoker hangs. Please use prompt from ExtUtils::MakeMaker. Also, environment variables PERL_MM_USE_DEFAULT or AUTOMATED_TESTING can be used to skip questions. -- Alexandr Ciornii, http://chorny.net
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-19959-1386606713-944.82781-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 904
Download (untitled) / with headers
text/plain 904b
On 2013-01-17 02:53:10, CHORNY wrote: Show quoted text
> Questions in Makefile.PL prevent cpantesters smoker from functioning > correctly: they cannot test this module and smoker hangs. Please use > prompt from ExtUtils::MakeMaker. Also, environment variables > PERL_MM_USE_DEFAULT or AUTOMATED_TESTING can be used to skip questions.
It seems that Makefile.PL tries to emulate a subset of prompt() functionality (unfortunately this subset does not include default answers if PERL_MM_USE_DEFAULT is set) to keep compatibility with very old installations. I think this can be easily fixed by using something like: if (!defined &prompt) { *prompt = sub { # the compatibility code comes here }; } if (prompt("text", "y") eq "y") { # ... } This would work both with very old perl installations and with batch installation or automatic test systems. Regards, Slaven
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-19959-1386606713-944.82781-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-19959-1386606713-944.82781-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-13421-1403678560-1429.82781-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1043
On Mon Dec 09 11:31:53 2013, SREZIC wrote: Show quoted text
> On 2013-01-17 02:53:10, CHORNY wrote:
> > Questions in Makefile.PL prevent cpantesters smoker from functioning > > correctly: they cannot test this module and smoker hangs. Please use > > prompt from ExtUtils::MakeMaker. Also, environment variables > > PERL_MM_USE_DEFAULT or AUTOMATED_TESTING can be used to skip > > questions.
> > It seems that Makefile.PL tries to emulate a subset of prompt() > functionality (unfortunately this subset does not include default > answers if PERL_MM_USE_DEFAULT is set) to keep compatibility with very > old installations. I think this can be easily fixed by using something > like: > > if (!defined &prompt) { > *prompt = sub { > # the compatibility code comes here > }; > } > if (prompt("text", "y") eq "y") { > # ... > } > > This would work both with very old perl installations and with batch > installation or automatic test systems. > > Regards, > Slaven
Thanks for the suggestion, I'll plan to integrate it for next release.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-13421-1403678560-1429.82781-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-19959-1386606713-944.82781-0-0 [...] rt.cpan.org> <rt-4.0.18-13421-1403678560-1429.82781-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-22860-1403749231-1188.82781-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1171
Download (untitled) / with headers
text/plain 1.1k
On Wed Jun 25 02:42:40 2014, RYBSKEJ wrote: Show quoted text
> On Mon Dec 09 11:31:53 2013, SREZIC wrote:
> > On 2013-01-17 02:53:10, CHORNY wrote:
> > > Questions in Makefile.PL prevent cpantesters smoker from functioning > > > correctly: they cannot test this module and smoker hangs. Please use > > > prompt from ExtUtils::MakeMaker. Also, environment variables > > > PERL_MM_USE_DEFAULT or AUTOMATED_TESTING can be used to skip > > > questions.
> > > > It seems that Makefile.PL tries to emulate a subset of prompt() > > functionality (unfortunately this subset does not include default > > answers if PERL_MM_USE_DEFAULT is set) to keep compatibility with very > > old installations. I think this can be easily fixed by using something > > like: > > > > if (!defined &prompt) { > > *prompt = sub { > > # the compatibility code comes here > > }; > > } > > if (prompt("text", "y") eq "y") { > > # ... > > } > > > > This would work both with very old perl installations and with batch > > installation or automatic test systems. > > > > Regards, > > Slaven
> > Thanks for the suggestion, I'll plan to integrate it for next release.
Fixed in 0.35 release.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.