Skip Menu |
 

This queue is for tickets about the Sys-Syslog CPAN distribution.

Report information
The Basics
Id: 82531
Status: resolved
Priority: 0/
Queue: Sys-Syslog

People
Owner: Nobody in particular
Requestors: alexander.berger [...] finnova.ch
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in:
  • 0.29
  • 0.30
  • 0.31
  • 0.32
Fixed in: 0.33



Subject: Invalid usage of function POSIX::_exit
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 523
Download (untitled) / with headers
text/plain 523b
The fix for CPAN-RT#55215(Sys::Syslog might call exit which triggers DESTROY) introduced in version 0.29 contains an invalid use of function POSIX::_exit on line 501. The function POSIX::_exit must be called with an exit status code as its sole argument. It cannot be called without any arguments. If it is called without status code like in version 0.29 (up to version 0.32) it will raise an error. Therefore that line has to be changed from "POSIX::_exit if defined $pid;" to "POSIX::_exit(0) if defined $pid;"
From saper [...] cpan.org Mon Jan 7 14: 10:32 2013
MIME-Version: 1.0 (Apple Message framework v1283)
X-Spam-Status: No, score=-6.9 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-24407-1357542247-414.82531-4-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.1283)
X-Spam-Flag: NO
References: <RT-Ticket-82531 [...] rt.cpan.org> <rt-3.8.HEAD-24407-1357542247-414.82531-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Content-Type: text/plain; charset="utf-8"
Message-ID: <A55CC836-D0E3-4AEA-903A-551F1542475A [...] cpan.org>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.9
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id A18322403DD for <cpan-bug+Sys-Syslog [...] hipster.bestpractical.com>; Mon, 7 Jan 2013 14:10:32 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xkc831VmiWw8 for <cpan-bug+Sys-Syslog [...] hipster.bestpractical.com>; Mon, 7 Jan 2013 14:10:30 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 190F124037A for <bug-Sys-Syslog [...] rt.cpan.org>; Mon, 7 Jan 2013 14:10:29 -0500 (EST)
Received: (qmail 13542 invoked by uid 103); 7 Jan 2013 19:10:29 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 7 Jan 2013 19:10:29 -0000
Received: from smtp3-g21.free.fr (HELO smtp3-g21.free.fr) (212.27.42.3) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Mon, 07 Jan 2013 11:10:26 -0800
Received: from [78.251.228.137] (unknown [78.251.228.137]) (Authenticated sender: maddingue) by smtp3-g21.free.fr (Postfix) with ESMTPSA id 07D40A62F2 for <bug-Sys-Syslog [...] rt.cpan.org>; Mon, 7 Jan 2013 20:10:17 +0100 (CET)
Delivered-To: cpan-bug+Sys-Syslog [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #82531] Invalid usage of function POSIX::_exit
Return-Path: <saper [...] cpan.org>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Sys-Syslog [...] hipster.bestpractical.com
X-RT-Mail-Extension: sys-syslog
Date: Mon, 7 Jan 2013 20:10:18 +0100
X-Spam-Level:
To: bug-Sys-Syslog [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Sébastien Aperghis-Tramoni <saper [...] cpan.org>
RT-Message-ID: <rt-3.8.HEAD-19457-1357585833-1951.82531-0-0 [...] rt.cpan.org>
Content-Length: 683
Download (untitled) / with headers
text/plain 683b
Alexander Berger wrote via RT: Show quoted text
> The fix for CPAN-RT#55215(Sys::Syslog might call exit which triggers DESTROY) > introduced in version 0.29 contains an invalid use of function POSIX::_exit on > line 501. > > The function POSIX::_exit must be called with an exit status code as its sole > argument. It cannot be called without any arguments. If it is called without > status code like in version 0.29 (up to version 0.32) it will raise an error. > Therefore that line has to be changed from > > "POSIX::_exit if defined $pid;" > > to > > "POSIX::_exit(0) if defined $pid;"
Well spotted. Thanks, applied. -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-19457-1357585833-1951.82531-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <RT-Ticket-82531 [...] rt.cpan.org> <rt-3.8.HEAD-24407-1357542247-414.82531-4-0 [...] rt.cpan.org> <A55CC836-D0E3-4AEA-903A-551F1542475A [...] cpan.org> <rt-3.8.HEAD-19457-1357585833-1951.82531-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-26293-1357624826-201.82531-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
From: alexander.berger [...] finnova.ch
X-RT-Original-Encoding: utf-8
Content-Length: 190
Download (untitled) / with headers
text/plain 190b
I am sorry but now you introduced an error in line 522. You changed it to: POSIX::_exit(0) $ret if defined $pid; but you probably meant: POSIX::_exit($ret) if defined $pid; regards, Alex
From saper [...] cpan.org Tue Jan 8 02: 14:14 2013
MIME-Version: 1.0 (Apple Message framework v1283)
X-Spam-Status: No, score=-6.9 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-26293-1357624827-1824.82531-5-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.1283)
X-Spam-Flag: NO
References: <RT-Ticket-82531 [...] rt.cpan.org> <rt-3.8.HEAD-24407-1357542247-414.82531-4-0 [...] rt.cpan.org> <A55CC836-D0E3-4AEA-903A-551F1542475A [...] cpan.org> <rt-3.8.HEAD-19457-1357585833-1951.82531-5-0 [...] rt.cpan.org> <rt-3.8.HEAD-26293-1357624827-1824.82531-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Content-Type: text/plain; charset="utf-8"
Message-ID: <48DF01F5-9857-408F-9A06-C734D1203C23 [...] cpan.org>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.9
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 0FC68240B7C for <cpan-bug+Sys-Syslog [...] hipster.bestpractical.com>; Tue, 8 Jan 2013 02:14:14 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZxmVSVJkTPb7 for <cpan-bug+Sys-Syslog [...] hipster.bestpractical.com>; Tue, 8 Jan 2013 02:14:12 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 7F742240B7B for <bug-Sys-Syslog [...] rt.cpan.org>; Tue, 8 Jan 2013 02:14:12 -0500 (EST)
Received: (qmail 26473 invoked by uid 103); 8 Jan 2013 07:14:11 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 8 Jan 2013 07:14:11 -0000
Received: from smtp3-g21.free.fr (HELO smtp3-g21.free.fr) (212.27.42.3) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Mon, 07 Jan 2013 23:14:08 -0800
Received: from [78.251.232.135] (unknown [78.251.232.135]) (Authenticated sender: maddingue) by smtp3-g21.free.fr (Postfix) with ESMTPSA id 6AC11A6295 for <bug-Sys-Syslog [...] rt.cpan.org>; Tue, 8 Jan 2013 08:13:59 +0100 (CET)
Delivered-To: cpan-bug+Sys-Syslog [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #82531] Invalid usage of function POSIX::_exit
Return-Path: <saper [...] cpan.org>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Sys-Syslog [...] hipster.bestpractical.com
X-RT-Mail-Extension: sys-syslog
Date: Tue, 8 Jan 2013 08:13:58 +0100
X-Spam-Level:
To: bug-Sys-Syslog [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Sébastien Aperghis-Tramoni <saper [...] cpan.org>
RT-Message-ID: <rt-3.8.HEAD-31243-1357629254-120.82531-0-0 [...] rt.cpan.org>
Content-Length: 315
Download (untitled) / with headers
text/plain 315b
Alexander Berger wrote via RT: Show quoted text
> I am sorry but now you introduced an error in line 522. You changed it to: > > POSIX::_exit(0) $ret if defined $pid; > > but you probably meant: > > POSIX::_exit($ret) if defined $pid;
Ah right. Fixed. Thanks. -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.