Skip Menu |
 

This queue is for tickets about the Org-Parser CPAN distribution.

Report information
The Basics
Id: 82334
Status: rejected
Priority: 0/
Queue: Org-Parser

People
Owner: Nobody in particular
Requestors: bernt.budde [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From bernt.budde [...] gmail.com Sun Dec 30 01: 25:09 2012
MIME-Version: 1.0
X-Spam-Status: No, score=-6.22 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
X-Spam-Flag: NO
content-type: text/plain; charset="utf-8"
Message-ID: <CAPd3O+TM7ypC1dLkw619TvS+d_8_u7JG++ev_NySRxfU1Df=+w [...] mail.gmail.com>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -6.22
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 1AA01240BC4 for <cpan-bug+Org-Parser [...] hipster.bestpractical.com>; Sun, 30 Dec 2012 01:25:09 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YZs0JFeyUU55 for <cpan-bug+Org-Parser [...] hipster.bestpractical.com>; Sun, 30 Dec 2012 01:25:07 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id E3CC3240B63 for <bug-Org-Parser [...] rt.cpan.org>; Sun, 30 Dec 2012 01:25:06 -0500 (EST)
Received: (qmail 13476 invoked by uid 103); 30 Dec 2012 06:25:05 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 30 Dec 2012 06:25:05 -0000
Received: from mail-wi0-f172.google.com (HELO mail-wi0-f172.google.com) (209.85.212.172) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Sat, 29 Dec 2012 22:25:02 -0800
Received: by mail-wi0-f172.google.com with SMTP id o1so8862501wic.5 for <bug-Org-Parser [...] rt.cpan.org>; Sat, 29 Dec 2012 22:24:58 -0800 (PST)
Received: by 10.180.87.228 with SMTP id bb4mr40429755wib.31.1356848698453; Sat, 29 Dec 2012 22:24:58 -0800 (PST)
Received: by 10.194.243.41 with HTTP; Sat, 29 Dec 2012 22:24:58 -0800 (PST)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Delivered-To: cpan-bug+Org-Parser [...] hipster.bestpractical.com
Subject: Org::Element::Link bug in Org-Parser-0.27
Return-Path: <bernt.budde [...] gmail.com>
X-RT-Mail-Extension: org-parser
X-Original-To: cpan-bug+Org-Parser [...] hipster.bestpractical.com
X-Spam-Check-BY: 16.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=IGFlMrlpyO62ycIeSYYtBQat2zvol7ueTsFLMYnbPls=; b=d1u8RiFOCkxAR1duMGCkaiC+vnsS3gxTG7d/EQmv/YZpREY1p+xgyxclN52tzuTWtf rQ0IWnfeMX3Dc6KwUHVMs0D7j7G49TspQ6EVATFt3rrtvgXKTDTaTXilpGLuklKMsay9 sxcbY1+e9W2GL7CMONi4kZHaRxmF47GYYOUxnNob92A031HrpL1Fa7JM1b7gF33Y2lbG 8hjnSBv8WFX4UjsJcxk/HxZpAXOWnLrER6vdzicD9ArFEWG40L2TmHk3N93G4E6D29cy 7bSoK8koSiGSoKWawivGLKjsTt3sOzqhHFsBE/PTa3fVPrOFjeTjeRQWNHNIVl47v0oU FJjQ==
Date: Sun, 30 Dec 2012 08:24:58 +0200
X-Spam-Level:
To: bug-Org-Parser [...] rt.cpan.org
From: Bernt Budde <bernt.budde [...] gmail.com>
X-RT-Original-Encoding: ISO-8859-1
Content-Length: 1592
Download (untitled) / with headers
text/plain 1.5k
Hi, Thanks for a cool module! There is a small problem in the as_string() code in Org/Element/Link.pm You haven't seen this because as_string() works when called for a whole tree of Org::Element::Headline objects, since O::E::Headline has the '_str' short cut. So as_string() won't be called for any Link.pm in title or body. Present code: sub as_string { my ($self) = @_; return $self->_str if defined $self->_str; join("", "[", "[", $self->link, "]", (defined($self->description) && length($self->description) ? ("[", $self->description, "]") : ()), "]"); } # The problem is that description is an Org::Element::Text. # Change to: ... (defined($self->description) && length($self->description) ? ("[", $self->description->as_string, "]") : ()), ... /Bernt Budde PS Sorry, almost morning here. Too tired to write a test for you. :-( :-) DS PPS The module/version is Org-Parser-0.27 $ uname -a Linux bughem 3.5.0-21-generic #32-Ubuntu SMP Tue Dec 11 18:51:59 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux $ perl -v This is perl 5, version 16, subversion 2 (v5.16.2) built for x86_64-linux Copyright 1987-2012, Larry Wall Perl may be copied only under the terms of either the Artistic License or the GNU General Public License, which may be found in the Perl 5 source kit. Complete documentation for Perl, including FAQ lists, should be found on this system using "man perl" or "perldoc perl". If you have access to the Internet, point your browser at http://www.perl.org/, the Perl Home Page. DS
MIME-Version: 1.0
In-Reply-To: <CAPd3O+TM7ypC1dLkw619TvS+d_8_u7JG++ev_NySRxfU1Df=+w [...] mail.gmail.com>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <CAPd3O+TM7ypC1dLkw619TvS+d_8_u7JG++ev_NySRxfU1Df=+w [...] mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-19458-1357573024-476.82334-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 1860
Download (untitled) / with headers
text/plain 1.8k
Hi Bernt, Thanks for the report. Fixed and released 0.28. Regards, Steven On Sun Dec 30 01:25:10 2012, bernt.budde@gmail.com wrote: Show quoted text
> Hi, > > Thanks for a cool module! > > There is a small problem in the as_string() code in > Org/Element/Link.pm > > You haven't seen this because as_string() works when called for a > whole tree of Org::Element::Headline objects, since O::E::Headline has > the '_str' short cut. So as_string() won't be called for any Link.pm > in title or body. > > Present code: > > sub as_string { > my ($self) = @_; > return $self->_str if defined $self->_str; > join("", > "[", > "[", $self->link, "]", > (defined($self->description) && length($self->description) ? > ("[", $self->description, "]") : ()), > "]"); > } > > # The problem is that description is an Org::Element::Text. > # Change to: > ... > (defined($self->description) && length($self->description) ? > ("[", $self->description->as_string, "]") : ()), > ... > > > /Bernt Budde > > PS > Sorry, almost morning here. Too tired to write a test for you. :-( :-) > DS > > PPS > The module/version is Org-Parser-0.27 > > $ uname -a > Linux bughem 3.5.0-21-generic #32-Ubuntu SMP Tue Dec 11 18:51:59 UTC > 2012 x86_64 x86_64 x86_64 GNU/Linux > > $ perl -v > > This is perl 5, version 16, subversion 2 (v5.16.2) built for x86_64- > linux > > Copyright 1987-2012, Larry Wall > > Perl may be copied only under the terms of either the Artistic License > or the > GNU General Public License, which may be found in the Perl 5 source > kit. > > Complete documentation for Perl, including FAQ lists, should be found > on > this system using "man perl" or "perldoc perl". If you have access to > the > Internet, point your browser at http://www.perl.org/, the Perl Home > Page. > DS
From bernt.budde [...] gmail.com Fri Feb 8 23: 22:12 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.22 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-19458-1357573024-832.82334-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
References: <RT-Ticket-82334 [...] rt.cpan.org> <CAPd3O+TM7ypC1dLkw619TvS+d_8_u7JG++ev_NySRxfU1Df=+w [...] mail.gmail.com> <rt-3.8.HEAD-19458-1357573024-832.82334-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.180.82.9 with SMTP id e9mr6078733wiy.1.1360383721305; Fri, 08 Feb 2013 20:22:01 -0800 (PST)
Message-ID: <CAPd3O+RCNQLa0m095LSVLDhAB_B2cQD+7=PsvoTkNM4qa4eTMQ [...] mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.22
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 8E9CE240562 for <cpan-bug+Org-Parser [...] hipster.bestpractical.com>; Fri, 8 Feb 2013 23:22:12 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9XttRWR6Rpsv for <cpan-bug+Org-Parser [...] hipster.bestpractical.com>; Fri, 8 Feb 2013 23:22:10 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 88E6B24039F for <bug-Org-Parser [...] rt.cpan.org>; Fri, 8 Feb 2013 23:22:10 -0500 (EST)
Received: (qmail 28905 invoked by uid 103); 9 Feb 2013 04:22:09 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 9 Feb 2013 04:22:09 -0000
Received: from mail-wi0-f182.google.com (HELO mail-wi0-f182.google.com) (209.85.212.182) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Fri, 08 Feb 2013 20:22:05 -0800
Received: by mail-wi0-f182.google.com with SMTP id hi18so1546559wib.9 for <bug-Org-Parser [...] rt.cpan.org>; Fri, 08 Feb 2013 20:22:01 -0800 (PST)
Received: by 10.194.243.41 with HTTP; Fri, 8 Feb 2013 20:22:01 -0800 (PST)
Delivered-To: cpan-bug+Org-Parser [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #82334] Org::Element::Link bug in Org-Parser-0.27
Return-Path: <bernt.budde [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=qwFuxs8bH43Q88qAQz8DlAMAdjkkSUxFmOMCo6/NUj4=; b=rlFo0nh4VMc5X7ODUryaNpPHovZqEwCbnaFe1OIR+gDwYTrXKvJREDTGFSJdsj0OKJ slN8g9BmC9UVkZfLcwbVtnEh38xbhA4vhMwS//oNMXNoEiEepA/zIngNJ43/5boZNo6Y Qsg6bRLODhXFrtMyYsUo5pkVvrs7xECkaaUMO+8lWttXszRUr28mJrFMU44mdagGcrzC EiMmf/4NpjyNbZ/aN+s0GA6g+rOaDkNi2hDRpWJsQQWLnKLJZI+kfK+JCyImHgou06i2 WkbKxqjAQuI5k1oG/htxtWJ2cV2T3TyJ/dV2rFP5OYu1n+MeFgM1PqlJkGzne4kfR2zr 6wLw==
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Org-Parser [...] hipster.bestpractical.com
X-RT-Mail-Extension: org-parser
Date: Sat, 9 Feb 2013 06:22:01 +0200
X-Spam-Level:
To: bug-Org-Parser [...] rt.cpan.org
From: Bernt Budde <bernt.budde [...] gmail.com>
RT-Message-ID: <rt-3.8.HEAD-22501-1360383733-74.82334-0-0 [...] rt.cpan.org>
Content-Length: 2577
Download (untitled) / with headers
text/plain 2.5k
Hi again Steven, this isn't an Org::Parser problem, but you still might want to add a fix -- it is Org Mode's error (it probably is legal behaviour; I won't check the RFC). Org Mode store '=' as %3D in links. Doesn't work with all web sites. At least news.ycombinator.com (and probably other web sites) have problems when the '=' is translated. The problem is with links like http://foo.com/bar?a=b (I'd write a patch for Org/Document.pm if I thought you'd apply it. :-) ) Again thanks! Bernt On Mon, Jan 7, 2013 at 5:37 PM, steven haryanto via RT <bug-Org-Parser@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=82334 > > > Hi Bernt, > > Thanks for the report. Fixed and released 0.28. > > Regards, > Steven > > On Sun Dec 30 01:25:10 2012, bernt.budde@gmail.com wrote:
>> Hi, >> >> Thanks for a cool module! >> >> There is a small problem in the as_string() code in >> Org/Element/Link.pm >> >> You haven't seen this because as_string() works when called for a >> whole tree of Org::Element::Headline objects, since O::E::Headline has >> the '_str' short cut. So as_string() won't be called for any Link.pm >> in title or body. >> >> Present code: >> >> sub as_string { >> my ($self) = @_; >> return $self->_str if defined $self->_str; >> join("", >> "[", >> "[", $self->link, "]", >> (defined($self->description) && length($self->description) ? >> ("[", $self->description, "]") : ()), >> "]"); >> } >> >> # The problem is that description is an Org::Element::Text. >> # Change to: >> ... >> (defined($self->description) && length($self->description) ? >> ("[", $self->description->as_string, "]") : ()), >> ... >> >> >> /Bernt Budde >> >> PS >> Sorry, almost morning here. Too tired to write a test for you. :-( :-) >> DS >> >> PPS >> The module/version is Org-Parser-0.27 >> >> $ uname -a >> Linux bughem 3.5.0-21-generic #32-Ubuntu SMP Tue Dec 11 18:51:59 UTC >> 2012 x86_64 x86_64 x86_64 GNU/Linux >> >> $ perl -v >> >> This is perl 5, version 16, subversion 2 (v5.16.2) built for x86_64- >> linux >> >> Copyright 1987-2012, Larry Wall >> >> Perl may be copied only under the terms of either the Artistic License >> or the >> GNU General Public License, which may be found in the Perl 5 source >> kit. >> >> Complete documentation for Perl, including FAQ lists, should be found >> on >> this system using "man perl" or "perldoc perl". If you have access to >> the >> Internet, point your browser at http://www.perl.org/, the Perl Home >> Page. >> DS
> > >
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-22501-1360383733-74.82334-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <RT-Ticket-82334 [...] rt.cpan.org> <CAPd3O+TM7ypC1dLkw619TvS+d_8_u7JG++ev_NySRxfU1Df=+w [...] mail.gmail.com> <rt-3.8.HEAD-19458-1357573024-832.82334-6-0 [...] rt.cpan.org> <CAPd3O+RCNQLa0m095LSVLDhAB_B2cQD+7=PsvoTkNM4qa4eTMQ [...] mail.gmail.com> <rt-3.8.HEAD-22501-1360383733-74.82334-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-15316-1360716456-1531.82334-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 671
Download (untitled) / with headers
text/plain 671b
Hello again Bernt, Could you provide a test case and/or patch? Regards, Steven On Fri Feb 08 23:22:13 2013, bernt.budde@gmail.com wrote: Show quoted text
> Hi again Steven, > > this isn't an Org::Parser problem, but you still might want to add a > fix -- it is Org Mode's error (it probably is legal behaviour; I won't > check the RFC). > > Org Mode store '=' as %3D in links. Doesn't work with all web sites. > At least news.ycombinator.com (and probably other web sites) have > problems when the '=' is translated. > > The problem is with links like http://foo.com/bar?a=b > > (I'd write a patch for Org/Document.pm if I thought you'd apply it.
:-) ) Show quoted text
> > Again thanks! > Bernt
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-15316-1360716456-1531.82334-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <RT-Ticket-82334 [...] rt.cpan.org> <CAPd3O+TM7ypC1dLkw619TvS+d_8_u7JG++ev_NySRxfU1Df=+w [...] mail.gmail.com> <rt-3.8.HEAD-19458-1357573024-832.82334-6-0 [...] rt.cpan.org> <CAPd3O+RCNQLa0m095LSVLDhAB_B2cQD+7=PsvoTkNM4qa4eTMQ [...] mail.gmail.com> <rt-3.8.HEAD-22501-1360383733-74.82334-0-0 [...] rt.cpan.org> <rt-3.8.HEAD-15316-1360716456-1531.82334-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-7689-1365522702-449.82334-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 70
Sorry, closing this for now since there is no response from reporter.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.