Skip Menu |
 

This queue is for tickets about the HTML-Tree CPAN distribution.

Report information
The Basics
Id: 81371
Status: resolved
Priority: 0/
Queue: HTML-Tree

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 5.03
Fixed in: 5.900-TRIAL



Subject: t/construct_tree.t skips some some test on missing LWP::UserAgent with message `URI::file or LWP::UserAgent not installed'
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1414
Download (untitled) / with headers
text/plain 1.3k
If LWP::UserAgent is missing from system and URI::file is installed, t/construct_tree.t skips some tests with confusing message: ok 30 - found Gisle ok 31 # skip URI::file or LWP::UserAgent not installed ok 32 # skip URI::file or LWP::UserAgent not installed ok 33 # skip URI::file or LWP::UserAgent not installed ok 34 # skip URI::file or LWP::UserAgent not installed ok 35 # skip URI::file or LWP::UserAgent not installed ok 36 # skip URI::file or LWP::UserAgent not installed ok 37 # skip URI::file or LWP::UserAgent not installed ok 38 # skip URI::file or LWP::UserAgent not installed ok 39 # skip URI::file or LWP::UserAgent not installed ok 40 # skip URI::file or LWP::UserAgent not installed ok 41 # skip URI::file or LWP::UserAgent not installed ok 42 # skip URI::file or LWP::UserAgent not installed ok 43 # skip URI::file or LWP::UserAgent not installed ok 44 # skip URI::file or LWP::UserAgent not installed ok 45 # skip URI::file or LWP::UserAgent not installed ok 46 # skip URI::file or LWP::UserAgent not installed ok 47 - new_from_content Scalar REF isa HTML::TreeBuilder This is because the code does something different: SKIP: { eval { # RECOMMEND PREREQ: URI::file require URI::file; require LWP::UserAgent; 1; } or skip("URI::file or LWP::UserAgent not installed", 2 + 2 * tests_per_object); The logical or is not implemented properly.
From ppisar [...] redhat.com Fri Nov 23 06: 48:32 2012
X-Scanned-BY: MIMEDefang 2.67 on 10.5.11.12
MIME-Version: 1.0
X-Spam-Status: No, score=-6.504 tagged_above=-99.9 required=10 tests=[AWL=0.396, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
X-Authentication-Warning: dhcp-0-146.brq.redhat.com: petr set sender to ppisar [...] redhat.com using -f
In-Reply-To: <rt-3.8.HEAD-21099-1353667722-1538.81371-3-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
References: <RT-Ticket-81371 [...] rt.cpan.org> <rt-3.8.HEAD-21099-1353667722-1538.81371-3-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20121123114814.GA2106 [...] dhcp-0-146.brq.redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv"
X-Spam-Score: -6.504
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 029F8240307 for <cpan-bug+HTML-Tree [...] hipster.bestpractical.com>; Fri, 23 Nov 2012 06:48:32 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A687DbpYfopX for <cpan-bug+HTML-Tree [...] hipster.bestpractical.com>; Fri, 23 Nov 2012 06:48:27 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 0D97C240350 for <bug-HTML-Tree [...] rt.cpan.org>; Fri, 23 Nov 2012 06:48:26 -0500 (EST)
Received: (qmail 7489 invoked by uid 103); 23 Nov 2012 11:48:26 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 23 Nov 2012 11:48:26 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Fri, 23 Nov 2012 03:48:20 -0800
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qANBmINE005231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <bug-HTML-Tree [...] rt.cpan.org>; Fri, 23 Nov 2012 06:48:18 -0500
Received: from dhcp-0-146.brq.redhat.com (dhcp-25-104.brq.redhat.com [10.34.25.104]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qANBmGSg017223 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <bug-HTML-Tree [...] rt.cpan.org>; Fri, 23 Nov 2012 06:48:17 -0500
Received: from dhcp-0-146.brq.redhat.com (localhost.localdomain [127.0.0.1]) by dhcp-0-146.brq.redhat.com (8.14.5/8.14.5) with ESMTP id qANBmFJQ011159 for <bug-HTML-Tree [...] rt.cpan.org>; Fri, 23 Nov 2012 12:48:15 +0100
Received: (from petr [...] localhost) by dhcp-0-146.brq.redhat.com (8.14.5/8.14.5/Submit) id qANBmF5B011158 for bug-HTML-Tree [...] rt.cpan.org; Fri, 23 Nov 2012 12:48:15 +0100
Delivered-To: cpan-bug+HTML-Tree [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #81371] AutoReply: t/construct_tree.t skips some some test on missing LWP::UserAgent with message `URI::file or LWP::UserAgent not installed'
User-Agent: Mutt/1.5.21 (2010-09-15)
Return-Path: <ppisar [...] redhat.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+HTML-Tree [...] hipster.bestpractical.com
X-RT-Mail-Extension: html-tree
Date: Fri, 23 Nov 2012 12:48:15 +0100
X-Spam-Level:
To: Bugs in HTML-Tree via RT <bug-HTML-Tree [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
RT-Message-ID: <rt-3.8.HEAD-23032-1353671312-426.81371-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 664
Download (untitled) / with headers
text/plain 664b
On Fri, Nov 23, 2012 at 05:48:43AM -0500, Bugs in HTML-Tree via RT wrote: Show quoted text
> This is because the code does something different: > > SKIP: { > eval { > # RECOMMEND PREREQ: URI::file > require URI::file; > require LWP::UserAgent; > 1; > } or skip("URI::file or LWP::UserAgent not installed", > 2 + 2 * tests_per_object); > > The logical or is not implemented properly.
Based on experiment, the LWP::UserAgent is needed uncoditionally, otherwise the library dies in blib/lib/HTML/TreeBuilder.pm line 126. I think the skip message should be rephrased to "URI::file and LWP::UserAgent not installed". -- Petr
Content-Type: application/pgp-signature
Content-Length: 230
Download (untitled)
application/pgp-signature 230b

Message body not shown because it is not plain text.

MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-23033-1353693057-1660.81371-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 683
Download (untitled) / with headers
text/plain 683b
The code is correct. Both URI::file and LWP::UserAgent are required for the tests covered by that SKIP block. The message is attempting to say that tests are being skipped because "URI::file or LWP::UserAgent not installed". Or in pseudocode, skip if (URI::file not installed) or (LWP::UserAgent not installed); That is, if the condition in the message is true, the tests get skipped. I don't like your suggestion of "URI::file and LWP::UserAgent not installed" because it could be confusing to people who have one of them installed and don't understand why it's saying that neither of them is installed. How about "both URI::file and LWP::UserAgent needed for these tests"?
From ppisar [...] redhat.com Mon Nov 26 02: 40:44 2012
X-Scanned-BY: MIMEDefang 2.68 on 10.5.11.23
MIME-Version: 1.0
X-Spam-Status: No, score=-6.534 tagged_above=-99.9 required=10 tests=[AWL=0.366, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
X-Authentication-Warning: dhcp-0-146.brq.redhat.com: petr set sender to ppisar [...] redhat.com using -f
In-Reply-To: <rt-3.8.HEAD-23033-1353693058-1894.81371-6-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
References: <RT-Ticket-81371 [...] rt.cpan.org> <rt-3.8.HEAD-23033-1353693058-1894.81371-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20121126074030.GA1883 [...] dhcp-0-146.brq.redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MGYHOYXEY6WxJCY8"
X-Spam-Score: -6.534
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id B7C59240A16 for <cpan-bug+HTML-Tree [...] hipster.bestpractical.com>; Mon, 26 Nov 2012 02:40:44 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8079KV7Dz9xL for <cpan-bug+HTML-Tree [...] hipster.bestpractical.com>; Mon, 26 Nov 2012 02:40:42 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 16CA72409E3 for <bug-HTML-Tree [...] rt.cpan.org>; Mon, 26 Nov 2012 02:40:40 -0500 (EST)
Received: (qmail 26482 invoked by uid 103); 26 Nov 2012 07:40:40 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 26 Nov 2012 07:40:40 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Sun, 25 Nov 2012 23:40:37 -0800
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAQ7eYw2022992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <bug-HTML-Tree [...] rt.cpan.org>; Mon, 26 Nov 2012 02:40:34 -0500
Received: from dhcp-0-146.brq.redhat.com (dhcp-25-104.brq.redhat.com [10.34.25.104]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAQ7eVhZ031459 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <bug-HTML-Tree [...] rt.cpan.org>; Mon, 26 Nov 2012 02:40:33 -0500
Received: from dhcp-0-146.brq.redhat.com (localhost.localdomain [127.0.0.1]) by dhcp-0-146.brq.redhat.com (8.14.5/8.14.5) with ESMTP id qAQ7eVeX002377 for <bug-HTML-Tree [...] rt.cpan.org>; Mon, 26 Nov 2012 08:40:31 +0100
Received: (from petr [...] localhost) by dhcp-0-146.brq.redhat.com (8.14.5/8.14.5/Submit) id qAQ7eUDO002376 for bug-HTML-Tree [...] rt.cpan.org; Mon, 26 Nov 2012 08:40:30 +0100
Delivered-To: cpan-bug+HTML-Tree [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #81371] t/construct_tree.t skips some some test on missing LWP::UserAgent with message `URI::file or LWP::UserAgent not installed'
User-Agent: Mutt/1.5.21 (2010-09-15)
Return-Path: <ppisar [...] redhat.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+HTML-Tree [...] hipster.bestpractical.com
X-RT-Mail-Extension: html-tree
Date: Mon, 26 Nov 2012 08:40:30 +0100
X-Spam-Level:
To: "Christopher J. Madsen via RT" <bug-HTML-Tree [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
RT-Message-ID: <rt-3.8.HEAD-27477-1353915645-745.81371-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 511
Download (untitled) / with headers
text/plain 511b
On Fri, Nov 23, 2012 at 12:50:58PM -0500, Christopher J. Madsen via RT wrote: Show quoted text
> I don't like your suggestion of "URI::file and LWP::UserAgent not > installed" because it could be confusing to people who have one of them > installed and don't understand why it's saying that neither of them is > installed. >
I see. There was misunderstanding whether the message describes what's wrong or what has to be fulfilled. Show quoted text
> How about "both URI::file and LWP::UserAgent needed for these tests"?
That's good. -- Petr
Content-Type: application/pgp-signature
Content-Length: 230
Download (untitled)
application/pgp-signature 230b

Message body not shown because it is not plain text.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.