Skip Menu |
 

This queue is for tickets about the Test-DistManifest CPAN distribution.

Report information
The Basics
Id: 81355
Status: open
Priority: 0/
Queue: Test-DistManifest

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.2.3
Fixed in: (no value)



Subject: filenames with spaces are poorly handled
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1054
My MANIFEST contains (snipped): 'doc/America Corp Developer Guide ABC API Reference.doc' 'doc/America Corp Developer Guide XYZ API Reference.doc' Test::DistManifest (via the dzil plugin) doesn't like this: t/release-dist-manifest.t ......... Duplicate file or mask 'doc/America at /home/ad/karene/perl5/perlbrew/perls/perl-5.16.0/lib/site_perl/5.16.0/Test/DistManifest.pm line 74. t/release-dist-manifest.t ......... 1/4 # Distribution files are missing in MANIFEST: # doc/America Corp Developer Guide ABC API Reference.doc # doc/America Corp Developer Guide XYZ API Reference.doc # Failed test 'All files are listed in MANIFEST or skipped' # at t/release-dist-manifest.t line 16. # MANIFEST lists the following missing files: # 'doc/America # Failed test 'All files listed in MANIFEST exist on disk' # at t/release-dist-manifest.t line 16. # Looks like you failed 2 tests of 4. t/release-dist-manifest.t ......... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/4 subtests
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-29233-1353639280-285.81355-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
From: JAWNSY [...] cpan.org
X-RT-Original-Encoding: utf-8
Content-Length: 502
Download (untitled) / with headers
text/plain 502b
Hi Karen, I don't know if the MANIFEST file is designed to handle filenames with spaces. I've seen people use comments, e.g. "README # blah blah" where the trailing part should be treated as a "comment" and ignored. I don't remember if that's why I wrote it that way - from your test it looks like it's just looking at the first part (before whitespace) of each line. I don't know if there's actually a spec for MANIFEST files, I think I just guessed. So I might've done it wrong. Cheers, Jonathan
From ether [...] cpan.org Fri Nov 23 14: 27:29 2012
X-Sa-Exim-Connect-Ip: 65.110.24.194
MIME-Version: 1.0
X-Spam-Status: No, score=-4.959 tagged_above=-99.9 required=10 tests=[AWL=1.941, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-29233-1353639281-1447.81355-5-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
X-Sa-Exim-Version: 4.2.1 (built Mon, 22 Mar 2010 06:51:10 +0000)
References: <RT-Ticket-81355 [...] rt.cpan.org> <rt-3.8.HEAD-29233-1353639281-1447.81355-5-0 [...] rt.cpan.org>
X-Acl-Warn: !authenticated = *
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20121123192412.GA44278 [...] tequila.etheridge.ca>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -4.959
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 492E8240A34 for <cpan-bug+Test-DistManifest [...] hipster.bestpractical.com>; Fri, 23 Nov 2012 14:27:29 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KMVeOAm1QCdU for <cpan-bug+Test-DistManifest [...] hipster.bestpractical.com>; Fri, 23 Nov 2012 14:27:28 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id A9D51240A33 for <bug-Test-DistManifest [...] rt.cpan.org>; Fri, 23 Nov 2012 14:27:27 -0500 (EST)
Received: (qmail 10989 invoked by uid 103); 23 Nov 2012 19:27:26 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 23 Nov 2012 19:27:26 -0000
Received: from ns2.lightspeed.ca (HELO ns2.lightspeed.ca) (206.12.82.4) by 16.mx.develooper.com (qpsmtpd/0.84/v0.84-167-g4ed6cab) with ESMTP; Fri, 23 Nov 2012 11:24:17 -0800
Received: from xx65110024194.cipherkey.net ([65.110.24.194] helo=etheridge.ca) by ns2.lightspeed.ca with esmtp (Exim 4.72) (envelope-from <ether [...] cpan.org>) id 1TbyrF-0005ib-P8 for bug-Test-DistManifest [...] rt.cpan.org; Fri, 23 Nov 2012 11:24:14 -0800
Delivered-To: cpan-bug+Test-DistManifest [...] hipster.bestpractical.com
User-Agent: Mutt/1.4.2.3i
X-Sa-Exim-Mail-From: ether [...] cpan.org
Subject: Re: [rt.cpan.org #81355] filenames with spaces are poorly handled
Return-Path: <ether [...] cpan.org>
X-Original-To: cpan-bug+Test-DistManifest [...] hipster.bestpractical.com
X-RT-Mail-Extension: test-distmanifest
Date: Fri, 23 Nov 2012 11:24:12 -0800
X-Sa-Exim-Scanned: Yes (on ns2.lightspeed.ca)
X-Spam-Level:
To: Jonathan Yu via RT <bug-Test-DistManifest [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
RT-Message-ID: <rt-3.8.HEAD-7343-1353698850-1245.81355-0-0 [...] rt.cpan.org>
Content-Length: 427
Download (untitled) / with headers
text/plain 427b
On Thu, Nov 22, 2012 at 09:54:41PM -0500, Jonathan Yu via RT wrote: Show quoted text
> I don't know if the MANIFEST file is designed to handle filenames with > spaces.
Show quoted text
> I don't know if there's actually a spec for MANIFEST files, I think I > just guessed. So I might've done it wrong.
I asked around about this, and apparently whatever ExtUtils::Manifest does is "standard". There is also Module::Manifest for poking into an existing file.
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-7343-1353698850-1245.81355-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-81355 [...] rt.cpan.org> <rt-3.8.HEAD-29233-1353639281-1447.81355-5-0 [...] rt.cpan.org> <20121123192412.GA44278 [...] tequila.etheridge.ca> <rt-3.8.HEAD-7343-1353698850-1245.81355-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-26865-1554293211-139.81355-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 115
Download (untitled) / with headers
text/plain 115b
I stumbled over this issue as well with font license filenames that have whitespace. Any chance this gets resolved?


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.