Skip Menu |
 

This queue is for tickets about the HTTP-Server-Simple CPAN distribution.

Report information
The Basics
Id: 80041
Status: resolved
Priority: 0/
Queue: HTTP-Server-Simple

People
Owner: Nobody in particular
Requestors: polatel [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: Tests should not bind to 0.0.0.0
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1349549102-4435-5"
Content-Length: 0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 48
Tests should not bind to 0.0.0.0 Patch attached.
Subject: HTTP-Server-Simple-0.41-localhost.patch
MIME-Version: 1.0
Content-Type: text/x-patch; name="HTTP-Server-Simple-0.41-localhost.patch"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline; filename="HTTP-Server-Simple-0.41-localhost.patch"
Content-Transfer-Encoding: binary
Content-Length: 936
diff -ur HTTP-Server-Simple-0.41/t/01live.t HTTP-Server-Simple-0.41-localhost/t/01live.t --- HTTP-Server-Simple-0.41/t/01live.t 2009-08-12 19:13:55.000000000 +0300 +++ HTTP-Server-Simple-0.41-localhost/t/01live.t 2012-10-06 21:28:19.706591345 +0300 @@ -109,6 +109,7 @@ sub run_server_tests { my $class = shift; my $s = $class->new($PORT); + $s->host("localhost"); is($s->port(),$PORT,"Constructor set port correctly"); my $pid=$s->background(); diff -ur HTTP-Server-Simple-0.41/t/04cgi.t HTTP-Server-Simple-0.41-localhost/t/04cgi.t --- HTTP-Server-Simple-0.41/t/04cgi.t 2009-08-12 18:48:56.000000000 +0300 +++ HTTP-Server-Simple-0.41-localhost/t/04cgi.t 2012-10-06 21:28:51.966590653 +0300 @@ -32,6 +32,7 @@ { my $server=CGIServer->new($PORT); is($server->port(),$PORT,'Constructor set port correctly'); + $server->host("localhost"); sleep(3); # wait just a moment my $pid=$server->background;
From trs [...] bestpractical.com Tue Oct 9 13: 09:22 2012
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-4435-1349549103-54.80041-4-0 [...] rt.cpan.org>
References: <RT-Ticket-80041 [...] rt.cpan.org> <rt-3.8.HEAD-4435-1349549103-54.80041-4-0 [...] rt.cpan.org>
Message-ID: <50745A41.1020109 [...] bestpractical.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
Received: from [10.0.0.8] (c-67-183-142-187.hsd1.wa.comcast.net [67.183.142.187]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by hipster.bestpractical.com (Postfix) with ESMTPS id 34CB42400FF for <bug-HTTP-Server-Simple [...] rt.cpan.org>; Tue, 9 Oct 2012 13:09:22 -0400 (EDT)
Delivered-To: cpan-bug+HTTP-Server-Simple [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #80041] Tests should not bind to 0.0.0.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120912 Thunderbird/15.0.1
Return-Path: <trs [...] bestpractical.com>
X-Original-To: bug-HTTP-Server-Simple [...] rt.cpan.org
X-RT-Mail-Extension: http-server-simple
Date: Tue, 09 Oct 2012 10:09:21 -0700
To: bug-HTTP-Server-Simple [...] rt.cpan.org
X-Enigmail-Version: 1.4.4
Content-Transfer-Encoding: 7bit
From: Thomas Sibley <trs [...] bestpractical.com>
RT-Message-ID: <rt-3.8.HEAD-7961-1349802563-1314.80041-0-0 [...] rt.cpan.org>
Content-Length: 322
Download (untitled) / with headers
text/plain 322b
The patch doesn't apply cleanly to the tip of master in git (also currently release 0.45_02). When I hand apply the patch, tests fail for me for what looks like differences between IPv4 and IPv6. Can you re-roll the patch to apply to the tip of master and pass tests? http://github.com/bestpractical/http-server-simple
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-16173-1422892241-290.80041-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 357
Download (untitled) / with headers
text/plain 357b
On Sat Oct 06 14:45:03 2012, https://www.google.com/accounts/o8/id?id=AItOawnmnQbVjGMDy8P7v8JSTQmK4tx0pS2tztA wrote: Show quoted text
> Tests should not bind to 0.0.0.0 > Patch attached.
Looks like during my work for 0.50 I cleaned this up (including the ipv6 failures related to blindly using 'localhost' when many systems name their IPv6 loopback something else). -kevin


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.