Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 79162
Status: open
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: jffry [...] posteo.net
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



From jeffrey.ratcliffe [...] gmail.com Thu Aug 23 08: 02:27 2012
MIME-Version: 1.0
In-Reply-To: <DA5A8E2C697BF44AA3CFBCED78068A7C7F02BAA5 [...] AUGXCH001.DE.PA.CORP>
X-Spam-Status: No, score=-5.164 tagged_above=-99.9 required=10 tests=[AWL=1.056, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
X-Spam-Flag: NO
References: <DA5A8E2C697BF44AA3CFBCED78068A7C7F02BAA5 [...] AUGXCH001.DE.PA.CORP>
Content-Type: text/plain; charset=UTF-8
Message-ID: <CACg2wbyice=o1rcG=ynfbNUfcJDxj7LNFDC-50311sgKmm=ONA [...] mail.gmail.com>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -5.164
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 5BD9F24061D for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Thu, 23 Aug 2012 08:02:27 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4LM0iqh3DjEi for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Thu, 23 Aug 2012 08:02:26 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 06F542404F5 for <bug-Perl-Critic [...] rt.cpan.org>; Thu, 23 Aug 2012 08:02:25 -0400 (EDT)
Received: (qmail 25935 invoked by uid 103); 23 Aug 2012 12:02:25 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 23 Aug 2012 12:02:25 -0000
Received: from mail-ob0-f178.google.com (HELO mail-ob0-f178.google.com) (209.85.214.178) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Thu, 23 Aug 2012 05:02:18 -0700
Received: by obbwd20 with SMTP id wd20so1336713obb.9 for <bug-Perl-Critic [...] rt.cpan.org>; Thu, 23 Aug 2012 05:02:15 -0700 (PDT)
Received: by 10.50.40.225 with SMTP id a1mr1204917igl.51.1345723335309; Thu, 23 Aug 2012 05:02:15 -0700 (PDT)
Received: by 10.43.96.134 with HTTP; Thu, 23 Aug 2012 05:02:15 -0700 (PDT)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: Mechanism to ignore .tdy files
Return-Path: <jeffrey.ratcliffe [...] gmail.com>
X-RT-Mail-Extension: perl-critic
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-Spam-Check-BY: 16.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=s0KHNxlC4NmQrjhZG+lf68Yc2HoDzvIYRT7w0SvPph8=; b=hI69tS0Cs+/jubD9StOmDFOfSXvUQdvhnJyobY0MhPXHAfea+Au9LYnO7P1HN68X8w +qpXai4ERgx+836sftMJyvkjtfWlP6w9QunnCY6I5xbVolqBPA9tBcvwtKTU626dzUEt cxT0GB9gi0o6CSHRBZhJVnJN5J3JSjmP7+sFbeDRSyHijyUX2ponYjYHf/PSrHCqnVyH EGV9Z0S/Cvm6qFtAB5jkF3Kpe4hOzvq1y81ftmT8zZ4G/jAwqwzkxyZiOJjjCC+G3HGJ IF89fomz1xV5hqtuQ+kM4I24VdBKAQmv+8qZe5yO4W1gGR9wMXTYd5oZxw75Yj4mAhOR rSIw==
Date: Thu, 23 Aug 2012 14:02:15 +0200
X-Spam-Level:
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Ratcliffe <jeffrey.ratcliffe [...] gmail.com>
X-RT-Original-Encoding: utf-8
Content-Length: 253
Download (untitled) / with headers
text/plain 253b
I use P::C in conjunction with Perl::Tidy, which leaves .tdy files around. It would be convenient if there was a mechanism in all_critic_ok() for ignoring these .tdy files. An alternative would be if all_critic_ok() just considered files in MANIFEST.
MIME-Version: 1.0
In-Reply-To: <CACg2wbyice=o1rcG=ynfbNUfcJDxj7LNFDC-50311sgKmm=ONA [...] mail.gmail.com>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <DA5A8E2C697BF44AA3CFBCED78068A7C7F02BAA5 [...] AUGXCH001.DE.PA.CORP> <CACg2wbyice=o1rcG=ynfbNUfcJDxj7LNFDC-50311sgKmm=ONA [...] mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-19985-1345761004-529.79162-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 558
Download (untitled) / with headers
text/plain 558b
On Thu Aug 23 08:02:28 2012, RATCLIFFE wrote: Show quoted text
> I use P::C in conjunction with Perl::Tidy, which leaves .tdy files > around. > > It would be convenient if there was a mechanism in all_critic_ok() for > ignoring these .tdy files. > > An alternative would be if all_critic_ok() just considered files in > MANIFEST.
Making all_critic_ok() work this way would be a change in its documented behavior, and I can't see doing that. Maybe a separate manifest_critic_ok() subroutine that takes one or more manifest files as arguments, defaulting to 'MANIFEST'. Tom
From jeff [...] imaginative-software.com Thu Aug 23 19: 00:30 2012
MIME-Version: 1.0 (Apple Message framework v1278)
X-Spam-Status: No, score=-6.541 tagged_above=-99.9 required=10 tests=[AWL=0.358, BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-19985-1345761005-1512.79162-5-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.1278)
X-Spam-Flag: NO
References: <RT-Ticket-79162 [...] rt.cpan.org> <DA5A8E2C697BF44AA3CFBCED78068A7C7F02BAA5 [...] AUGXCH001.DE.PA.CORP> <CACg2wbyice=o1rcG=ynfbNUfcJDxj7LNFDC-50311sgKmm=ONA [...] mail.gmail.com> <rt-3.8.HEAD-19985-1345761005-1512.79162-5-0 [...] rt.cpan.org>
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Content-Type: multipart/alternative; boundary="Apple-Mail=_48F2B7D2-6BAB-409E-8E50-073755726DB8"
Message-ID: <60B070EE-3A95-4B34-8105-0CAB3B67CA82 [...] imaginative-software.com>
X-Spam-Score: -6.541
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 374372406A3 for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Thu, 23 Aug 2012 19:00:30 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4dvIPW0yALiD for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Thu, 23 Aug 2012 19:00:29 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id C431724068B for <bug-Perl-Critic [...] rt.cpan.org>; Thu, 23 Aug 2012 19:00:28 -0400 (EDT)
Received: (qmail 10012 invoked by uid 103); 23 Aug 2012 23:00:28 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 23 Aug 2012 23:00:28 -0000
Received: from mail-pb0-f50.google.com (HELO mail-pb0-f50.google.com) (209.85.160.50) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Thu, 23 Aug 2012 16:00:23 -0700
Received: by pbcmd12 with SMTP id md12so2032112pbc.9 for <bug-Perl-Critic [...] rt.cpan.org>; Thu, 23 Aug 2012 16:00:20 -0700 (PDT)
Received: by 10.66.9.2 with SMTP id v2mr6450573paa.65.1345762820595; Thu, 23 Aug 2012 16:00:20 -0700 (PDT)
Received: from [10.0.1.2] (c-69-181-194-211.hsd1.ca.comcast.net. [69.181.194.211]) by mx.google.com with ESMTPS id qx8sm6877690pbc.63.2012.08.23.16.00.19 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Aug 2012 16:00:19 -0700 (PDT)
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #79162] Mechanism to ignore .tdy files
Return-Path: <jeff [...] imaginative-software.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:mime-version:content-type:subject:date:in-reply-to:to :references:message-id:x-mailer:x-gm-message-state; bh=FgA7aZILr/pvfvUyCDg4McS1AI0aLHZkLzcNOJFLfjA=; b=DG2ACtqOYqrN6pOqJm/Y2KcDBYes/GIvUocgWxX5BkEHjTzpdLLMW9C7C0vQVZNpEX bfYYFKT+aKxwgHWSFTp5B7/1x4zTy+85x0LLq1PZLdIjHFiBuqfmWmC811eks5Lq4JGv VeYFue+hkhnT3h/Qd7tX4LaBfyF8CDSklFI2xBVsggPv/CIf7rxnoy7cJlmopSe1vaM7 9DzJG7lGGf3aM/8MYXNdQ5WzBjZ5VrREo+S9VX7EcJ0bY0vfKtgqpMCXqWhwfZ+HY3qi sAKFYF64uv65SsSebZ0HqZDC+HP6rokW5EdGAI2fzqgvWrv4gu9wQZDsClIAh3T2Z/fN zngw==
Date: Thu, 23 Aug 2012 16:00:17 -0700
X-Spam-Level:
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeff [...] imaginative-software.com>
X-GM-Message-State: ALoCoQnJF0WWMCQ5u1GA3nmK8XFsJWC+4dIqVydRp02yNZBwbqOJy0kUv1+3G8VozGQ0mpC/bd0I
RT-Message-ID: <rt-3.8.HEAD-23173-1345762831-189.79162-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1172
Download (untitled) / with headers
text/plain 1.1k
On Aug 23, 2012, at 3:30 PM, Tom Wyant via RT wrote: Show quoted text
> Making all_critic_ok() work this way would be a change in its documented > behavior, and I can't see doing that.
I think we can get away with it. As I understand the code now, anything with a .pl .pm or .PL extension is considered a perl file, as well as anything with 'perl" in the shebang line. That last one is mostly meant to catch executables that typically don't have an extension, and is probably more liberal than it needs to be. I suspect this is what is causing the problem. Rather than catching anything with a perl shebang, I think it would be reasonable to automatically exclude files with a .tdy extension. We already exclude things that look like backup files, so this isn't much different. It does change the behavior, but not in a way that seems radical to me. Tom -- do you see broader implications that I don't? Show quoted text
> Maybe a separate > manifest_critic_ok() subroutine that takes one or more manifest files as > arguments, defaulting to 'MANIFEST'.
That would be fine with me too, but not high on my priority list. Patches welcome. Actually, I'd be happy to give you a commit bit. -Jeff
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 2673
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-23173-1345762831-189.79162-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <RT-Ticket-79162 [...] rt.cpan.org> <DA5A8E2C697BF44AA3CFBCED78068A7C7F02BAA5 [...] AUGXCH001.DE.PA.CORP> <CACg2wbyice=o1rcG=ynfbNUfcJDxj7LNFDC-50311sgKmm=ONA [...] mail.gmail.com> <rt-3.8.HEAD-19985-1345761005-1512.79162-5-0 [...] rt.cpan.org> <60B070EE-3A95-4B34-8105-0CAB3B67CA82 [...] imaginative-software.com> <rt-3.8.HEAD-23173-1345762831-189.79162-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-19985-1345775651-596.79162-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 1754
Download (untitled) / with headers
text/plain 1.7k
On Thu Aug 23 19:00:31 2012, jeff@imaginative-software.com wrote: Show quoted text
> > On Aug 23, 2012, at 3:30 PM, Tom Wyant via RT wrote: >
> > Making all_critic_ok() work this way would be a change in its
> documented
> > behavior, and I can't see doing that.
> > I think we can get away with it. As I understand the code now, > anything with a .pl .pm or .PL extension is considered a perl file, > as well as anything with 'perl" in the shebang line. That last one > is mostly meant to catch executables that typically don't have an > extension, and is probably more liberal than it needs to be. I > suspect this is what is causing the problem.
I came to the same conclusion. Show quoted text
> > Rather than catching anything with a perl shebang, I think it would be > reasonable to automatically exclude files with a .tdy extension. We > already exclude things that look like backup files, so this isn't > much different. It does change the behavior, but not in a way that > seems radical to me. > > Tom -- do you see broader implications that I don't?
No, I was just being paranoid. I thought I'd see if one of the other developers came up with the "add '.tdy' files to the 'skip backup files' logic" solution, as a check on my own sanity. If we do it this way it's a one-liner. Show quoted text
>
> > Maybe a separate > > manifest_critic_ok() subroutine that takes one or more manifest
> files as
> > arguments, defaulting to 'MANIFEST'.
> > That would be fine with me too, but not high on my priority list.
Yeah. I suggested it because I have done a couple tools for myself that run off the manifest, because I tend to collect cruft. But if skipping .tdy files passes muster, my vote is to defer manifest_critic_ok() until it's really needed. Tom


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.