Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 77693
Status: open
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: intrigeri [...] debian.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
0001-Don-t-use-obsolete-make-local-hook-function.patch



From intrigeri [...] boum.org Thu Jun 7 18: 22:06 2012
MIME-Version: 1.0
X-Spam-Status: No, score=-3.9 tagged_above=-99.9 required=10 tests=[AWL=3.000, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
X-Mailer: MIME::Lite 3.028 (F2.82; T1.34; A2.08; B3.13; Q3.13)
X-Spam-Flag: NO
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
Message-ID: <20120607222136.99C8F735673 [...] localhost>
Content-Type: multipart/mixed; boundary="_----------=_133910760351790"
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -3.9
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 14D9824036F for <cpan-bug+perl-critic [...] hipster.bestpractical.com>; Thu, 7 Jun 2012 18:22:06 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id azbzg25Ase-L for <cpan-bug+perl-critic [...] hipster.bestpractical.com>; Thu, 7 Jun 2012 18:22:04 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 5B110240124 for <bug-perl-critic [...] rt.cpan.org>; Thu, 7 Jun 2012 18:22:04 -0400 (EDT)
Received: (qmail 28191 invoked by uid 103); 7 Jun 2012 22:22:03 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 7 Jun 2012 22:22:03 -0000
Received: from boum.org (HELO boum.org) (204.13.164.192) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Thu, 07 Jun 2012 15:21:57 -0700
Received: from localhost (localhost [127.0.0.1]) by boum.org (Postfix) with ESMTP id 7D7D3441A9 for <bug-perl-critic [...] rt.cpan.org>; Fri, 8 Jun 2012 00:21:54 +0200 (CEST)
Received: from boum.org ([10.36.27.29]) by localhost (censure.boum.org [10.36.27.20]) (amavisd-new, port 10024) with ESMTP id DREb2eWUK1Pp for <bug-perl-critic [...] rt.cpan.org>; Fri, 8 Jun 2012 00:21:54 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1]) by boum.org (Postfix) with ESMTPSA id E08324419F for <bug-perl-critic [...] rt.cpan.org>; Fri, 8 Jun 2012 00:21:52 +0200 (CEST)
Received: by localhost (Postfix, from userid 1002) id 99C8F735673; Fri, 8 Jun 2012 00:21:35 +0200 (CEST)
Delivered-To: cpan-bug+perl-critic [...] hipster.bestpractical.com
Subject: [PATCH] Stop using obsolete make-local-hook function
Return-Path: <intrigeri [...] boum.org>
X-RT-Mail-Extension: perl-critic
X-Original-To: cpan-bug+perl-critic [...] hipster.bestpractical.com
X-Spam-Check-BY: 16.mx.develooper.com
Date: Fri, 8 Jun 2012 00:20:03 +0200
X-Spam-Level:
To: bug-perl-critic [...] rt.cpan.org
Content-Transfer-Encoding: binary
From: intrigeri <intrigeri [...] debian.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-RT-Original-Encoding: ascii
Content-Length: 619
Download (untitled) / with headers
text/plain 619b
In Debian we are currently applying the attached patch to Perl-Critic. We thought you might be interested in it, too. From: intrigeri <intrigeri@boum.org> Date: Thu, 7 Jun 2012 23:17:51 +0200 Subject: Don't use obsolete make-local-hook function. Instead, pass a non-nil value to the `LOCAL' argument of add-hook, which has been nicely replacing the need to run make-local-hook since Emacs 21.1. --- extras/perlcritic.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/extras/perlcritic.el b/extras/perlcritic.el index e1b74a7..570b9c7 100644 Thanks in advance, intrigeri, Debian Perl Group
content-type: text/plain; charset="utf-8"; name="0001-Don-t-use-obsolete-make-local-hook-function.patch"
content-disposition: attachment; filename="0001-Don-t-use-obsolete-make-local-hook-function.patch"
Content-Transfer-Encoding: 8bit
X-RT-Original-Encoding: ascii
Content-Length: 969

Message body is not shown because sender requested not to inline it.

From jeff [...] imaginative-software.com Fri Jun 8 16: 40:37 2012
MIME-Version: 1.0 (Apple Message framework v1084)
X-Spam-Status: No, score=-6.285 tagged_above=-99.9 required=10 tests=[AWL=0.615, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-5030-1339107727-1199.77693-4-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.1084)
X-Spam-Flag: NO
References: <RT-Ticket-77693 [...] rt.cpan.org> <20120607222136.99C8F735673 [...] localhost> <rt-3.8.HEAD-5030-1339107727-1199.77693-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Content-Type: text/plain; charset="utf-8"
Message-ID: <FDEDEDE5-2A2C-4985-B703-0F6CAD54FDF1 [...] imaginative-software.com>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.285
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 6B7262403C9 for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 8 Jun 2012 16:40:37 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4XxQmuSMT3ue for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 8 Jun 2012 16:40:34 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 16F89240389 for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 8 Jun 2012 16:40:33 -0400 (EDT)
Received: (qmail 28356 invoked by uid 103); 8 Jun 2012 20:40:33 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 8 Jun 2012 20:40:33 -0000
Received: from mail-pz0-f50.google.com (HELO mail-pz0-f50.google.com) (209.85.210.50) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Fri, 08 Jun 2012 13:40:30 -0700
Received: by danh15 with SMTP id h15so2620985dan.9 for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 08 Jun 2012 13:40:27 -0700 (PDT)
Received: by 10.68.226.193 with SMTP id ru1mr8370351pbc.79.1339188027421; Fri, 08 Jun 2012 13:40:27 -0700 (PDT)
Received: from [10.0.1.2] (c-69-181-194-211.hsd1.ca.comcast.net. [69.181.194.211]) by mx.google.com with ESMTPS id to1sm8931252pbc.27.2012.06.08.13.40.23 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 08 Jun 2012 13:40:25 -0700 (PDT)
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #77693] [PATCH] Stop using obsolete make-local-hook function
Return-Path: <jeff [...] imaginative-software.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to:x-mailer :x-gm-message-state; bh=T8jzCDJpSgkaSrTv1Ru2NNu00N58I31OpCq6dLZ+Sb8=; b=K67O72dWbKJWtcasj8rZkUdCwIt/1xYD6zj8mA+cav8chedM1VoeGqfkExnb3kCA1Q sTvDqwCDFo6YeomSHEndnA/nlC6ZqzGoGCPhJBZrtTMTdDyO8+tUuiRBgmAWhppDRl39 AhyNfgVd9U0cbZwfxVGvkgF1DUKEGykJ7yZVtfzLCEGWurKfMbP6MuMro8qlxxnasJYF xiAQJUFG7WZkdBtJB4Bx71LwUG5V573hgJbcbmRZr5JIMh8pckCJtxIgP0GVkRq0rIzT 8LqSCe+IZ1PaUeiQnvb+xZRN0tEXS2xeKpddTyKxKKgUXxzSfwzaoWEQzmyMhWHeBJrC CC0Q==
Date: Fri, 8 Jun 2012 13:40:22 -0700
X-Spam-Level:
To: bug-Perl-Critic [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Jeffrey Thalhammer <jeff [...] imaginative-software.com>
X-GM-Message-State: ALoCoQnlRvbzevhGZ4lSLGdFA0DmNwLqGDn+1+D/POcQrl7RuhD/KSmuGGyYcXPzAuBr3zDWor8a
RT-Message-ID: <rt-3.8.HEAD-16110-1339188038-617.77693-0-0 [...] rt.cpan.org>
Content-Length: 136
Download (untitled) / with headers
text/plain 136b
Thanks! Is there any harm in doing it the old way (for the sake of compatibility)? Not saying I won't change it -- just asking. -Jeff
From intrigeri [...] debian.org Fri Jun 8 16: 49:46 2012
MIME-Version: 1.0
X-Spam-Status: No, score=-4.9 tagged_above=-99.9 required=10 tests=[AWL=2.000, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-16110-1339188038-1519.77693-6-0 [...] rt.cpan.org> (Jeffrey Thalhammer via's message of "Fri, 8 Jun 2012 16:40:39 -0400")
X-Spam-Flag: NO
References: <RT-Ticket-77693 [...] rt.cpan.org> <20120607222136.99C8F735673 [...] localhost> <rt-3.8.HEAD-5030-1339107727-1199.77693-4-0 [...] rt.cpan.org> <FDEDEDE5-2A2C-4985-B703-0F6CAD54FDF1 [...] imaginative-software.com> <rt-3.8.HEAD-16110-1339188038-1519.77693-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <85obot5y2i.fsf [...] boum.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -4.9
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id AB4222403B0 for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 8 Jun 2012 16:49:46 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xmNtwspUv86x for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 8 Jun 2012 16:49:45 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 3F784240389 for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 8 Jun 2012 16:49:45 -0400 (EDT)
Received: (qmail 28994 invoked by uid 103); 8 Jun 2012 20:49:44 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 8 Jun 2012 20:49:44 -0000
Received: from boum.org (HELO boum.org) (204.13.164.192) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Fri, 08 Jun 2012 13:49:42 -0700
Received: from localhost (localhost [127.0.0.1]) by boum.org (Postfix) with ESMTP id BADAC441DD for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 8 Jun 2012 22:49:39 +0200 (CEST)
Received: from boum.org ([10.36.27.29]) by localhost (censure.boum.org [10.36.27.20]) (amavisd-new, port 10024) with ESMTP id e+nzdmY6RN2i for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 8 Jun 2012 22:49:39 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1]) by boum.org (Postfix) with ESMTPSA id 1DBC8441D3 for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 8 Jun 2012 22:49:38 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1]) by localhost (Postfix) with ESMTP id 07CB67355D8 for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 8 Jun 2012 22:49:09 +0200 (CEST)
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #77693] [PATCH] Stop using obsolete make-local-hook function
Return-Path: <intrigeri [...] debian.org>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic
Date: Fri, 08 Jun 2012 22:49:09 +0200
X-Spam-Level:
To: bug-Perl-Critic [...] rt.cpan.org
From: intrigeri <intrigeri [...] debian.org>
RT-Message-ID: <rt-3.8.HEAD-31486-1339188587-1892.77693-0-0 [...] rt.cpan.org>
Content-Length: 358
Download (untitled) / with headers
text/plain 358b
Jeffrey Thalhammer via RT wrote (08 Jun 2012 20:40:39 GMT) : Show quoted text
> Thanks! Is there any harm in doing it the old way (for the sake of > compatibility)?
There is: Emacs 24 does not have the old function anymore. The old function has been deprecated since Emacs 21.1, that was released October 20, 2001. I think it's better to support Emacs 24 than Emacs 21.1.
From jeff [...] imaginative-software.com Fri Jun 8 16: 53:11 2012
MIME-Version: 1.0 (Apple Message framework v1084)
X-Spam-Status: No, score=-6.362 tagged_above=-99.9 required=10 tests=[AWL=0.537, BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-31486-1339188587-82.77693-5-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.1084)
X-Spam-Flag: NO
References: <RT-Ticket-77693 [...] rt.cpan.org> <20120607222136.99C8F735673 [...] localhost> <rt-3.8.HEAD-5030-1339107727-1199.77693-4-0 [...] rt.cpan.org> <FDEDEDE5-2A2C-4985-B703-0F6CAD54FDF1 [...] imaginative-software.com> <rt-3.8.HEAD-16110-1339188038-1519.77693-6-0 [...] rt.cpan.org> <85obot5y2i.fsf [...] boum.org> <rt-3.8.HEAD-31486-1339188587-82.77693-5-0 [...] rt.cpan.org>
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Content-Type: multipart/alternative; boundary=Apple-Mail-11-104329114
Message-ID: <6E293CE5-5E76-4AD2-A8A8-36CD478D9CE5 [...] imaginative-software.com>
X-Spam-Score: -6.362
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 50A292403B0 for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 8 Jun 2012 16:53:11 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OX5mt76Q6G5k for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 8 Jun 2012 16:53:10 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 00233240389 for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 8 Jun 2012 16:53:09 -0400 (EDT)
Received: (qmail 29252 invoked by uid 103); 8 Jun 2012 20:53:09 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 8 Jun 2012 20:53:09 -0000
Received: from mail-pz0-f50.google.com (HELO mail-pz0-f50.google.com) (209.85.210.50) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Fri, 08 Jun 2012 13:53:06 -0700
Received: by danh15 with SMTP id h15so2631726dan.9 for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 08 Jun 2012 13:53:04 -0700 (PDT)
Received: by 10.68.193.198 with SMTP id hq6mr24925308pbc.21.1339188784020; Fri, 08 Jun 2012 13:53:04 -0700 (PDT)
Received: from [10.0.1.2] (c-69-181-194-211.hsd1.ca.comcast.net. [69.181.194.211]) by mx.google.com with ESMTPS id vp4sm8948022pbc.61.2012.06.08.13.53.02 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 08 Jun 2012 13:53:03 -0700 (PDT)
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #77693] [PATCH] Stop using obsolete make-local-hook function
Return-Path: <jeff [...] imaginative-software.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:mime-version:content-type:subject:date:in-reply-to:to :references:message-id:x-mailer:x-gm-message-state; bh=xLY3ownU0kScPIcayGo3/6PNWZgM1Qx1HdVE2kIse3M=; b=M8Ux73gPYBFiJS8K4ZzPrp8NShumznkrlazBSR0QFIO+9i/66s7TVkNU0cEZA210V5 CFwoOMYlABNcdAMutDYDLvhBD3PGPUstIIlXBfmfx4g5xiTtgDDyvZscpk0m87tAMJyw ncH/NdcobOvtP1PIOxXiZHRGEoIO33slrClp9tvt2b0oBg6dRmdoaognFBR71ET8qR7H hIfDWAV34AIaRDf0bple4iR/IZh+zahEEZGbPS6YLvaIuvLPFbsEMVSj1HDk5C8zIhOy y0fIAF+g7sSi/UzLp58rtU2bFNrTL69pfSzpqmsawrVyrlPqxHDU5P4w+Fh2uKquRUR0 kq4g==
Date: Fri, 8 Jun 2012 13:53:01 -0700
X-Spam-Level:
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeff [...] imaginative-software.com>
X-GM-Message-State: ALoCoQl5U2IVFLnLxwtCDTJAqHnAGZF3A2Vunl0NQcE26/jj98YATar7zTmf2XIpdZOUf2JCtTA7
RT-Message-ID: <rt-3.8.HEAD-31486-1339188792-39.77693-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-RT-Original-Encoding: utf-8
Content-Length: 248
Download (untitled) / with headers
text/plain 248b
On Jun 8, 2012, at 1:49 PM, intrigeri via RT wrote: Show quoted text
> The old function has been deprecated since Emacs 21.1, > that was released October 20, 2001. > > I think it's better to support Emacs 24 than Emacs 21.1.
Good enough for me. Thanks! -Jeff
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1060


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.