Skip Menu |
 

This queue is for tickets about the Poet CPAN distribution.

Report information
The Basics
Id: 77676
Status: open
Priority: 0/
Queue: Poet

People
Owner: Nobody in particular
Requestors: fschlich [...] zedat.fu-berlin.de
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 0.11
Fixed in: (no value)



Subject: typos in pod
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 1551
Download (untitled) / with headers
text/plain 1.5k
Hi, while working on packaging Poet for Debian, our QA tools called my attention to few typos in the pod, and I'd like to share the patch for inclusion at your convenience: --- a/lib/Poet/Conf.pm +++ b/lib/Poet/Conf.pm @@ -502,7 +502,7 @@ cache.defaults.depth: 2 -then only C<depth> will be overriden; the C<driver> and C<root_dir> will remain +then only C<depth> will be overridden; the C<driver> and C<root_dir> will remain as they were set in C<global/cache.cfg>. If instead local.cfg had cache: --- a/lib/Poet/Environment.pm +++ b/lib/Poet/Environment.pm @@ -249,7 +249,7 @@ =head1 CONFIGURING ENVIRONMENT SUBDIRECTORIES -Any subdirectories other than conf_dir can be overriden in configuration. e.g. +Any subdirectories other than conf_dir can be overridden in configuration. e.g. # Override bin_dir env.bin_dir: /some/other/bin/dir --- a/lib/Poet/Mason.pm +++ b/lib/Poet/Mason.pm @@ -206,7 +206,7 @@ =item clear_and_abort (status) -These methods are overriden to set the response status before aborting, if +These methods are overridden to set the response status before aborting, if I<status> is provided. e.g. to send back a FORBIDDEN result: $m->clear_and_abort(403); On a side note, I was forced to install File::Copy::Recursive in addition to the modules mentioned in META.yml or test_dot_files_in_share_dir() from lib/Poet/t/Environment.pm wouldn't pass. I wonder if that method isn't really an author test and shouldn't be run *unless* (not *if*) $ENV{AUTHOR_TESTING} is set? Florian
From swartz [...] pobox.com Thu Jun 7 15: 30:13 2012
MIME-Version: 1.0 (Apple Message framework v1084)
X-Spam-Status: No, score=-5.306 tagged_above=-99.9 required=10 tests=[AWL=0.815, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-13733-1339019302-902.77676-4-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.1084)
X-Spam-Flag: NO
References: <RT-Ticket-77676 [...] rt.cpan.org> <rt-3.8.HEAD-13733-1339019302-902.77676-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Content-Type: text/plain; charset="utf-8"
Message-ID: <63A3CD98-0388-40C4-A9FE-6F4350EB48CF [...] pobox.com>
X-Sasl-Enc: zX4jWdtMOFdg/LT8Mc8wfYiK4iDH15r5cI7uJU+ybCUz 1339097396
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.306
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] messagingengine.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 9641424036F for <cpan-bug+Poet [...] hipster.bestpractical.com>; Thu, 7 Jun 2012 15:30:13 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DHKC0UmDwOFS for <cpan-bug+Poet [...] hipster.bestpractical.com>; Thu, 7 Jun 2012 15:30:12 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id C6B31240124 for <bug-Poet [...] rt.cpan.org>; Thu, 7 Jun 2012 15:30:11 -0400 (EDT)
Received: (qmail 12437 invoked by uid 103); 7 Jun 2012 19:30:11 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 7 Jun 2012 19:30:11 -0000
Received: from out1-smtp.messagingengine.com (HELO out1-smtp.messagingengine.com) (66.111.4.25) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Thu, 07 Jun 2012 12:30:01 -0700
Received: from compute4.internal (compute4.nyi.mail.srv.osa [10.202.2.44]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 325BB21189 for <bug-Poet [...] rt.cpan.org>; Thu, 7 Jun 2012 15:29:58 -0400 (EDT)
Received: from frontend1.nyi.mail.srv.osa ([10.202.2.160]) by compute4.internal (MEProxy); Thu, 07 Jun 2012 15:29:58 -0400
Received: from [10.1.10.110] (unknown [24.130.81.47]) by mail.messagingengine.com (Postfix) with ESMTPA id 9E2D18E008C for <bug-Poet [...] rt.cpan.org>; Thu, 7 Jun 2012 15:29:56 -0400 (EDT)
Delivered-To: cpan-bug+Poet [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #77676] typos in pod
Return-Path: <swartz [...] pobox.com>
Dkim-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:mime-version:subject:from :in-reply-to:date:content-transfer-encoding:message-id :references:to; s=smtpout; bh=WwT1AZzMAzh21QxX9tXhw9u7x0w=; b=gO 97i+GjPAKHQ3/a4OahjUFT2OwMtEQ9wm50AfxqlBWPa0MK3/CoidRfKjX4YRa7Xy wGHTR/phpu6fcpBDuVOhyZ6OeLozwB24KNlkX1Vciut2vZevB181eBuxHMK938HW iUTYhFhEn/RhNWOyfSV1QjHCnat2rpUAom7UzzDDw=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Poet [...] hipster.bestpractical.com
X-RT-Mail-Extension: poet
Date: Thu, 7 Jun 2012 12:29:54 -0700
X-Spam-Level:
To: bug-Poet [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Jonathan Swartz <swartz [...] pobox.com>
RT-Message-ID: <rt-3.8.HEAD-8038-1339097414-1735.77676-0-0 [...] rt.cpan.org>
Content-Length: 2130
Man, I cannot spell overridden right! :) Fixed in next release. Thanks Jon On Jun 6, 2012, at 2:48 PM, Florian via RT wrote: Show quoted text
> Wed Jun 06 17:48:21 2012: Request 77676 was acted upon. > Transaction: Ticket created by fschlich > Queue: Poet > Subject: typos in pod > Broken in: 0.11 > Severity: Wishlist > Owner: Nobody > Requestors: fschlich@zedat.fu-berlin.de > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77676 > > > > Hi, > > while working on packaging Poet for Debian, our QA tools called my > attention to few typos in the pod, and I'd like to share the patch for > inclusion at your convenience: > > > --- a/lib/Poet/Conf.pm > +++ b/lib/Poet/Conf.pm > @@ -502,7 +502,7 @@ > > cache.defaults.depth: 2 > > -then only C<depth> will be overriden; the C<driver> and C<root_dir> > will remain > +then only C<depth> will be overridden; the C<driver> and C<root_dir> > will remain > as they were set in C<global/cache.cfg>. If instead local.cfg had > > cache: > --- a/lib/Poet/Environment.pm > +++ b/lib/Poet/Environment.pm > @@ -249,7 +249,7 @@ > > =head1 CONFIGURING ENVIRONMENT SUBDIRECTORIES > > -Any subdirectories other than conf_dir can be overriden in > configuration. e.g. > +Any subdirectories other than conf_dir can be overridden in > configuration. e.g. > > # Override bin_dir > env.bin_dir: /some/other/bin/dir > --- a/lib/Poet/Mason.pm > +++ b/lib/Poet/Mason.pm > @@ -206,7 +206,7 @@ > > =item clear_and_abort (status) > > -These methods are overriden to set the response status before aborting, > if > +These methods are overridden to set the response status before > aborting, if > I<status> is provided. e.g. to send back a FORBIDDEN result: > > $m->clear_and_abort(403); > > > On a side note, I was forced to install File::Copy::Recursive in > addition to the modules mentioned in META.yml or > test_dot_files_in_share_dir() from lib/Poet/t/Environment.pm wouldn't > pass. I wonder if that method isn't really an author test and shouldn't > be run *unless* (not *if*) $ENV{AUTHOR_TESTING} is set? > > Florian


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.