Skip Menu |
 

This queue is for tickets about the Test-Perl-Critic-Progressive CPAN distribution.

Report information
The Basics
Id: 77275
Status: open
Priority: 0/
Queue: Test-Perl-Critic-Progressive

People
Owner: Nobody in particular
Requestors: hhn [...] jobindex.dk
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From hhn [...] jobindex.dk Fri May 18 08: 30:23 2012
MIME-Version: 1.0
X-Spam-Status: No, score=-5.499 tagged_above=-99.9 required=10 tests=[BAYES_05=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5] autolearn=ham
X-Mailer: Microsoft Outlook 14.0
X-Spam-Flag: NO
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
Content-Language: da
Content-Type: multipart/alternative; boundary="----=_NextPart_000_0106_01CD3502.BB849F10"
Message-ID: <010501cd34f1$f7fbcf10$e7f36d30$ [...] jobindex.dk>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Virus-Scanned: amavisd-new at jobindex.dk
X-Spam-Score: -5.499
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 2424424030E for <cpan-bug+Test-Perl-Critic-Progressive [...] hipster.bestpractical.com>; Fri, 18 May 2012 08:30:23 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uQAo2yLBLbIN for <cpan-bug+Test-Perl-Critic-Progressive [...] hipster.bestpractical.com>; Fri, 18 May 2012 08:30:21 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id E15792402EE for <bug-Test-Perl-Critic-Progressive [...] rt.cpan.org>; Fri, 18 May 2012 08:30:20 -0400 (EDT)
Received: (qmail 21128 invoked by uid 103); 18 May 2012 12:30:20 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 18 May 2012 12:30:20 -0000
Received: from mail.jobindex.dk (HELO mail.jobindex.dk) (77.234.172.213) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Fri, 18 May 2012 05:30:15 -0700
Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.jobindex.dk (Postfix) with ESMTP id A43F8A437F for <bug-Test-Perl-Critic-Progressive [...] rt.cpan.org>; Fri, 18 May 2012 14:30:11 +0200 (CEST)
Received: from mail.jobindex.dk ([127.0.0.1]) by localhost (mail.jobindex.dk [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id dCNs2pyHb0Zo for <bug-Test-Perl-Critic-Progressive [...] rt.cpan.org>; Fri, 18 May 2012 14:30:11 +0200 (CEST)
Received: from hhn (fw.jobindex.dk [77.234.172.214]) by mail.jobindex.dk (Postfix) with ESMTP id 887F6A4372 for <bug-Test-Perl-Critic-Progressive [...] rt.cpan.org>; Fri, 18 May 2012 14:30:11 +0200 (CEST)
Delivered-To: cpan-bug+Test-Perl-Critic-Progressive [...] hipster.bestpractical.com
Subject: Adding new policy
Return-Path: <hhn [...] jobindex.dk>
Thread-Index: Ac008bqjnm1ggVT7T8W9kZs/vmAgKA==
X-RT-Mail-Extension: test-perl-critic-progressive
X-Original-To: cpan-bug+Test-Perl-Critic-Progressive [...] hipster.bestpractical.com
X-Spam-Check-BY: 16.mx.develooper.com
Date: Fri, 18 May 2012 14:30:11 +0200
X-Spam-Level:
To: <bug-Test-Perl-Critic-Progressive [...] rt.cpan.org>
From: Henrik Hald Nørgaard <hhn [...] jobindex.dk>
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: iso-8859-1
Content-Length: 814
Download (untitled) / with headers
text/plain 814b
When I add a new policy to my perlcritic configuration, the number of violations of the new policy is not written to the history file used by Test::Perl::Critic::Progressive. Here is a patch that should fix this : 162a163 Show quoted text
> my $new_policies = 0;
174c175,178 < next if not defined $last_policy_violations; --- Show quoted text
> if (not defined $last_policy_violations) { > $new_policies = 1; > next; > }
212c216 < if ( !$has_run_before || ($ok && $last_total_violations > 0) ) { --- Show quoted text
> if ( !$has_run_before || ($ok && $last_total_violations > 0) ||
$new_policies ) { Kind regards Henrik Hald Nørgaard, Programmør Jobindex A/S, Holger Danskes Vej 91, 2000 Frederiksberg Tlf.: +45 38 32 33 55, dir.: +45 38 32 33 81 <http://www.jobindex.dk/> www.jobindex.dk
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: iso-8859-1
Content-Length: 3414
MIME-Version: 1.0
In-Reply-To: <010501cd34f1$f7fbcf10$e7f36d30$ [...] jobindex.dk>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <010501cd34f1$f7fbcf10$e7f36d30$ [...] jobindex.dk>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-7233-1338401065-496.77275-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 184
Download (untitled) / with headers
text/plain 184b
[Sorry for the slow reply -- I've been out of town] Thanks for the patch! I'll put this in the next release. If you happen to have a test case, that would be appreciated too. -Jeff


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.