Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 76189
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: MARKSTOS [...] cpan.org
Requestors: shay [...] cpan.org
Cc: perl5-porters [...] perl.org
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



CC: perl5-porters [...] perl.org
Subject: Test script missing from CGI.pm CPAN distribution?
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1333211378-2604-13"
Content-Length: 0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 778
Download (untitled) / with headers
text/plain 778b
I have noticed that a change was applied to perl (maint-5.12) in Jan 2011 which modified CGI.pm itself and added two new test scripts: headers.t and multipart_init.t: http://perl5.git.perl.org/perl.git/commit/b7fa2aca51 The first two changes do seem to have found their way back to the CGI.pm CPAN distro, but the latter change -- the addition of multipart_init.t -- appears to have been missed. I've checked through every CPAN release from 3.48 through 3.59 and don't see it anywhere, despite the Changes file for 3.52 claiming to have fixed a logic error in it! The current bleadperl version is attached. Could you please consider including it (or a later version if you have one, perhaps including whatever fixes 3.52's Changes file was referring to?) in future releases.
Subject: multipart_init.t
MIME-Version: 1.0
Content-Type: application/octet-stream; name="multipart_init.t"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline; filename="multipart_init.t"
Content-Transfer-Encoding: base64
Content-Length: 722
Download multipart_init.t
text/x-perl 722b
use Test::More 'no_plan'; use CGI; my $q = CGI->new; my $sv = $q->multipart_init; like( $sv, qr|Content-Type: multipart/x-mixed-replace;boundary="------- =|, 'multipart_init(), basic'); like( $sv, qr/$CGI::CRLF$/, 'multipart_init(), ends in CRLF' ); $sv = $q->multipart_init( 'this_is_the_boundary' ); like( $sv, qr/boundary="this_is_the_boundary"/, 'multipart_init("simple_boundary")' ); $sv = $q->multipart_init( -boundary => 'this_is_another_boundary' ); like($sv, qr/boundary="this_is_another_boundary"/, "multipart_init( -boundary => 'this_is_another_boundary')"); $sv = $q->multipart_init; my $sv2 = $q->multipart_init; isnt($sv,$sv2,"due to random boundaries, multiple calls produce different results");
From mark [...] summersault.com Mon Apr 2 10: 26:07 2012
MIME-Version: 1.0
X-Spam-Status: No, score=-3.8 tagged_above=-99.9 required=10 tests=[AWL=-2.565, BAYES_00=-1.9, SPF_SOFTFAIL=0.665] autolearn=no
In-Reply-To: <rt-3.8.HEAD-2604-1333211378-922.76189-4-0 [...] rt.cpan.org>
X-Spam-Flag: NO
References: <RT-Ticket-76189 [...] rt.cpan.org> <rt-3.8.HEAD-2604-1333211378-922.76189-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <4F79B6F4.3090400 [...] summersault.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
X-Spam-Score: -3.8
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id DE0022401FD for <cpan-bug+CGI.pm [...] hipster.bestpractical.com>; Mon, 2 Apr 2012 10:26:06 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9wuV8cZaaSBf for <cpan-bug+CGI.pm [...] hipster.bestpractical.com>; Mon, 2 Apr 2012 10:26:05 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 4BB4424001D for <bug-CGI.pm [...] rt.cpan.org>; Mon, 2 Apr 2012 10:26:04 -0400 (EDT)
Received: (qmail 17696 invoked by uid 103); 2 Apr 2012 14:26:04 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 2 Apr 2012 14:26:04 -0000
Received: from tanagra.summersault.com (HELO tanagra.summersault.com) (12.161.105.149) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Mon, 02 Apr 2012 07:26:01 -0700
Received: (qmail 26118 invoked from network); 2 Apr 2012 14:25:57 -0000
Received: from simba.summersault.com (HELO ?192.168.97.182?) (192.168.97.182) by tanagra.summersault.com with SMTP; 2 Apr 2012 14:25:57 -0000
Delivered-To: cpan-bug+CGI.pm [...] hipster.bestpractical.com
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120310 Thunderbird/11.0
Subject: Re: [rt.cpan.org #76189] Test script missing from CGI.pm CPAN distribution?
Return-Path: <mark [...] summersault.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+CGI.pm [...] hipster.bestpractical.com
X-RT-Mail-Extension: cgi.pm
Date: Mon, 02 Apr 2012 10:25:56 -0400
X-Spam-Level:
To: bug-CGI.pm [...] rt.cpan.org
X-Enigmail-Version: 1.4
Content-Transfer-Encoding: 7bit
From: Mark Stosberg <mark [...] summersault.com>
RT-Message-ID: <rt-3.8.HEAD-2606-1333376767-1292.76189-0-0 [...] rt.cpan.org>
Content-Length: 885
Download (untitled) / with headers
text/plain 885b
Show quoted text
> I have noticed that a change was applied to perl (maint-5.12) in Jan > 2011 which modified CGI.pm itself and added two new test scripts: > headers.t and multipart_init.t: > > http://perl5.git.perl.org/perl.git/commit/b7fa2aca51 > > The first two changes do seem to have found their way back to the CGI.pm > CPAN distro, but the latter change -- the addition of multipart_init.t > -- appears to have been missed. > > I've checked through every CPAN release from 3.48 through 3.59 and don't > see it anywhere, despite the Changes file for 3.52 claiming to have > fixed a logic error in it! > > The current bleadperl version is attached. Could you please consider > including it (or a later version if you have one, perhaps including > whatever fixes 3.52's Changes file was referring to?) in future releases.
Thanks for the report. I'll see about making this consistent. Mark
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-12395-1345080219-753.76189-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 38
This is being released today. Thanks.
From Steve.Hay [...] verosoftware.com Thu Aug 16 04: 27:25 2012
CC: <perl5-porters [...] perl.org>
MIME-Version: 1.0
X-Spam-Status: No, score=-6.121 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-12395-1345080219-1937.76189-6-0 [...] rt.cpan.org>
Content-Class: urn:content-classes:message
X-Spam-Flag: NO
References: <RT-Ticket-76189 [...] rt.cpan.org> <rt-3.8.HEAD-12395-1345080219-1937.76189-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Virus-Scanned: by SpamTitan at planit.com
Content-Type: text/plain; charset="utf-8"
Message-ID: <1B32FF956ABF414C9BCE5E487A1497E70E20D801 [...] ukmail02.planit.group>
X-MS-Tnef-Correlator:
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.121
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 4661D240737 for <cpan-bug+CGI.pm [...] hipster.bestpractical.com>; Thu, 16 Aug 2012 04:27:25 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LsaVyz14FgWE for <cpan-bug+CGI.pm [...] hipster.bestpractical.com>; Thu, 16 Aug 2012 04:27:23 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 4BEC2240698 for <bug-CGI.pm [...] rt.cpan.org>; Thu, 16 Aug 2012 04:27:22 -0400 (EDT)
Received: (qmail 29630 invoked by uid 103); 16 Aug 2012 08:27:22 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 16 Aug 2012 08:27:22 -0000
Received: from ns1.planit.com (HELO mailgate.planit.com) (213.1.249.253) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Thu, 16 Aug 2012 01:27:18 -0700
Received: from mailgate.planit.com (localhost [127.0.0.1]) by mailgate.planit.com (Postfix) with ESMTP id 7E5FB43ED1C; Thu, 16 Aug 2012 09:27:15 +0100 (BST)
Received: from ukmail02.planit.group (ukmail02.planit.com [10.20.200.12]) by mailgate.planit.com (Postfix) with ESMTP id F315D43EC45; Thu, 16 Aug 2012 09:27:14 +0100 (BST)
Delivered-To: cpan-bug+CGI.pm [...] hipster.bestpractical.com
Subject: RE: [rt.cpan.org #76189] Test script missing from CGI.pm CPAN distribution?
Return-Path: <Steve.Hay [...] verosoftware.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+CGI.pm [...] hipster.bestpractical.com
X-RT-Mail-Extension: cgi.pm
Thread-Index: Ac17TdDz/DzPQPSiTXO4iGyzuUE3SwAOvrVQ
Date: Thu, 16 Aug 2012 09:26:50 +0100
X-Spam-Level:
X-MS-Has-Attach:
Thread-Topic: [rt.cpan.org #76189] Test script missing from CGI.pm CPAN distribution?
X-Mimeole: Produced By Microsoft Exchange V6.5
To: <bug-CGI.pm [...] rt.cpan.org>, <shay [...] cpan.org>
Content-Transfer-Encoding: base64
From: "Steve Hay" <Steve.Hay [...] verosoftware.com>
RT-Message-ID: <rt-3.8.HEAD-19848-1345105646-1128.76189-0-0 [...] rt.cpan.org>
Content-Length: 194
Download (untitled) / with headers
text/plain 194b
MARKSTOS via RT wrote on 2012-08-16: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=76189 > > > This is being released today. Thanks.
Thanks, merged into blead in commit a506842e80.
X-RT-Interface: REST
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
RT-Message-ID: <rt-4.0.18-25657-1400760821-919.76189-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 240
Download (untitled) / with headers
text/plain 240b
This issue has been copied to: https://github.com/leejo/CGI.pm/issues/97 please take all future correspondence there. This ticket will remain open but please do not reply here. This ticket will be closed when the github issue is dealt with.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-8492-1405084339-1716.76189-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 52
Closing as already resolved as per previous comments


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.