Bug #75887 for Chart: scalar_png broken with release 2.4.4

# Mon Mar 19 15:29:32 2012 bdiss [...] flr.follett.com - Ticket created

From BDiss [...] flr.follett.com Mon Mar 19 15:	29:31 2012
X-Originalarrivaltime:	19 Mar 2012 19:29:03.0765 (UTC) FILETIME=[8B252450:01CD0606]
MIME-Version:	1.0
X-Spam-Status:	No, score=-0.069 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=0.001, RCVD_NUMERIC_HELO=1.164, SPF_SOFTFAIL=0.665] autolearn=no
X-Spam-Flag:	NO
X-Virus-Checked:	Checked by ClamAV on 16.mx.develooper.com
Content-Type:	multipart/alternative; boundary="B_3415012142_4113050"
Message-ID:	<CB8CF32E.9F57%bdiss [...] flr.follett.com>
X-Virus-Scanned:	Debian amavisd-new at bestpractical.com
X-Spam-Score:	-0.069
Received:	from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 1E30B240246 for <cpan-bug+Chart [...] hipster.bestpractical.com>; Mon, 19 Mar 2012 15:29:31 -0400 (EDT)
Received:	from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T27WdTOBO021 for <cpan-bug+Chart [...] hipster.bestpractical.com>; Mon, 19 Mar 2012 15:29:28 -0400 (EDT)
Received:	from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id EEE3424001D for <bug-Chart [...] rt.cpan.org>; Mon, 19 Mar 2012 15:29:27 -0400 (EDT)
Received:	(qmail 29205 invoked by uid 103); 19 Mar 2012 19:29:27 -0000
Received:	from x16.dev (10.0.100.26) by x1.dev with QMQP; 19 Mar 2012 19:29:27 -0000
Received:	from smtpob-wr01.follett.com (HELO smtpob-wr01.follett.com) (12.171.92.72) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Mon, 19 Mar 2012 12:29:23 -0700
Received:	from RGXXCRPEXMB01.follett.com (172.26.102.193) by WRXXENTEXMB01.na.follett.lan (172.26.92.160) with Microsoft SMTP Server id 14.1.355.2; Mon, 19 Mar 2012 14:29:20 -0500
Received:	from host3130.follett.com ([172.28.0.108]) by RGXXCRPEXMB01.follett.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 19 Mar 2012 14:29:03 -0500
Received:	from 192.217.227.162 ([192.217.227.162]) by mhflflrexmb01.na.follett.lan ([172.28.0.108]) with Microsoft Exchange Server HTTP-DAV ; Mon, 19 Mar 2012 19:29:03 +0000
Delivered-To:	cpan-bug+Chart [...] hipster.bestpractical.com
User-Agent:	Microsoft-Entourage/12.32.0.111121
Subject:	scalar_png broken with release 2.4.4
Return-Path:	<BDiss [...] flr.follett.com>
Thread-Index:	Ac0GBooXIecChVdUOkeOPbhhakfcZA==
X-RT-Mail-Extension:	chart
X-Original-To:	cpan-bug+Chart [...] hipster.bestpractical.com
X-Spam-Check-BY:	16.mx.develooper.com
Date:	Mon, 19 Mar 2012 14:29:02 -0500
X-Spam-Level:
Thread-Topic:	scalar_png broken with release 2.4.4
To:	<bug-Chart [...] rt.cpan.org>
From:	"Diss, Bob" <bdiss [...] flr.follett.com>
Content-Length:	0

content-type:	text/plain; charset="utf-8"
Content-Transfer-Encoding:	quoted-printable
X-RT-Original-Encoding:	ISO-8859-1
Content-Length:	408

Download (untitled) / with headers
text/plain 408b

Hello there. Prior to release 2.4.4, the scalar_png method returned the PNG image data as a scalar. This was changed at 2.4.4 to return the constant ³1². This change breaks existing code which expect to receive the image data as the return value of this method. Note that the scalar_jpeg method was not changed -- it still returns the JPEG image data as a scalar. Thanks for investigating this issue.

content-type:	text/html; charset="utf-8"
Content-Transfer-Encoding:	quoted-printable
X-RT-Original-Encoding:	ISO-8859-1
Content-Length:	638

Download (untitled) / with headers
text/html 638b

# Mon Mar 19 17:37:28 2012 fschlich [...] zedat.fu-berlin.de - Correspondence added

MIME-Version:	1.0
In-Reply-To:	<CB8CF32E.9F57%bdiss [...] flr.follett.com>
X-Mailer:	MIME-tools 5.427 (Entity 5.427)
Content-Disposition:	inline
References:	<CB8CF32E.9F57%bdiss [...] flr.follett.com>
Content-Type:	text/plain; charset="UTF-8"
Message-ID:	<rt-3.8.HEAD-10810-1332193048-473.75887-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding:	binary
From:	fschlich [...] zedat.fu-berlin.de
X-RT-Original-Encoding:	utf-8
Content-Length:	994

Download (untitled) / with headers
text/plain 994b

Hi, I was just about to report the very same issue :-) Here's a patch that we're going to add in the Debian package: --- a/Chart/Base.pm +++ b/Chart/Base.pm @@ -481,7 +481,7 @@ # this method invokes all my private methods to actually # draw the chart and plot the data # @param[in] $dataref Reference to the data to be plotted -# @return Status of the plot +# @return png image as a scalar value sub scalar_png { my $self = shift; @@ -502,8 +502,7 @@ # returns the png image as a scalar value, so that # the programmer/user can do whatever the she/he wants to with it - $self->{'gd_obj'}->png(); - return 1; + return $self->{'gd_obj'}->png(); } ## @method int jpeg($file,$dataref) scalar_png() and scalar_jpeg() aren't documented very well (they are in doxygen, but not mentioned in pod), they lack a test etc. If you're willing to take a more comprehensive patch, I can work on one. BTW this issue breaks Jifty::Plugin::Chart, see RT#75591 Florian

# Mon Mar 19 17:37:30 2012 The RT System itself - Status changed from 'new' to 'open'

# Tue Mar 20 05:04:00 2012 dassing [...] fs.wettzell.de - Correspondence added

From dassing [...] fs.wettzell.de Tue Mar 20 05:	03:59 2012
MIME-Version:	1.0
X-Spam-Status:	No, score=-1.899 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, UNPARSEABLE_RELAY=0.001] autolearn=ham
In-Reply-To:	<rt-3.8.HEAD-10810-1332193049-210.75887-5-0 [...] rt.cpan.org>
X-Spam-Flag:	NO
X-FS-Wettzell-Mailscanner:	Found to be clean
References:	<RT-Ticket-75887 [...] rt.cpan.org> <CB8CF32E.9F57%bdiss [...] flr.follett.com> <rt-3.8.HEAD-10810-1332193049-210.75887-5-0 [...] rt.cpan.org>
X-Virus-Scanned:	Debian amavisd-new at bestpractical.com
Message-ID:	<4F6847B5.5080006 [...] fs.wettzell.de>
Reply-To:	dassing [...] fs.wettzell.de
Content-Type:	text/plain; charset=UTF-8; format=flowed
Organization:	BKG-Wettzell
X-RT-Original-Encoding:	utf-8
X-Spam-Score:	-1.899
Received:	from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 7AAE224028A for <cpan-bug+Chart [...] hipster.bestpractical.com>; Tue, 20 Mar 2012 05:03:59 -0400 (EDT)
Received:	from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ihw0cPLwaR1g for <cpan-bug+Chart [...] hipster.bestpractical.com>; Tue, 20 Mar 2012 05:03:56 -0400 (EDT)
Received:	from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 7616324001D for <bug-Chart [...] rt.cpan.org>; Tue, 20 Mar 2012 05:03:56 -0400 (EDT)
Received:	(qmail 30896 invoked by uid 103); 20 Mar 2012 09:03:55 -0000
Received:	from x16.dev (10.0.100.26) by x1.dev with QMQP; 20 Mar 2012 09:03:55 -0000
Received:	from gate2-w.bkg.bund.de (HELO gate2-w.wettzell.ifag.de) (141.74.1.71) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Tue, 20 Mar 2012 02:03:52 -0700
Received:	from gate2-w.wettzell.ifag.de (localhost [127.0.0.1]) by gate2-w.wettzell.ifag.de (8.14.3/8.14.3) with ESMTP id q2K93mlf017797 for <bug-Chart [...] rt.cpan.org>; Tue, 20 Mar 2012 09:03:48 GMT
Received:	(from localhost) by gate2-w.wettzell.ifag.de (MSCAN) id 3/gate2-w.wettzell.ifag.de/smtp-gw/mscan; Tue Mar 20 09:03:48 2012
Delivered-To:	cpan-bug+Chart [...] hipster.bestpractical.com
User-Agent:	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120312 Thunderbird/11.0
Subject:	Re: [rt.cpan.org #75887] scalar_png broken with release 2.4.4
X-FS-Wettzell-Mailscanner-Spamcheck:	not spam, SpamAssassin (Wertung=-18.796, benoetigt 6, AWL -7.20, BAYES_00 -4.90, BODY_UNLIKELYCHAR02 0.20, FROM_FS_WETTZELL_DE -10.00, NUMBERSIGN 0.20, SUBJ_MISSTYPES 0.50, SUBJ_UNLIKELYCHARS01 0.50, SUBJ_UNLIKELYCHARS02 0.50, SUBJ_UNLIKELYCHARS03 0.50, SUBJ_UNLIKELYCHARS06 0.20, URI_GAMES99 0.70)
Return-Path:	<dassing [...] fs.wettzell.de>
X-FS-Wettzell-Mailscanner-Information:	Please contact the ISP for more information
X-Spam-Check-BY:	16.mx.develooper.com
X-Original-To:	cpan-bug+Chart [...] hipster.bestpractical.com
X-RT-Mail-Extension:	chart
Date:	Tue, 20 Mar 2012 10:02:45 +0100
X-Spam-Level:
To:	bug-Chart [...] rt.cpan.org
Content-Transfer-Encoding:	7bit
From:	Reiner Dassing <dassing [...] fs.wettzell.de>
RT-Message-ID:	<rt-3.8.HEAD-10813-1332234240-1090.75887-0-0 [...] rt.cpan.org>
Content-Length:	1651

Download (untitled) / with headers
text/plain 1.6k

Hi, thanks for your patch. I will release version 2.4.5 within the next days. Show quoted text

> scalar_png() and scalar_jpeg() aren't documented very well (they are in > doxygen, but not mentioned in pod), they lack a test etc. If you're > willing to take a more comprehensive patch, I can work on one.

Any help for improving the module is very welcome. (As I am alone and doing this work during some off hours any help is appreciated.) Thanks Reiner Am 19.03.2012 22:37, schrieb Florian via RT: Show quoted text

> Queue: Chart > Ticket<URL: https://rt.cpan.org/Ticket/Display.html?id=75887> > > Hi, > > I was just about to report the very same issue :-) > Here's a patch that we're going to add in the Debian package: > > --- a/Chart/Base.pm > +++ b/Chart/Base.pm > @@ -481,7 +481,7 @@ > # this method invokes all my private methods to actually > # draw the chart and plot the data > # @param[in] $dataref Reference to the data to be plotted > -# @return Status of the plot > +# @return png image as a scalar value > sub scalar_png > { > my $self = shift; > @@ -502,8 +502,7 @@ > > # returns the png image as a scalar value, so that > # the programmer/user can do whatever the she/he wants to with it > - $self->{'gd_obj'}->png(); > - return 1; > + return $self->{'gd_obj'}->png(); > } > > ## @method int jpeg($file,$dataref) > > > scalar_png() and scalar_jpeg() aren't documented very well (they are in > doxygen, but not mentioned in pod), they lack a test etc. If you're > willing to take a more comprehensive patch, I can work on one. > > BTW this issue breaks Jifty::Plugin::Chart, see RT#75591 > > Florian > >