Skip Menu |
 

This queue is for tickets about the Crypt-X509 CPAN distribution.

Report information
The Basics
Id: 74887
Status: new
Priority: 0/
Queue: Crypt-X509

People
Owner: Nobody in particular
Requestors: tvidas [...] cmu.edu
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.51
Fixed in: (no value)



Subject: certificate version should implicitly be v1 (integer 0)
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 1254
Download (untitled) / with headers
text/plain 1.2k
this bug causes $v to be undefined in certificates that do not specify a version. The perl error will be similar to: Use of uninitialized value $v in numeric eq (==) at /usr/local/share/perl5/Crypt/X509.pm line 152. when undefined in the certificate, "version" should return 0 and "version_string" should return "v1" below is a patch to add logic that will achieve this functionality. diff -Naur /usr/local/share/perl5/Crypt/X509.pm.old /usr/local/share/perl5/Crypt/X509.pm --- /usr/local/share/perl5/Crypt/X509.pm.old 2012-02-12 01:19:52.733624732 -0500 +++ /usr/local/share/perl5/Crypt/X509.pm 2012-02-12 01:21:08.994094646 -0500 @@ -137,7 +163,10 @@ sub version { my $self = shift; - return $self->{tbsCertificate}{version}; + if ( defined $self->{tbsCertificate}{version} ){ + return $self->{tbsCertificate}{version}; + } + return 0; } =head2 version_string @@ -148,7 +177,11 @@ sub version_string { my $self = shift; - my $v = $self->{tbsCertificate}{version}; + my $v = 0; + if ( defined $self->{tbsCertificate}{version} ){ + $v = $self->{tbsCertificate}{version}; + } + return "v1" if $v == 0; return "v2" if $v == 1; return "v3" if $v == 2;


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.