Skip Menu |
 

This queue is for tickets about the PAR-Dist CPAN distribution.

Report information
The Basics
Id: 73228
Status: new
Priority: 0/
Queue: PAR-Dist

People
Owner: Nobody in particular
Requestors: AJGB [...] cpan.org
RIVY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 0.47
  • 0.48
Fixed in: (no value)



Subject: verifying fails to remove temp dir
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1323774039-6890-250"
Content-Length: 0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 308
Download (untitled) / with headers
text/plain 308b
Hi, _verify_or_sign calls _unzip_to_tmpdir which chdir to temp directory, however changing back to previouse cwd is done after rmtree is called causing following error: cannot remove path when cwd is /tmp/parXXXXX for /tmp/parXXXXX: at /usr/local/nagios/perl/lib/PAR/Dist.pm Patch attached. Thanks, Alex
Subject: PAR-Dist-0.48.patch
MIME-Version: 1.0
Content-Type: text/x-patch; name="PAR-Dist-0.48.patch"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline; filename="PAR-Dist-0.48.patch"
Content-Transfer-Encoding: binary
Content-Length: 463
Download PAR-Dist-0.48.patch
text/x-diff 463b
diff -ru PAR-Dist-0.48-orig/lib/PAR/Dist.pm PAR-Dist-0.48/lib/PAR/Dist.pm --- PAR-Dist-0.48-orig/lib/PAR/Dist.pm 2011-11-05 11:00:28.000000000 +0000 +++ PAR-Dist-0.48/lib/PAR/Dist.pm 2011-12-13 10:52:51.424730433 +0000 @@ -1085,9 +1085,10 @@ my $rv = Module::Signature->can($action)->(%args); _zip(dist => $dist) if $action eq 'sign'; - File::Path::rmtree([$tmpdir]); chdir($cwd); + File::Path::rmtree([$tmpdir]); + return $rv; }


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.