Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 72380
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: MARKSTOS [...] cpan.org
Requestors: cberry [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 3.57
Fixed in: (no value)



Subject: [PATCH] url.t help for VMS
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1321074666-5677-2"
Content-Length: 0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 225
Download (untitled) / with headers
text/plain 225b
On VMS, %ENV as a whole cannot be localized and in fact any script that tries to do that won't even compile. The attached patch takes care of that problem for url.t by localizing each %ENV element of interest individually.
Subject: vms_cgi_url_t.patch
MIME-Version: 1.0
Content-Type: application/octet-stream; name="vms_cgi_url_t.patch"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline; filename="vms_cgi_url_t.patch"
Content-Transfer-Encoding: base64
Content-Length: 1554
Download vms_cgi_url_t.patch
text/x-diff 1.5k
--- t/url.t;-0 2011-11-09 16:31:14 -0600 +++ t/url.t 2011-11-11 22:58:04 -0600 @@ -25,20 +25,23 @@ is url() => 'http://proxy', 'url() with subtest 'rewrite_interactions' => sub { # Reference: RT#45019 - local %ENV = ( - # These two are always set - 'SCRIPT_NAME' => '/real/cgi-bin/dispatch.cgi', - 'SCRIPT_FILENAME' => '/home/mark/real/path/cgi-bin/dispatch.cgi', - - # These two are added by mod_rewrite Ref: http://httpd.apache.org/docs/2.2/mod/mod_rewrite.html - - 'SCRIPT_URL' => '/real/path/info', - 'SCRIPT_URI' => 'http://example.com/real/path/info', - - 'PATH_INFO' => '/path/info', - 'REQUEST_URI' => '/real/path/info', - 'HTTP_HOST' => 'example.com' - ); + local $ENV{HTTP_X_FORWARDED_HOST} = undef; + local $ENV{SERVER_PROTOCOL} = undef; + local $ENV{SERVER_PORT} = undef; + local $ENV{SERVER_NAME} = undef; + + # These two are always set + local $ENV{'SCRIPT_NAME'} = '/real/cgi-bin/dispatch.cgi'; + local $ENV{'SCRIPT_FILENAME'} = '/home/mark/real/path/cgi-bin/dispatch.cgi'; + + # These two are added by mod_rewrite Ref: http://httpd.apache.org/docs/2.2/mod/mod_rewrite.html + + local $ENV{'SCRIPT_URL'} = '/real/path/info'; + local $ENV{'SCRIPT_URI'} = 'http://example.com/real/path/info'; + + local $ENV{'PATH_INFO'} = '/path/info'; + local $ENV{'REQUEST_URI'} = '/real/path/info'; + local $ENV{'HTTP_HOST'} = 'example.com'; my $q = CGI->new;
From mark [...] summersault.com Tue Nov 15 10: 47:24 2011
MIME-Version: 1.0
X-Spam-Status: No, score=-6.562 tagged_above=-99.9 required=10 tests=[AWL=-0.327, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-5677-1321074667-38.72380-4-0 [...] rt.cpan.org>
X-Spam-Flag: NO
References: <RT-Ticket-72380 [...] rt.cpan.org> <rt-3.8.HEAD-5677-1321074667-38.72380-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <4EC28975.1090108 [...] summersault.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.562
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 8C615240D9B for <cpan-bug+cgi [...] hipster.bestpractical.com>; Tue, 15 Nov 2011 10:47:24 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aNZfTTTAm8Qx for <cpan-bug+cgi [...] hipster.bestpractical.com>; Tue, 15 Nov 2011 10:47:20 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id CF4E8240D12 for <bug-cgi [...] rt.cpan.org>; Tue, 15 Nov 2011 10:47:18 -0500 (EST)
Received: (qmail 25963 invoked by uid 103); 15 Nov 2011 15:47:18 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 15 Nov 2011 15:47:18 -0000
Received: from tanagra.summersault.com (HELO tanagra.summersault.com) (12.161.105.149) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Tue, 15 Nov 2011 07:47:13 -0800
Received: (qmail 36303 invoked from network); 15 Nov 2011 15:47:09 -0000
Received: from simba.summersault.com (192.168.97.182) by tanagra.summersault.com with SMTP; 15 Nov 2011 15:47:09 -0000
Delivered-To: cpan-bug+cgi [...] hipster.bestpractical.com
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1
Subject: Re: [rt.cpan.org #72380] [PATCH] url.t help for VMS
Return-Path: <mark [...] summersault.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+cgi [...] hipster.bestpractical.com
X-RT-Mail-Extension: cgi
Date: Tue, 15 Nov 2011 10:47:01 -0500
X-Spam-Level:
To: bug-cgi [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Mark Stosberg <mark [...] summersault.com>
RT-Message-ID: <rt-3.8.HEAD-6890-1321372045-377.72380-0-0 [...] rt.cpan.org>
Content-Length: 56
This looks fine. Thanks for the contribution. Mark
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-15962-1345079695-778.72380-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 32
Getting released today, thanks.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.