Skip Menu |
 

This queue is for tickets about the Apache-DB CPAN distribution.

Report information
The Basics
Id: 71853
Status: resolved
Priority: 0/
Queue: Apache-DB

People
Owner: Nobody in particular
Requestors: perlbug-comment [...] perl.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From rt-sprout=cpan.org [...] rt.perl.org Sat Oct 22 14: 56:30 2011
CC: perl5-porters [...] perl.org, zefram [...] fysh.org, rafl [...] debian.org, frank [...] wiles.org, rurban [...] x-ray.at, bug-Apache-DB [...] rt.cpan.org
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-31297-1318967574-359.101486-14-0 [...] perl.org>
X-Spam-Status: No, score=-7.488 tagged_above=-99.9 required=10 tests=[AWL=-0.588, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
X-Spam-Flag: NO
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
References: <RT-Ticket-101486 [...] perl.org> <4D5F7890-3215-4F85-9DCE-BA85DB7E7878 [...] cpan.org> <rt-3.6.HEAD-31297-1318941670-1853.101486-14-0 [...] perl.org> <aa51f07f-5725-4451-aebe-a6cfe9bb5cd6 [...] email.android.com> <CANgO38mQuLNw21tC5bH5p6nWUZHq44seVFZib4hj69zjFF_ZJQ [...] mail.gmail.com> <rt-3.6.HEAD-31297-1318967574-359.101486-14-0 [...] perl.org>
Content-Type: multipart/mixed; boundary="----------=_1319309782-31297-2412"
Message-ID: <rt-3.6.HEAD-31297-1319309782-1494.101486-14-0 [...] perl.org>
Reply-To: perlbug-comment [...] perl.org
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-RT-Original-Encoding: utf-8
RT-Originator: sprout [...] cpan.org
X-Spam-Score: -7.488
Managed-BY: RT 3.6.HEAD (http://www.bestpractical.com/rt/)
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 1B9392407D2 for <cpan-bug+Apache-DB [...] hipster.bestpractical.com>; Sat, 22 Oct 2011 14:56:30 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lfgzgo0nmHJG for <cpan-bug+Apache-DB [...] hipster.bestpractical.com>; Sat, 22 Oct 2011 14:56:28 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 48E0B24011E for <bug-Apache-DB [...] rt.cpan.org>; Sat, 22 Oct 2011 14:56:28 -0400 (EDT)
Received: (qmail 25513 invoked by uid 103); 22 Oct 2011 18:56:27 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 22 Oct 2011 18:56:27 -0000
Received: from x17.develooper.com (HELO x17.develooper.com) (207.171.7.217) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Sat, 22 Oct 2011 11:56:25 -0700
Received: by x17.develooper.com (Postfix, from userid 405) id 1AA5035BCF; Sat, 22 Oct 2011 11:56:23 -0700 (PDT)
Delivered-To: cpan-bug+Apache-DB [...] hipster.bestpractical.com
Subject: [perl #101486] PL_curstash should be refcounted
Return-Path: <rt-sprout=cpan.org [...] rt.perl.org>
X-RT-Mail-Extension: apache-db
X-Original-To: cpan-bug+Apache-DB [...] hipster.bestpractical.com
X-Spam-Check-BY: 16.mx.develooper.com
Date: Sat, 22 Oct 2011 11:56:22 -0700
RT-Ticket: perl #101486
X-Spam-Level:
Precedence: normal
To: "OtherRecipients of perl Ticket #101486":;
X-RT-Loop-Prevention: perl
From: "Father Chrysostomos via RT" <perlbug-comment [...] perl.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-RT-Original-Encoding: utf-8
Content-Length: 748
Download (untitled) / with headers
text/plain 748b
On Tue Oct 18 12:52:54 2011, frank@wiles.org wrote: Show quoted text
> I'm actually hoping to find new maintainers for my CPAN projects as I > no longer work in Perl. I'm happy to apply patches and put out a new > release if someone doesn't want to take over the maintainership > howeer.
I have a commit on the smoke-me/curstash branch (<http://perl5.git.perl.org/perl.git/shortlog/refs/heads/smoke-me/curstash>) that will be integrated into blead soon. Attached is a patch for Apache::DB. Not having a mod_perl environment set up, I can’t really test this, but I can confirm that it compiles. If you want to test it before release of 5.15.5 (i.e., before blead’s version number is bumped), you will have to tweak the version check to use 5.15.4 instead.
RT-Attachment: 101486/994496/487654
content-type: text/plain; charset="utf-8"; name="open_jInSkY7j.txt"
content-disposition: inline; filename="open_jInSkY7j.txt"
Content-Transfer-Encoding: 7bit
X-RT-Original-Encoding: utf-8
Content-Length: 1144
Download open_jInSkY7j.txt
text/plain 1.1k
diff -rup Apache-DB-0.14-yNQVbM/DB.xs Apache-DB-0.14-yNQVbM-copy/DB.xs --- Apache-DB-0.14-yNQVbM/DB.xs 2008-04-27 14:52:40.000000000 -0700 +++ Apache-DB-0.14-yNQVbM-copy/DB.xs 2011-10-22 11:44:37.000000000 -0700 @@ -6,10 +6,26 @@ #define SIGINT 2 #endif +#define HAVE_PERL(R, V, S) \ + (PERL_REVISION > (R) || ( \ + PERL_REVISION == (R) && ( \ + PERL_VERSION > (V) || ( \ + PERL_VERSION == (V) && PERL_SUBVERSION >= (S) \ + ) \ + ) \ + )) + +#if HAVE_PERL(5,15,5) +# define SET_CURSTASH(x) \ + (SvREFCNT_dec(PL_curstash), PL_curstash = SvREFCNT_inc(x)) +#else +# define SET_CURSTASH(x) (PL_curstash = (x)) +#endif + static void my_init_debugger() { dTHR; - PL_curstash = PL_debstash; + SET_CURSTASH(PL_debstash); PL_dbargs = GvAV(gv_AVadd((gv_fetchpv("DB::args", GV_ADDMULTI, SVt_PVAV)))); AvREAL_off(PL_dbargs); @@ -22,7 +38,7 @@ static void my_init_debugger() sv_setiv(PL_DBtrace, 0); PL_DBsignal = GvSV((gv_fetchpv("DB::signal", GV_ADDMULTI, SVt_PV))); sv_setiv(PL_DBsignal, 0); - PL_curstash = PL_defstash; + SET_CURSTASH(PL_defstash); }
From rt-sprout=cpan.org [...] rt.perl.org Sat Oct 22 19: 12:17 2011
CC: perl5-porters [...] perl.org, zefram [...] fysh.org, rafl [...] debian.org, frank [...] wiles.org, rurban [...] x-ray.at, bug-Apache-DB [...] rt.cpan.org
MIME-Version: 1.0
X-Spam-Status: No, score=-7.484 tagged_above=-99.9 required=10 tests=[AWL=-0.584, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-3.6.HEAD-31297-1319309782-1494.101486-14-0 [...] perl.org>
X-Spam-Flag: NO
References: <RT-Ticket-101486 [...] perl.org> <4D5F7890-3215-4F85-9DCE-BA85DB7E7878 [...] cpan.org> <rt-3.6.HEAD-31297-1318941670-1853.101486-14-0 [...] perl.org> <aa51f07f-5725-4451-aebe-a6cfe9bb5cd6 [...] email.android.com> <CANgO38mQuLNw21tC5bH5p6nWUZHq44seVFZib4hj69zjFF_ZJQ [...] mail.gmail.com> <rt-3.6.HEAD-31297-1318967574-359.101486-14-0 [...] perl.org> <rt-3.6.HEAD-31297-1319309782-1494.101486-14-0 [...] perl.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Reply-To: perlbug-comment [...] perl.org
Message-ID: <rt-3.6.HEAD-31297-1319325130-236.101486-14-0 [...] perl.org>
Content-Type: text/plain; charset="utf-8"
X-Spam-Score: -7.484
RT-Originator: sprout [...] cpan.org
X-RT-Original-Encoding: utf-8
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id B74C22407D2 for <cpan-bug+Apache-DB [...] hipster.bestpractical.com>; Sat, 22 Oct 2011 19:12:17 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fGNVTUOKYrM8 for <cpan-bug+Apache-DB [...] hipster.bestpractical.com>; Sat, 22 Oct 2011 19:12:16 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id D61F924011E for <bug-Apache-DB [...] rt.cpan.org>; Sat, 22 Oct 2011 19:12:15 -0400 (EDT)
Received: (qmail 9747 invoked by uid 103); 22 Oct 2011 23:12:15 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 22 Oct 2011 23:12:15 -0000
Received: from x17.develooper.com (HELO x17.develooper.com) (207.171.7.217) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Sat, 22 Oct 2011 16:12:13 -0700
Received: by x17.develooper.com (Postfix, from userid 405) id 59FB935BCF; Sat, 22 Oct 2011 16:12:11 -0700 (PDT)
Managed-BY: RT 3.6.HEAD (http://www.bestpractical.com/rt/)
Delivered-To: cpan-bug+Apache-DB [...] hipster.bestpractical.com
Subject: [perl #101486] PL_curstash should be refcounted [rt.cpan.org #71853]
Return-Path: <rt-sprout=cpan.org [...] rt.perl.org>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Apache-DB [...] hipster.bestpractical.com
X-RT-Mail-Extension: apache-db
Date: Sat, 22 Oct 2011 16:12:10 -0700
X-Spam-Level:
RT-Ticket: perl #101486
Precedence: normal
X-RT-Loop-Prevention: perl
To: "OtherRecipients of perl Ticket #101486":;
Content-Transfer-Encoding: 8bit
From: "Father Chrysostomos via RT" <perlbug-comment [...] perl.org>
RT-Message-ID: <rt-3.8.HEAD-2597-1319325138-336.71853-0-0 [...] rt.cpan.org>
Content-Length: 535
Download (untitled) / with headers
text/plain 535b
On Sat Oct 22 11:56:22 2011, sprout wrote: Show quoted text
> On Tue Oct 18 12:52:54 2011, frank@wiles.org wrote:
> > I'm actually hoping to find new maintainers for my CPAN projects as I > > no longer work in Perl. I'm happy to apply patches and put out a new > > release if someone doesn't want to take over the maintainership > > howeer.
> > I have a commit on the smoke-me/curstash branch >
(<http://perl5.git.perl.org/perl.git/shortlog/refs/heads/smoke-me/curstash>) Show quoted text
> that will be integrated into blead soon.
Now it is in, as commit 03d9f02.
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-31297-1319309782-1494.101486-14-0 [...] perl.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-101486 [...] perl.org> <4D5F7890-3215-4F85-9DCE-BA85DB7E7878 [...] cpan.org> <rt-3.6.HEAD-31297-1318941670-1853.101486-14-0 [...] perl.org> <aa51f07f-5725-4451-aebe-a6cfe9bb5cd6 [...] email.android.com> <CANgO38mQuLNw21tC5bH5p6nWUZHq44seVFZib4hj69zjFF_ZJQ [...] mail.gmail.com> <rt-3.6.HEAD-31297-1318967574-359.101486-14-0 [...] perl.org> <rt-3.6.HEAD-31297-1319309782-1494.101486-14-0 [...] perl.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-8668-1558885107-1146.71853-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 9
Is solved


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.