Skip Menu |
 

This queue is for tickets about the DBIx-SearchBuilder CPAN distribution.

Report information
The Basics
Id: 70970
Status: new
Priority: 0/
Queue: DBIx-SearchBuilder

People
Owner: Nobody in particular
Requestors: Ruslan.Zakirov [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From ruslan.zakirov [...] gmail.com Wed Sep 14 16: 01:01 2011
CC: jean-pierre.rupp [...] jpmchase.com
MIME-Version: 1.0
In-Reply-To: <B06DBD3096333D4091C88AEB6599207B060C9B0204 [...] EMBACMS102.exchad.jpmchase.net>
X-Spam-Status: No, score=-4.394 tagged_above=-99.9 required=10 tests=[AWL=1.816, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779, T_TO_NO_BRKTS_FREEMAIL=0.01] autolearn=ham
X-Spam-Flag: NO
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
References: <B06DBD3096333D4091C88AEB6599207B060C9B0204 [...] EMBACMS102.exchad.jpmchase.net>
Content-Type: multipart/mixed; boundary=000e0cdf1af2a0cf1b04acec3701
Message-ID: <CAMOxC8vuF-0dLHUws_hFWB33nEBzsqGJ0N8oyb7JBtq4CrfQqQ [...] mail.gmail.com>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -4.394
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 5C5CD2408E7 for <cpan-bug+DBIx-SearchBuilder [...] hipster.bestpractical.com>; Wed, 14 Sep 2011 16:01:01 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TPnzqyJ8Z2aJ for <cpan-bug+DBIx-SearchBuilder [...] hipster.bestpractical.com>; Wed, 14 Sep 2011 16:00:59 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 327B62405B0 for <bug-DBIx-SearchBuilder [...] rt.cpan.org>; Wed, 14 Sep 2011 16:00:59 -0400 (EDT)
Received: (qmail 4972 invoked by uid 103); 14 Sep 2011 20:00:58 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 14 Sep 2011 20:00:58 -0000
Received: from mail-yw0-f50.google.com (HELO mail-yw0-f50.google.com) (209.85.213.50) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Wed, 14 Sep 2011 13:00:55 -0700
Received: by ywm13 with SMTP id 13so1629763ywm.9 for <bug-DBIx-SearchBuilder [...] rt.cpan.org>; Wed, 14 Sep 2011 13:00:52 -0700 (PDT)
Received: by 10.150.14.17 with SMTP id 17mr407525ybn.449.1316030452387; Wed, 14 Sep 2011 13:00:52 -0700 (PDT)
Received: by 10.150.54.12 with HTTP; Wed, 14 Sep 2011 13:00:52 -0700 (PDT)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Delivered-To: cpan-bug+DBIx-SearchBuilder [...] hipster.bestpractical.com
Subject: Fwd: Patch for DBIx::SearchBuilder - Support for limits in Sybase
Return-Path: <ruslan.zakirov [...] gmail.com>
X-RT-Mail-Extension: dbix-searchbuilder
X-Original-To: cpan-bug+DBIx-SearchBuilder [...] hipster.bestpractical.com
X-Spam-Check-BY: 16.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9F4xhJENp9Cjl4XALCeUO2fwP9gavP4reMpaJ1CSMrQ=; b=fenp1m18WV2pkqskONmcFYeSSUpHWQkP/Trou72pOcJTQF9vD0uJoULzgLB1I/i8XI vQFppEwDsGBK113Fl+T92rGoUcsfLd5hvFAM5x7NTH/iOMmBrUzNSoY5v4YHLCYXE2yO Ied7zQmH8Nfn7KOxEQU4OE28nFsBSpMX5Pf6k=
Date: Thu, 15 Sep 2011 00:00:52 +0400
X-Spam-Level:
To: bug-DBIx-SearchBuilder [...] rt.cpan.org
From: Ruslan Zakirov <ruslan.zakirov [...] gmail.com>
Content-Length: 0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 3003
Download (untitled) / with headers
text/plain 2.9k
Hi, Thanks for the patch. Forwarding it to SB's queue on rt.cpan.org. Wonder if a VirtualBox image exists with some sybase server to test SB against it? Show quoted text
---------- Forwarded message ---------- From: Rupp, Jean-Pierre <jean-pierre.rupp@jpmchase.com> Date: 2011/9/14 Subject: Patch for DBIx::SearchBuilder - Support for limits in Sybase To: "Ruslan.Zakirov@gmail.com" <Ruslan.Zakirov@gmail.com> Hello Руслан, I’ve modified your code for DBIx::SearchBuilder, in order to make ApplyLimits work in Sybase databases. This fix may also work for MSSQL as well. Support is partial, since Sybase doesn’t allow for specifying lower boundaries with its TOP clause. This said, what the code does is that whenever limits are used, it will slap a TOP clause just after SELECT in the query. This makes it so that Sybase will only return up to that many records. Then there’s a soft low boundary in the SearchBuilder object that will behave as though records before it were not retrieved (but they were). Although this will not offer much of a performance boost when retrieving records 950.000 to 975.000 in a 1.000.000 record table, performance will improve a lot for the first pages, which are the ones most commonly used in, say, web applications. On top of this, it makes for better RTT compatibility. I submit this patch to you so you can put it in the official DBIx::SearchBuilder distribution as you please. Greetings. This communication is for informational purposes only. It is not intended as an offer or solicitation for the purchase or sale of any financial instrument or as an official confirmation of any transaction. All market prices, data and other information are not warranted as to completeness or accuracy and are subject to change without notice. Any comments or statements made herein do not necessarily reflect those of JPMorgan Chase & Co., its subsidiaries and affiliates. This transmission may contain information that is privileged, confidential, legally privileged, and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. Although this transmission and any attachments are believed to be free of any virus or other defect that might affect any computer system into which it is received and opened, it is the responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by JPMorgan Chase & Co., its subsidiaries and affiliates, as applicable, for any loss or damage arising in any way from its use. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you. Please refer to http://www.jpmorgan.com/pages/disclosures for disclosures relating to European legal entities. -- Best regards, Ruslan.
X-Attachment-ID: 57447647574994a9_0.1
content-type: application/octet-stream; name="DBIx-SearchBuilder.patch"
content-disposition: attachment; filename="DBIx-SearchBuilder.patch"
Content-Transfer-Encoding: base64
Content-Length: 4630

Message body is not shown because sender requested not to inline it.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.