| From salvatore.bonaccorso [...] gmail.com Fri Aug 5 14: | 06:40 2011 |
| X-Virus: | Hi! I am a header virus! Copy me into yours an join the fun! |
| MIME-Version: | 1.0 |
| X-Spam-Status: | No, score=-6.73 tagged_above=-99.9 required=10 tests=[AWL=-0.620, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779, T_TO_NO_BRKTS_FREEMAIL=0.01] autolearn=ham |
| Content-Disposition: | inline |
| X-Spam-Flag: | NO |
| X-Virus-Checked: | Checked by ClamAV on 16.mx.develooper.com |
| X-Operating-System: | Debian GNU/Linux |
| Content-Type: | multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7" |
| Message-ID: | <20110805180629.GA30561 [...] elende.valinor.li> |
| X-Virus-Scanned: | Debian amavisd-new at bestpractical.com |
| X-Spam-Score: | -6.73 |
| Received: | from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 38E2B24072A for <cpan-bug+Data-Serializer [...] hipster.bestpractical.com>; Fri, 5 Aug 2011 14:06:40 -0400 (EDT) |
| Received: | from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pq1cVYbFvGUh for <cpan-bug+Data-Serializer [...] hipster.bestpractical.com>; Fri, 5 Aug 2011 14:06:38 -0400 (EDT) |
| Received: | from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 7B62A240529 for <bug-Data-Serializer [...] rt.cpan.org>; Fri, 5 Aug 2011 14:06:38 -0400 (EDT) |
| Received: | (qmail 27802 invoked by uid 103); 5 Aug 2011 18:06:37 -0000 |
| Received: | from x16.dev (10.0.100.26) by x1.dev with QMQP; 5 Aug 2011 18:06:37 -0000 |
| Received: | from mail-fx0-f50.google.com (HELO mail-fx0-f50.google.com) (209.85.161.50) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Fri, 05 Aug 2011 11:06:34 -0700 |
| Received: | by fxh2 with SMTP id 2so2386246fxh.9 for <bug-Data-Serializer [...] rt.cpan.org>; Fri, 05 Aug 2011 11:06:31 -0700 (PDT) |
| Received: | by 10.223.72.80 with SMTP id l16mr3285082faj.33.1312567591147; Fri, 05 Aug 2011 11:06:31 -0700 (PDT) |
| Received: | from elende (elende.valinor.li [188.40.94.203]) by mx.google.com with ESMTPS id n27sm2133562faa.4.2011.08.05.11.06.29 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 05 Aug 2011 11:06:30 -0700 (PDT) |
| Authentication-Results: | hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com |
| Delivered-To: | cpan-bug+Data-Serializer [...] hipster.bestpractical.com |
| User-Agent: | Mutt/1.5.21 (2010-09-15) |
| Subject: | use Digest::SHA even for sha1 digest |
| Return-Path: | <salvatore.bonaccorso [...] gmail.com> |
| X-RT-Mail-Extension: | data-serializer |
| X-Original-To: | cpan-bug+Data-Serializer [...] hipster.bestpractical.com |
| X-Spam-Check-BY: | 16.mx.develooper.com |
| Dkim-Signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:mime-version:content-type :content-disposition:x-opensource:x-virus:x-operating-system :x-pgp-key:user-agent; bh=ubEuc3FjVx2Pm8N5LqbXWo6YI94edo6PLvkTlJuPIOI=; b=VNfZ47+fhIJsltjv8xtRsw0LGJRdS1s9qE5M3DRQz7PjyxqkAlny6KvyavDIjP2ovL m1nUrGaRFrEryXHzNgbdfhvzgnu7r80HPFuOvmmQp+305zjG5/MHKL4cqJC529GNk1Dp +VK9g2RZOrPcNl1vNTFKw32plAl1Sc2bBpjeM= |
| X-PGP-Key: | http://people.debian.org/~carnil/0x7FD863FE.asc |
| Sender: | Salvatore Bonaccorso <salvatore.bonaccorso [...] gmail.com> |
| Date: | Fri, 5 Aug 2011 20:06:29 +0200 |
| X-Spam-Level: | |
| X-Opensource: | Have a lot of fun! |
| To: | bug-Data-Serializer [...] rt.cpan.org |
| From: | Salvatore Bonaccorso <carnil [...] cpan.org> |
| Content-Length: | 0 |
| Content-Type: | multipart/mixed; boundary="Qxx1br4bt0+wmkIi" |
| Content-Disposition: | inline |
| Content-Length: | 0 |
| content-type: | text/plain; charset="utf-8" |
| Content-Disposition: | inline |
| Content-Transfer-Encoding: | quoted-printable |
| X-RT-Original-Encoding: | us-ascii |
| Content-Length: | 592 |
Hi
Attached patch changes the module to use Digest::SHA instead of
Digest::SHA1. Digest::SHA is part of the standard perl distribution
since perl v5.9.3 so this reduces the number of external
dependencies by one.
Please consider applying it for the next release.
With this change, it will still be possible to use SHA1, as
Digest::SHA defaults to SHA-1. Do you agree on the change? It would be
great to get rid of the Digest::SHA1 "dependency".
Regards,
Salvatore
| Content-Type: | text/x-diff; charset=us-ascii |
| content-disposition: | attachment; filename="use-Digest-SHA.patch" |
| Content-Transfer-Encoding: | quoted-printable |
| X-RT-Original-Encoding: | us-ascii |
| Content-Length: | 754 |
Message body is not shown because sender requested not to inline it.
| Content-Description: | Digital signature |
| content-type: | application/pgp-signature; name="signature.asc" |
| Content-Length: | 836 |
Message body not shown because it is not plain text.