This queue is for tickets about the Lyrics-Fetcher-LyricWiki CPAN distribution.

Report information
The Basics
Id:
70008
Status:
open
Priority:
Low/Low

People
Owner:
Nobody in particular
Requestors:
DUMB [...] cpan.org
Cc:
AdminCc:

BugTracker
Severity:
Normal
Broken in:
0.10
Fixed in:
(no value)



Subject: Track names with multiple spaces
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 361
If a track name (maybe artist too) contains more than one space the lyrics are not fetched. Also & signs need encoding to %26, haven't come across any others that need encoding yet. As a fix: lyricwiki.pm: line 68 my $url = join ':', map { s/\s+/_/g; $_ } ($artist, $song); $url =~ s/&/%26/g; #also encode & (might be others) Thanks for the great module.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-12435-1312544353-1173.70008-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 837
On 2011-08-04 00:56:15, DUMB wrote:
Show quoted text
> If a track name (maybe artist too) contains more than one space the > lyrics are not fetched.
This seems odd to me - the test script requests "Cast No Shadow" by Oasis, that contains more than one space so that should have triggered the bug.
Show quoted text
> Also & signs need encoding to %26, haven't come > across any others that need encoding yet.
Yeah, that makes sense - I'll make use of URI::Escape to handle it, I think, so I know it's all done correctly.
Show quoted text
> As a fix: > > lyricwiki.pm: line 68 > > my $url = join ':', map { s/\s+/_/g; $_ } ($artist, $song);
That looks like a sane change; I'll want to see the test suite fail on artists/titles with multiple spaces first, then verify that that change fixes it. Hopefully I'll get a chance to do that tonight, then get a new version out. Cheers!
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-12435-1312544353-1173.70008-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <rt-3.8.HEAD-12435-1312544353-1173.70008-0-0@rt.cpan.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-22517-1312656970-1341.70008-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 345
Show quoted text
> > That looks like a sane change; I'll want to see the test suite fail on > artists/titles with multiple spaces first, then verify that that change > fixes it. Hopefully I'll get a chance to do that tonight, then get a > new version out. > > Cheers!
Try this track: 'Radiohead', 'A Punchup At A Wedding. (No No No No No No No No.)' Thanks


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.