Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the MooseX-Storage CPAN distribution.

Report information
The Basics
Id: 69811
Status: resolved
Priority: 0/
Queue: MooseX-Storage

People
Owner: Nobody in particular
Requestors: CARNIL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From salvatore.bonaccorso [...] gmail.com Tue Jul 26 04: 57:05 2011
X-Virus: Hi! I am a header virus! Copy me into yours an join the fun!
MIME-Version: 1.0
X-Spam-Status: No, score=-6.744 tagged_above=-99.9 required=10 tests=[AWL=-0.634, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779, T_TO_NO_BRKTS_FREEMAIL=0.01] autolearn=ham
Content-Disposition: inline
X-Spam-Flag: NO
X-Operating-System: Debian GNU/Linux
content-type: text/plain; charset="utf-8"
Message-ID: <20110726085654.GA8568 [...] elende>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -6.744
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id E70B52405B0 for <cpan-bug+MooseX-Storage [...] hipster.bestpractical.com>; Tue, 26 Jul 2011 04:57:04 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TfvLX5JPtNTe for <cpan-bug+MooseX-Storage [...] hipster.bestpractical.com>; Tue, 26 Jul 2011 04:57:03 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 29D372405AE for <bug-MooseX-Storage [...] rt.cpan.org>; Tue, 26 Jul 2011 04:57:02 -0400 (EDT)
Received: (qmail 11158 invoked by uid 103); 26 Jul 2011 08:57:02 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 26 Jul 2011 08:57:02 -0000
Received: from mail-ey0-f174.google.com (HELO mail-ey0-f174.google.com) (209.85.215.174) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Tue, 26 Jul 2011 01:56:59 -0700
Received: by eyx24 with SMTP id 24so317120eyx.5 for <bug-MooseX-Storage [...] rt.cpan.org>; Tue, 26 Jul 2011 01:56:56 -0700 (PDT)
Received: by 10.14.98.137 with SMTP id v9mr2133848eef.134.1311670616249; Tue, 26 Jul 2011 01:56:56 -0700 (PDT)
Received: from elende (elende.valinor.li [188.40.94.203]) by mx.google.com with ESMTPS id y46sm193558eea.64.2011.07.26.01.56.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 26 Jul 2011 01:56:55 -0700 (PDT)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Delivered-To: cpan-bug+MooseX-Storage [...] hipster.bestpractical.com
User-Agent: Mutt/1.5.20 (2009-06-14)
Subject: No need to depend on Digest::SHA1
Return-Path: <salvatore.bonaccorso [...] gmail.com>
X-RT-Mail-Extension: moosex-storage
X-Original-To: cpan-bug+MooseX-Storage [...] hipster.bestpractical.com
X-Spam-Check-BY: 16.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:mime-version:content-type :content-disposition:x-opensource:x-virus:x-operating-system :x-pgp-key:user-agent; bh=78c/z3qKDXoai2We6LYOTrWsJIjWL4AxpV3lKq9xcrs=; b=FOt7uyPQDTXviM+fLofJtNxXuxU/hNDhjjrM/iL++n3j0NJnUrVqEcVTaaUf6FUcQW NUQ6UbrJP3Lsgxh8OzBRdWX72EA4E7gte7xWpRVNduOMsE9SZpGUrGoD+6uQE9GoEYdQ UPTwRKhm7HXo1zlb+OVx8vINoevIQY1jRM/Ao=
X-PGP-Key: http://people.debian.org/~carnil/0x7FD863FE.asc
Sender: Salvatore Bonaccorso <salvatore.bonaccorso [...] gmail.com>
Date: Tue, 26 Jul 2011 10:56:54 +0200
X-Spam-Level:
X-Opensource: Have a lot of fun!
To: bug-MooseX-Storage [...] rt.cpan.org
From: Salvatore Bonaccorso <carnil [...] cpan.org>
X-RT-Original-Encoding: us-ascii
Content-Length: 498
Download (untitled) / with headers
text/plain 498b
Hi Digest::HMAC changed to use not anymore Digest::SHA1. MooseX::Storage was depending on Digest::SHA1 for Digest::HMAC? I cannot find any reference in the code which uses directly Digest::SHA1. If I'm correctly, could you drop the dependency on Digest::SHA1? Digest::SHA is in perl core since 5.9.3 and it has quite identical interface as Digest::SHA1, it defaults to SHA1 and furthermore this would be reducing the external dependencies by one. Could you apply this change? Regards Salvatore
From salvatore.bonaccorso [...] gmail.com Mon Aug 15 15: 43:52 2011
X-Virus: Hi! I am a header virus! Copy me into yours an join the fun!
MIME-Version: 1.0
X-Spam-Status: No, score=-6.115 tagged_above=-99.9 required=10 tests=[AWL=0.005, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-12441-1311670626-719.69811-3-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
References: <RT-Ticket-69811 [...] rt.cpan.org> <20110726085654.GA8568 [...] elende> <rt-3.8.HEAD-12441-1311670626-719.69811-3-0 [...] rt.cpan.org>
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
X-Operating-System: Debian GNU/Linux
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20110815194341.GA30949 [...] elende>
Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uQr8t48UFsdbeI+V"
X-Spam-Score: -6.115
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 18A37240677 for <cpan-bug+MooseX-Storage [...] hipster.bestpractical.com>; Mon, 15 Aug 2011 15:43:52 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pbnVgf9jj051 for <cpan-bug+MooseX-Storage [...] hipster.bestpractical.com>; Mon, 15 Aug 2011 15:43:50 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 1C0792405AE for <bug-MooseX-Storage [...] rt.cpan.org>; Mon, 15 Aug 2011 15:43:50 -0400 (EDT)
Received: (qmail 14123 invoked by uid 103); 15 Aug 2011 19:43:49 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 15 Aug 2011 19:43:49 -0000
Received: from mail-fx0-f50.google.com (HELO mail-fx0-f50.google.com) (209.85.161.50) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Mon, 15 Aug 2011 12:43:47 -0700
Received: by fxh2 with SMTP id 2so4001911fxh.9 for <bug-MooseX-Storage [...] rt.cpan.org>; Mon, 15 Aug 2011 12:43:44 -0700 (PDT)
Received: by 10.223.159.8 with SMTP id h8mr6028440fax.3.1313437424208; Mon, 15 Aug 2011 12:43:44 -0700 (PDT)
Received: from elende (elende.valinor.li [188.40.94.203]) by mx.google.com with ESMTPS id i16sm5272733faa.21.2011.08.15.12.43.42 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Aug 2011 12:43:42 -0700 (PDT)
Delivered-To: cpan-bug+MooseX-Storage [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #69811] AutoReply: No need to depend on Digest::SHA1
User-Agent: Mutt/1.5.20 (2009-06-14)
Return-Path: <salvatore.bonaccorso [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-opensource:x-virus :x-operating-system:x-pgp-key:user-agent; bh=oaKkUkriiBxrBxAFucR1GRK45PcLVEPRjomomYf87lE=; b=MkbEzRjqG0/xEdx5JOfbQoSwRisHxF7+8XaQ7hRF0sS+7RapglZXyIbyntxrfv+NZY /0EmPqVsyE3ju300JHWYufxVsE1G36I0hsWH6iVwc0v1nM2Ysha9QmwvfrET36bELDp/ Jk8KKv1fqg3M1D7B7CB9aqIF4gckp7ZO7xu6I=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+MooseX-Storage [...] hipster.bestpractical.com
X-RT-Mail-Extension: moosex-storage
X-PGP-Key: http://people.debian.org/~carnil/0x7FD863FE.asc
Date: Mon, 15 Aug 2011 21:43:41 +0200
Sender: Salvatore Bonaccorso <salvatore.bonaccorso [...] gmail.com>
X-Spam-Level:
To: Bugs in MooseX-Storage via RT <bug-MooseX-Storage [...] rt.cpan.org>
X-Opensource: Have a lot of fun!
From: Salvatore Bonaccorso <carnil [...] debian.org>
RT-Message-ID: <rt-3.8.HEAD-22511-1313437432-1747.69811-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: multipart/mixed; boundary="ZPt4rx8FFjLCG7dd"
Content-Disposition: inline
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
X-RT-Original-Encoding: utf-8
Content-Length: 111
Download (untitled) / with headers
text/plain 111b
Hi Here is a possible patch for this. It simply substitutes the algorithm name with SHA-1. Regards Salvatore
Content-Type: text/x-diff; charset=us-ascii
content-disposition: attachment; filename="use-Digest-SHA.patch"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: us-ascii
Content-Length: 753

Message body is not shown because sender requested not to inline it.

Content-Description: Digital signature
content-type: application/pgp-signature; name="signature.asc"
Content-Disposition: inline
Content-Length: 836
Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

MIME-Version: 1.0
In-Reply-To: <20110726085654.GA8568 [...] elende>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <20110726085654.GA8568 [...] elende>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-20171-1336228020-1035.69811-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 77
Applied in commit 7d5ab5, will be in the next release. Thanks for the patch!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.