| From salvatore.bonaccorso [...] gmail.com Tue Jul 26 04: | 57:05 2011 |
| X-Virus: | Hi! I am a header virus! Copy me into yours an join the fun! |
| MIME-Version: | 1.0 |
| X-Spam-Status: | No, score=-6.744 tagged_above=-99.9 required=10 tests=[AWL=-0.634, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779, T_TO_NO_BRKTS_FREEMAIL=0.01] autolearn=ham |
| Content-Disposition: | inline |
| X-Spam-Flag: | NO |
| X-Operating-System: | Debian GNU/Linux |
| content-type: | text/plain; charset="utf-8" |
| Message-ID: | <20110726085654.GA8568 [...] elende> |
| X-Virus-Scanned: | Debian amavisd-new at bestpractical.com |
| X-Spam-Score: | -6.744 |
| Received: | from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id E70B52405B0 for <cpan-bug+MooseX-Storage [...] hipster.bestpractical.com>; Tue, 26 Jul 2011 04:57:04 -0400 (EDT) |
| Received: | from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TfvLX5JPtNTe for <cpan-bug+MooseX-Storage [...] hipster.bestpractical.com>; Tue, 26 Jul 2011 04:57:03 -0400 (EDT) |
| Received: | from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 29D372405AE for <bug-MooseX-Storage [...] rt.cpan.org>; Tue, 26 Jul 2011 04:57:02 -0400 (EDT) |
| Received: | (qmail 11158 invoked by uid 103); 26 Jul 2011 08:57:02 -0000 |
| Received: | from x16.dev (10.0.100.26) by x1.dev with QMQP; 26 Jul 2011 08:57:02 -0000 |
| Received: | from mail-ey0-f174.google.com (HELO mail-ey0-f174.google.com) (209.85.215.174) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Tue, 26 Jul 2011 01:56:59 -0700 |
| Received: | by eyx24 with SMTP id 24so317120eyx.5 for <bug-MooseX-Storage [...] rt.cpan.org>; Tue, 26 Jul 2011 01:56:56 -0700 (PDT) |
| Received: | by 10.14.98.137 with SMTP id v9mr2133848eef.134.1311670616249; Tue, 26 Jul 2011 01:56:56 -0700 (PDT) |
| Received: | from elende (elende.valinor.li [188.40.94.203]) by mx.google.com with ESMTPS id y46sm193558eea.64.2011.07.26.01.56.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 26 Jul 2011 01:56:55 -0700 (PDT) |
| Authentication-Results: | hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com |
| Delivered-To: | cpan-bug+MooseX-Storage [...] hipster.bestpractical.com |
| User-Agent: | Mutt/1.5.20 (2009-06-14) |
| Subject: | No need to depend on Digest::SHA1 |
| Return-Path: | <salvatore.bonaccorso [...] gmail.com> |
| X-RT-Mail-Extension: | moosex-storage |
| X-Original-To: | cpan-bug+MooseX-Storage [...] hipster.bestpractical.com |
| X-Spam-Check-BY: | 16.mx.develooper.com |
| Dkim-Signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:mime-version:content-type :content-disposition:x-opensource:x-virus:x-operating-system :x-pgp-key:user-agent; bh=78c/z3qKDXoai2We6LYOTrWsJIjWL4AxpV3lKq9xcrs=; b=FOt7uyPQDTXviM+fLofJtNxXuxU/hNDhjjrM/iL++n3j0NJnUrVqEcVTaaUf6FUcQW NUQ6UbrJP3Lsgxh8OzBRdWX72EA4E7gte7xWpRVNduOMsE9SZpGUrGoD+6uQE9GoEYdQ UPTwRKhm7HXo1zlb+OVx8vINoevIQY1jRM/Ao= |
| X-PGP-Key: | http://people.debian.org/~carnil/0x7FD863FE.asc |
| Sender: | Salvatore Bonaccorso <salvatore.bonaccorso [...] gmail.com> |
| Date: | Tue, 26 Jul 2011 10:56:54 +0200 |
| X-Spam-Level: | |
| X-Opensource: | Have a lot of fun! |
| To: | bug-MooseX-Storage [...] rt.cpan.org |
| From: | Salvatore Bonaccorso <carnil [...] cpan.org> |
| X-RT-Original-Encoding: | us-ascii |
| Content-Length: | 498 |
Hi
Digest::HMAC changed to use not anymore Digest::SHA1. MooseX::Storage
was depending on Digest::SHA1 for Digest::HMAC? I cannot find any
reference in the code which uses directly Digest::SHA1. If I'm
correctly, could you drop the dependency on Digest::SHA1?
Digest::SHA is in perl core since 5.9.3 and it has quite identical
interface as Digest::SHA1, it defaults to SHA1 and furthermore this
would be reducing the external dependencies by one.
Could you apply this change?
Regards
Salvatore