| From salvatore.bonaccorso [...] gmail.com Thu Jul 14 09: | 41:48 2011 |
| X-Virus: | Hi! I am a header virus! Copy me into yours an join the fun! |
| MIME-Version: | 1.0 |
| X-Spam-Status: | No, score=-6.773 tagged_above=-99.9 required=10 tests=[AWL=-0.664, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, RFC_ABUSE_POST=0.001, SPF_NEUTRAL=0.779, T_TO_NO_BRKTS_FREEMAIL=0.01] autolearn=ham |
| Content-Disposition: | inline |
| X-Spam-Flag: | NO |
| X-Virus-Checked: | Checked by ClamAV on 16.mx.develooper.com |
| X-Operating-System: | Debian GNU/Linux |
| Content-Type: | multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l" |
| Message-ID: | <20110714134138.GA26167 [...] elende> |
| X-Virus-Scanned: | Debian amavisd-new at bestpractical.com |
| X-Spam-Score: | -6.773 |
| Received: | from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 830B8240421 for <cpan-bug+Git-PurePerl [...] hipster.bestpractical.com>; Thu, 14 Jul 2011 09:41:48 -0400 (EDT) |
| Received: | from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fplXaLxYT-Kg for <cpan-bug+Git-PurePerl [...] hipster.bestpractical.com>; Thu, 14 Jul 2011 09:41:47 -0400 (EDT) |
| Received: | from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id F32DE2402F9 for <bug-Git-PurePerl [...] rt.cpan.org>; Thu, 14 Jul 2011 09:41:46 -0400 (EDT) |
| Received: | (qmail 29761 invoked by uid 103); 14 Jul 2011 13:41:46 -0000 |
| Received: | from x16.dev (10.0.100.26) by x1.dev with QMQP; 14 Jul 2011 13:41:46 -0000 |
| Received: | from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Thu, 14 Jul 2011 06:41:43 -0700 |
| Received: | by fxg9 with SMTP id 9so1048076fxg.0 for <bug-Git-PurePerl [...] rt.cpan.org>; Thu, 14 Jul 2011 06:41:40 -0700 (PDT) |
| Received: | by 10.223.145.22 with SMTP id b22mr3671798fav.95.1310650900490; Thu, 14 Jul 2011 06:41:40 -0700 (PDT) |
| Received: | from elende (elende.valinor.li [188.40.94.203]) by mx.google.com with ESMTPS id o17sm148022fal.26.2011.07.14.06.41.39 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jul 2011 06:41:39 -0700 (PDT) |
| Authentication-Results: | hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com |
| Delivered-To: | cpan-bug+Git-PurePerl [...] hipster.bestpractical.com |
| User-Agent: | Mutt/1.5.20 (2009-06-14) |
| Subject: | Use Digest::SHA (in Perl core) instead of Digest::SHA1 |
| Return-Path: | <salvatore.bonaccorso [...] gmail.com> |
| X-RT-Mail-Extension: | git-pureperl |
| X-Original-To: | cpan-bug+Git-PurePerl [...] hipster.bestpractical.com |
| X-Spam-Check-BY: | 16.mx.develooper.com |
| Dkim-Signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:mime-version:content-type :content-disposition:x-opensource:x-virus:x-operating-system :x-pgp-key:user-agent; bh=6ehzo2zSRA9IIPRreD0AFRru3XqlZcK/0c4fpf1IZoI=; b=DuUxtA9gLH3KD7x79fc+owk5uDS9yL/Aen0LqNPX8TRfTzEzcn5IIBCOdeBsMQxYrO XpkAtyhsctdLwzxH3VKc/lCd1VXybOPppVwtLkroRcknUXG6VCZgtHugYzmMvcN0sh9z IQCLsHGOPwLdZk20cBet5CQ8SXwj9z613x3DM= |
| X-PGP-Key: | http://people.debian.org/~carnil/0x7FD863FE.asc |
| Sender: | Salvatore Bonaccorso <salvatore.bonaccorso [...] gmail.com> |
| Date: | Thu, 14 Jul 2011 15:41:38 +0200 |
| X-Spam-Level: | |
| X-Opensource: | Have a lot of fun! |
| To: | bug-Git-PurePerl [...] rt.cpan.org |
| From: | Salvatore Bonaccorso <carnil [...] cpan.org> |
| Content-Length: | 0 |
| content-type: | text/plain; charset="utf-8" |
| Content-Disposition: | inline |
| Content-Transfer-Encoding: | quoted-printable |
| X-RT-Original-Encoding: | us-ascii |
| Content-Length: | 690 |
Hi!
In most cases Digest::SHA1 could be replaced by Digest::SHA. Most of
the functionality (except sha1_transform) of Digest::SHA1 is also
provided by Digest::SHA.
Furthermore Digest::SHA is part of the standard perl distribution
since perl v5.9.3 so this reduces the number of external dependencies
by one.
Could you please consider, changing the use of Digest::SHA1 to
Digest::SHA? In Debian Perl Group we have the goal to drop
libdigest-sha1-perl package providing Digest::SHA1 [1].
[1] http://wiki.debian.org/Teams/DebianPerlGroup/OpenTasks/Transitions/DigestSHA1ToDigestSHA
Regards,
Salvatore
| Content-Description: | Digital signature |
| content-type: | application/pgp-signature; name="signature.asc" |
| Content-Disposition: | inline |
| Content-Length: | 836 |
Message body not shown because it is not plain text.