Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 68842
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: MARKSTOS [...] cpan.org
Requestors: perl [...] greerga.m-l.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: tmpdir.t fails on Win32 on second and subsequent runs
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1308196301-18806-590"
Content-Length: 0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 295
Download (untitled) / with headers
text/plain 295b
tmpdir.t sets the temporary directories to mode 0500 but doesn't reset them later. On Win32 that mode sets the read-only flag, which prevents the END{} block's rmdir from succeeding so subsequent smoke or test runs start failing the test. Patch (versus perl.git v5.14.0-576-g6693394) attached.
Subject: tmpdir.patch
MIME-Version: 1.0
Content-Type: text/x-diff; name="tmpdir.patch"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline; filename="tmpdir.patch"
Content-Transfer-Encoding: binary
Content-Length: 874
Download tmpdir.patch
text/x-diff 874b
diff --git a/cpan/CGI/lib/CGI.pm b/cpan/CGI/lib/CGI.pm index 876ba27..b71769b 100644 --- a/cpan/CGI/lib/CGI.pm +++ b/cpan/CGI/lib/CGI.pm @@ -20,7 +20,7 @@ use Carp 'croak'; # The revision is no longer being updated since moving to git. $CGI::revision = '$Id: CGI.pm,v 1.266 2009/07/30 16:32:34 lstein Exp $'; -$CGI::VERSION='3.54'; +$CGI::VERSION='3.54_01'; # HARD-CODED LOCATION FOR FILE UPLOAD TEMPORARY FILES. # UNCOMMENT THIS ONLY IF YOU KNOW WHAT YOU'RE DOING. diff --git a/cpan/CGI/t/tmpdir.t b/cpan/CGI/t/tmpdir.t index 6e3fcbd..1407356 100644 --- a/cpan/CGI/t/tmpdir.t +++ b/cpan/CGI/t/tmpdir.t @@ -37,4 +37,4 @@ isnt($CGITempFile::TMPDIRECTORY, $testdir, "unwritable \$ENV{TMPDIR} not overridden with an unwritable \$CGITempFile::TMPDIRECTORY"); } -END { rmdir for ($testdir, $testdir2) } +END { for ($testdir, $testdir2) { chmod 0700, $_; rmdir; } }
From mark [...] summersault.com Thu Jun 16 08: 07:44 2011
MIME-Version: 1.0
X-Spam-Status: No, score=-6.78 tagged_above=-99.9 required=10 tests=[AWL=-0.545, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-18806-1308196302-353.68842-4-0 [...] rt.cpan.org>
X-Spam-Flag: NO
References: <RT-Ticket-68842 [...] rt.cpan.org> <rt-3.8.HEAD-18806-1308196302-353.68842-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <4DF9F202.8050609 [...] summersault.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.78
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id E8E3524028D for <cpan-bug+CGI.pm [...] hipster.bestpractical.com>; Thu, 16 Jun 2011 08:07:43 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JOC5+g1wd48S for <cpan-bug+CGI.pm [...] hipster.bestpractical.com>; Thu, 16 Jun 2011 08:07:38 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 8D55524022D for <bug-CGI.pm [...] rt.cpan.org>; Thu, 16 Jun 2011 08:07:37 -0400 (EDT)
Received: (qmail 26924 invoked by uid 103); 16 Jun 2011 12:07:36 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 16 Jun 2011 12:07:36 -0000
Received: from tanagra.summersault.com (HELO tanagra.summersault.com) (12.161.105.149) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Thu, 16 Jun 2011 05:07:34 -0700
Received: (qmail 10675 invoked from network); 16 Jun 2011 12:07:31 -0000
Received: from simba.summersault.com (192.168.97.182) by tanagra.summersault.com with SMTP; 16 Jun 2011 12:07:31 -0000
Delivered-To: cpan-bug+CGI.pm [...] hipster.bestpractical.com
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8
Subject: Re: [rt.cpan.org #68842] tmpdir.t fails on Win32 on second and subsequent runs
Return-Path: <mark [...] summersault.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+CGI.pm [...] hipster.bestpractical.com
X-RT-Mail-Extension: cgi.pm
Date: Thu, 16 Jun 2011 08:07:30 -0400
X-Spam-Level:
To: bug-CGI.pm [...] rt.cpan.org
X-Enigmail-Version: 1.1.1
Content-Transfer-Encoding: 7bit
From: Mark Stosberg <mark [...] summersault.com>
RT-Message-ID: <rt-3.8.HEAD-18812-1308226064-1699.68842-0-0 [...] rt.cpan.org>
Content-Length: 40
Thanks, the patch looks good. Mark
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-17231-1358648510-38.68842-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 105
Download (untitled) / with headers
text/plain 105b
I believe this patch was released in 3.59, supplied by rjbs according to the commit history. Resolving.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.