| From salvatore.bonaccorso [...] gmail.com Fri May 13 16: | 07:59 2011 |
| X-Virus: | Hi! I am a header virus! Copy me into yours an join the fun! |
| MIME-Version: | 1.0 |
| X-Spam-Status: | No, score=-6.11 tagged_above=-99.9 required=10 tests=[AWL=-0.001, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, RFC_ABUSE_POST=0.001, SPF_NEUTRAL=0.779, T_TO_NO_BRKTS_FREEMAIL=0.01] autolearn=ham |
| Content-Disposition: | inline |
| X-Spam-Flag: | NO |
| X-Virus-Checked: | Checked by ClamAV on 16.mx.develooper.com |
| X-Operating-System: | Debian GNU/Linux |
| Content-Type: | multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7" |
| Message-ID: | <20110513200747.GA7080 [...] elende> |
| X-Virus-Scanned: | Debian amavisd-new at bestpractical.com |
| X-Spam-Score: | -6.11 |
| Received: | from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 52BD9241A39 for <cpan-bug+Atompub [...] hipster.bestpractical.com>; Fri, 13 May 2011 16:07:59 -0400 (EDT) |
| Received: | from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yE5itRLVLi-z for <cpan-bug+Atompub [...] hipster.bestpractical.com>; Fri, 13 May 2011 16:07:57 -0400 (EDT) |
| Received: | from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 56AC3241A24 for <bug-Atompub [...] rt.cpan.org>; Fri, 13 May 2011 16:07:57 -0400 (EDT) |
| Received: | (qmail 8944 invoked by uid 103); 13 May 2011 20:07:56 -0000 |
| Received: | from x16.dev (10.0.100.26) by x1.dev with QMQP; 13 May 2011 20:07:56 -0000 |
| Received: | from mail-ew0-f50.google.com (HELO mail-ew0-f50.google.com) (209.85.215.50) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Fri, 13 May 2011 13:07:53 -0700 |
| Received: | by ewy10 with SMTP id 10so870623ewy.9 for <bug-Atompub [...] rt.cpan.org>; Fri, 13 May 2011 13:07:50 -0700 (PDT) |
| Received: | by 10.213.34.193 with SMTP id m1mr843816ebd.6.1305317270555; Fri, 13 May 2011 13:07:50 -0700 (PDT) |
| Received: | from elende (elende.valinor.li [188.40.94.203]) by mx.google.com with ESMTPS id y2sm1649451eeh.11.2011.05.13.13.07.48 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 May 2011 13:07:48 -0700 (PDT) |
| Authentication-Results: | hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com |
| Authentication-Results: | hipster.bestpractical.com (amavisd-new); domainkeys=pass header.sender=salvatore.bonaccorso [...] gmail.com |
| Delivered-To: | cpan-bug+Atompub [...] hipster.bestpractical.com |
| User-Agent: | Mutt/1.5.20 (2009-06-14) |
| Subject: | Use Digest::SHA instead of Digest::SHA1 |
| Return-Path: | <salvatore.bonaccorso [...] gmail.com> |
| Domainkey-Signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:mime-version:content-type :content-disposition:x-opensource:x-virus:x-operating-system :x-pgp-key:user-agent; b=DirvNQ5JKAV3ud5qB1cV21GkO/PtKzO1QwvPBg05TnLkXWmgkqIzt7W8fa0SoPNjMh enESlkjdDSlB6qORYYj9TjpAB4lFrh81JSxJTIWqZr9BzAPSz2cIjQgw83TBPTEIHaeY UpnJL2lw9hM5UvBN6P6uWF3D4hP+mhI3F78KM= |
| X-RT-Mail-Extension: | atompub |
| X-Original-To: | cpan-bug+Atompub [...] hipster.bestpractical.com |
| X-Spam-Check-BY: | 16.mx.develooper.com |
| Dkim-Signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:subject:message-id :mime-version:content-type:content-disposition:x-opensource:x-virus :x-operating-system:x-pgp-key:user-agent; bh=wpD9c0PxAARxhxkJ4c5QTtXQSfP/+GehR6yf9NMafDo=; b=MXtV4+0Ipzd6/EOri0pfkVFuHM2bqe3ik7IgGmNebwNeigNv6sM5KfQOlbelPsA8q5 HRuj9lgPoA4nsuLyT5zl6IW6jsuyva/G/u4Gq0Nd84RAQJNQjzHNG0S+EpW4KDwHuigA Ybfu6QHR2jAzNg55OnKyQ59IjHF9BKmKaCwc8= |
| X-PGP-Key: | https://arda.homelinux.org/~salvi/pubkey.asc |
| Sender: | Salvatore Bonaccorso <salvatore.bonaccorso [...] gmail.com> |
| Date: | Fri, 13 May 2011 22:07:47 +0200 |
| X-Spam-Level: | |
| X-Opensource: | Have a lot of fun! |
| To: | bug-Atompub [...] rt.cpan.org |
| From: | Salvatore Bonaccorso <carnil [...] debian.org> |
| Content-Length: | 0 |
| Content-Type: | multipart/mixed; boundary="Qxx1br4bt0+wmkIi" |
| Content-Disposition: | inline |
| Content-Length: | 0 |
| content-type: | text/plain; charset="utf-8" |
| Content-Disposition: | inline |
| Content-Transfer-Encoding: | quoted-printable |
| X-RT-Original-Encoding: | us-ascii |
| Content-Length: | 466 |
Hi
Your module currently uses Digest::SHA1 in lib/Atompub/Server.pm and
lib/Atompub/Client.pm.
Attached patch changes the module to use Digest::SHA instead of
Digest::SHA1. Digest::SHA is part of the standard perl distribution
since perl v5.9.3 so this reduces the number of external dependencies
by one.
Please consider applying it for the next release.
Regards,
Salvatore
| Content-Type: | text/x-diff; charset=us-ascii |
| content-disposition: | attachment; filename="use-Digest-SHA.patch" |
| Content-Transfer-Encoding: | quoted-printable |
| X-RT-Original-Encoding: | us-ascii |
| Content-Length: | 1420 |
Message body is not shown because sender requested not to inline it.
| Content-Description: | Digital signature |
| content-type: | application/pgp-signature; name="signature.asc" |
| Content-Disposition: | inline |
| Content-Length: | 836 |
Message body not shown because it is not plain text.