Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 67893
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: dom [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.3603
Fixed in: (no value)

Attachments


Subject: Fix failing tilde test when run under a UID without a passwd entry
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1304333641-18809-188"
Content-Length: 0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 403
Download (untitled) / with headers
text/plain 403b
As reported in this Debian bug: <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=624850> some of the tests in t/tilde.t fail when run under a UID without a passwd entry. This can cause the build to fail in some automated environments. The attached patch against 0.3800 fixes this by testing for definedness in the results from getpwuid. A similar patch against 0.3603 has been tested. Thanks, Dominic.
Subject: tilde-test-fix-0.3800.patch
MIME-Version: 1.0
Content-Type: text/x-diff; name="tilde-test-fix-0.3800.patch"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline; filename="tilde-test-fix-0.3800.patch"
Content-Transfer-Encoding: binary
Content-Length: 785
--- Module-Build-0.3800/t/tilde.t.orig 2011-03-05 20:15:41.000000000 +0000 +++ Module-Build-0.3800/t/tilde.t 2011-05-02 11:52:12.000000000 +0100 @@ -46,7 +46,8 @@ unless (defined $home) { my @info = eval { getpwuid $> }; - skip "No home directory for tilde-expansion tests", 15 if $@; + skip "No home directory for tilde-expansion tests", 15 if $@ + or !defined $info[7]; $home = $info[7]; } @@ -95,7 +96,8 @@ # Again, with named users SKIP: { my @info = eval { getpwuid $> }; - skip "No home directory for tilde-expansion tests", 1 if $@; + skip "No home directory for tilde-expansion tests", 1 if $@ + or !defined $info[7] or !defined $info[0]; my ($me, $home) = @info[0,7]; my $expected = "$home/fooxzy";
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-9062-1310138693-422.67893-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 32
Thank you. Patched in the repo.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.