Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 67719
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: MARKSTOS [...] cpan.org
Requestors: SJOHNSTON [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: Newline after form tags
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 204
Download (untitled) / with headers
text/plain 204b
The functions startform and start_form add a newline after the form tag. Newlines around input elements can cause unexpected rendering in the browser. It would be better if no extra newlines where added.
From mark [...] summersault.com Mon Apr 25 09: 35:14 2011
MIME-Version: 1.0
X-Spam-Status: No, score=-6.877 tagged_above=-99.9 required=10 tests=[AWL=-0.642, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-18812-1303594058-1429.67719-4-0 [...] rt.cpan.org>
X-Spam-Flag: NO
References: <RT-Ticket-67719 [...] rt.cpan.org> <rt-3.8.HEAD-18812-1303594058-1429.67719-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <4DB5788B.7000609 [...] summersault.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.877
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id DEB3A241962 for <cpan-bug+CGI [...] hipster.bestpractical.com>; Mon, 25 Apr 2011 09:35:14 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gIE8L5AQO82z for <cpan-bug+CGI [...] hipster.bestpractical.com>; Mon, 25 Apr 2011 09:35:13 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 62FF324195C for <bug-CGI [...] rt.cpan.org>; Mon, 25 Apr 2011 09:35:13 -0400 (EDT)
Received: (qmail 8350 invoked by uid 103); 25 Apr 2011 13:35:12 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 25 Apr 2011 13:35:12 -0000
Received: from tanagra.summersault.com (HELO tanagra.summersault.com) (12.161.105.149) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Mon, 25 Apr 2011 06:35:10 -0700
Received: (qmail 58342 invoked from network); 25 Apr 2011 13:35:07 -0000
Received: from simba.summersault.com (192.168.97.182) by tanagra.summersault.com with SMTP; 25 Apr 2011 13:35:07 -0000
Delivered-To: cpan-bug+CGI [...] hipster.bestpractical.com
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7
Subject: Re: [rt.cpan.org #67719] Newline after form tags
Return-Path: <mark [...] summersault.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+CGI [...] hipster.bestpractical.com
X-RT-Mail-Extension: cgi
Date: Mon, 25 Apr 2011 09:35:07 -0400
X-Spam-Level:
To: bug-CGI [...] rt.cpan.org
X-Enigmail-Version: 1.1.1
Content-Transfer-Encoding: 7bit
From: Mark Stosberg <mark [...] summersault.com>
RT-Message-ID: <rt-3.8.HEAD-18805-1303738515-1310.67719-0-0 [...] rt.cpan.org>
Content-Length: 335
Download (untitled) / with headers
text/plain 335b
Show quoted text
> The functions startform and start_form add a newline after the form tag. > Newlines around input elements can cause unexpected rendering in the > browser. It would be better if no extra newlines where added.
I agree with this change suggestion. People can use "CGI::Pretty" if they want automatic newlines in their HTML. Mark
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: multipart/mixed; boundary="----------=_1319839124-2601-217"
Message-ID: <rt-3.8.HEAD-2601-1319839124-947.67719-0-0 [...] rt.cpan.org>
From: eberg [...] bergbrains.com
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 135
Download (untitled) / with headers
text/plain 135b
Here's a quick reproduction: use CGI qw(:all); my $s = start_form(); warn "START_FORM: '$s'"; ...and a diff for the fix is attached.
MIME-Version: 1.0
Subject: CGI.pm-trailingCRInStartForm.diff
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: application/octet-stream; name="CGI.pm-trailingCRInStartForm.diff"
Content-Disposition: inline; filename="CGI.pm-trailingCRInStartForm.diff"
Content-Transfer-Encoding: base64
Content-Length: 713
--- CGI-orig.pm 2011-10-28 17:55:38.000000000 -0400 +++ CGI.pm 2011-10-28 17:56:00.404283000 -0400 @@ -1953,7 +1953,7 @@ $action = qq(action="$action"); my($other) = @other ? " @other" : ''; $self->{'.parametersToAdd'}={}; - return qq/<form method="$method" $action enctype="$enctype"$other>\n/; + return qq/<form method="$method" $action enctype="$enctype"$other>/; } END_OF_FUNC @@ -1987,7 +1987,7 @@ $action = qq(action="$action"); my($other) = @other ? " @other" : ''; $self->{'.parametersToAdd'}={}; - return qq/<form method="$method" $action enctype="$enctype"$other>\n/; + return qq/<form method="$method" $action enctype="$enctype"$other>/; } END_OF_FUNC
From mark [...] summersault.com Wed Nov 2 17: 02:55 2011
MIME-Version: 1.0
X-Spam-Status: No, score=-6.573 tagged_above=-99.9 required=10 tests=[AWL=-0.338, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-2601-1319839125-1853.67719-5-0 [...] rt.cpan.org>
X-Spam-Flag: NO
References: <RT-Ticket-67719 [...] rt.cpan.org> <rt-3.8.HEAD-2601-1319839125-1853.67719-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <4EB1AFF5.9040703 [...] summersault.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.573
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id E473F240CF4 for <cpan-bug+cgi [...] hipster.bestpractical.com>; Wed, 2 Nov 2011 17:02:55 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bDpW-gK--SFF for <cpan-bug+cgi [...] hipster.bestpractical.com>; Wed, 2 Nov 2011 17:02:54 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 58E4C240C93 for <bug-cgi [...] rt.cpan.org>; Wed, 2 Nov 2011 17:02:54 -0400 (EDT)
Received: (qmail 10767 invoked by uid 103); 2 Nov 2011 21:02:53 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 2 Nov 2011 21:02:53 -0000
Received: from tanagra.summersault.com (HELO tanagra.summersault.com) (12.161.105.149) by 16.mx.develooper.com (qpsmtpd/0.80/v0.80-19-gf52d165) with ESMTP; Wed, 02 Nov 2011 14:02:51 -0700
Received: (qmail 31010 invoked from network); 2 Nov 2011 21:02:47 -0000
Received: from simba.summersault.com (192.168.97.182) by tanagra.summersault.com with SMTP; 2 Nov 2011 21:02:47 -0000
Delivered-To: cpan-bug+cgi [...] hipster.bestpractical.com
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1
Subject: Re: [rt.cpan.org #67719] Newline after form tags
Return-Path: <mark [...] summersault.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+cgi [...] hipster.bestpractical.com
X-RT-Mail-Extension: cgi
Date: Wed, 02 Nov 2011 17:02:45 -0400
X-Spam-Level:
To: bug-cgi [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Mark Stosberg <mark [...] summersault.com>
RT-Message-ID: <rt-3.8.HEAD-2597-1320267776-269.67719-0-0 [...] rt.cpan.org>
Content-Length: 34
Thanks. We'll take it from here.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-23811-1345083742-1896.67719-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 25
Thanks. Releasing today.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.