Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the HTML-Widget CPAN distribution.

Report information
The Basics
Id: 63583
Status: open
Priority: 0/
Queue: HTML-Widget

People
Owner: Nobody in particular
Requestors: CARNIL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From salvatore.bonaccorso [...] gmail.com Sat Dec 4 03: 10:22 2010
X-Virus: Hi! I am a header virus! Copy me into yours an join the fun!
MIME-Version: 1.0
X-Spam-Status: No, score=-7.407 tagged_above=-99.9 required=10 tests=[AWL=-1.297, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779, T_TO_NO_BRKTS_FREEMAIL=0.01] autolearn=ham
Content-Disposition: inline
X-Spam-Flag: NO
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
X-Operating-System: Debian GNU/Linux
Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr"
Message-ID: <20101204081001.GA2416 [...] elende>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -7.407
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id E55B32411DB for <cpan-bug+HTML-Widget [...] hipster.bestpractical.com>; Sat, 4 Dec 2010 03:10:21 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gO0ZoeEyQJ0a for <cpan-bug+HTML-Widget [...] hipster.bestpractical.com>; Sat, 4 Dec 2010 03:10:20 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 1D6E12411D5 for <bug-HTML-Widget [...] rt.cpan.org>; Sat, 4 Dec 2010 03:10:20 -0500 (EST)
Received: (qmail 11394 invoked by uid 103); 4 Dec 2010 08:10:19 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 4 Dec 2010 08:10:19 -0000
Received: from mail-fx0-f50.google.com (HELO mail-fx0-f50.google.com) (209.85.161.50) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Sat, 04 Dec 2010 00:10:12 -0800
Received: by fxm14 with SMTP id 14so8534279fxm.9 for <bug-HTML-Widget [...] rt.cpan.org>; Sat, 04 Dec 2010 00:10:09 -0800 (PST)
Received: by 10.223.103.65 with SMTP id j1mr189772fao.88.1291450203094; Sat, 04 Dec 2010 00:10:03 -0800 (PST)
Received: from elende (elende.valinor.li [188.40.94.203]) by mx.google.com with ESMTPS id 21sm893439fav.41.2010.12.04.00.10.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 04 Dec 2010 00:10:02 -0800 (PST)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Authentication-Results: hipster.bestpractical.com (amavisd-new); domainkeys=pass header.sender=salvatore.bonaccorso [...] gmail.com
Delivered-To: cpan-bug+HTML-Widget [...] hipster.bestpractical.com
User-Agent: Mutt/1.5.18 (2008-05-17)
Subject: Failing tests when using HTML::Tree (>= 4.0)
Return-Path: <salvatore.bonaccorso [...] gmail.com>
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:mime-version:content-type :content-disposition:x-opensource:x-virus:x-operating-system :x-pgp-key:user-agent; b=mrXT+5G0m9+6rm8LhdHfpHDCK4EYJnSJporcUxcqj2rEWdN9OkjSE2iuXdk8Fhkfzl fqc4qOce4UTOezpOk4Wb9qkKGqns1G1QLzkmPKq2udK6uCCWb2rUYGgt62LHVE/ne8dZ oV/QheOiFsCjTRu15HRM+LUJzIcXJ+TFEAYeI=
X-RT-Mail-Extension: html-widget
X-Original-To: cpan-bug+HTML-Widget [...] hipster.bestpractical.com
X-Spam-Check-BY: 16.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:from:to:subject :message-id:mime-version:content-type:content-disposition :x-opensource:x-virus:x-operating-system:x-pgp-key:user-agent; bh=Eh6R/fnJ7qkP3W1jc2+jBTKAM7arpKkq9/CK2pFQEUI=; b=is6M0ERX4H1ysccuBfSLm02zE6sm4I7OzOSU2LOvu7UiMJb7qrMg49ziiML774FfiV AGd/emIc5fhoNQbwY65Gv3XHp60UPeCwKEBR20jwI7d9n9ecSeQ47A78F97qwjOwIQKd CFt5Kw+wC8qwBLILRBMZJ7JTu3PYA5PAt0q8g=
X-PGP-Key: https://arda.homelinux.org/~salvi/pubkey.asc
Sender: Salvatore Bonaccorso <salvatore.bonaccorso [...] gmail.com>
Date: Sat, 4 Dec 2010 09:10:01 +0100
X-Spam-Level:
X-Opensource: Have a lot of fun!
To: bug-HTML-Widget [...] rt.cpan.org
From: Salvatore Bonaccorso <carnil [...] cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Disposition: inline
X-RT-Original-Encoding: us-ascii
Content-Length: 502
Download (untitled) / with headers
text/plain 502b
Hi Carl When building HTML::Widget with using HTML::Tree (>= 4.0) some tests fails (see [1]). [1] http://bugs.debian.org/605809 Indeed the Changes for HTML::Tree contains: 4.0 Mon Sep 20 2010 [THINGS THAT MAY BREAK YOUR CODE OR TESTS] * Changes to entity encoding from ord values to XML entities may break tests expecting &#00; style encoding. * Attribute names are now validated in as_XML and invalid names will cause an error. Thanks for considering, Bests Salvatore
Content-Description: Digital signature
content-type: application/pgp-signature; name="signature.asc"
Content-Disposition: inline
Content-Length: 835
Download signature.asc
application/pgp-signature 835b

Message body not shown because it is not plain text.

MIME-Version: 1.0
In-Reply-To: <20101204081001.GA2416 [...] elende>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
References: <20101204081001.GA2416 [...] elende>
Content-Type: multipart/mixed; boundary="----------=_1409589686-2223-2"
Message-ID: <rt-4.0.18-2223-1409589686-1761.63583-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 237

I don't know if anyone is using this or not, but hit this when doing some overlay cleaning on gentoo.

 

Attached is a patch for this specific problem, but the hash-randomness in 5.18 is still present.

MIME-Version: 1.0
Subject: rt63583.patch
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Type: text/x-patch; name="rt63583.patch"
Content-Disposition: inline; filename="rt63583.patch"
Content-Transfer-Encoding: binary
Content-Length: 1529
Download rt63583.patch
text/x-diff 1.4k
diff -Naur t/04basic.t t/04basic.t --- t/04basic.t 2007-03-01 15:42:26.000000000 +0000 +++ t/04basic.t 2014-09-01 16:31:49.592374273 +0000 @@ -82,7 +82,7 @@ is( $c->error_xml, <<EOF, 'Error XML output is ok' ); <span class="error_messages" id="widget_age_errors"><span class="regex_errors" id="widget_age_error_regex">Contains digit characters.</span></span> EOF - is( $c->javascript_xml, <<EOF, 'JavScript XML output is ok' ); + is( $c->javascript_xml, ( substr <<EOF, 0, -1 ), 'JavScript XML output is ok' ); <script type="text/javascript"> <!-- diff -Naur t/06bugs_xml_escape.t t/06bugs_xml_escape.t --- t/06bugs_xml_escape.t 2007-03-01 16:05:40.000000000 +0000 +++ t/06bugs_xml_escape.t 2014-09-01 16:32:15.889098013 +0000 @@ -23,5 +23,5 @@ like( "$f", qr'value="é"', 'utf-8 character ok' ); - like( "$f", qr'value="&#34; foo &#62;"', '' ); + like( "$f", qr'value="&quot; foo &gt;"', '' ); } diff -Naur t/07custom_render.t t/07custom_render.t --- t/07custom_render.t 2007-03-01 15:42:26.000000000 +0000 +++ t/07custom_render.t 2014-09-01 16:32:45.904641305 +0000 @@ -119,7 +119,7 @@ is( $c->error_xml, <<EOF, 'Error XML output is ok' ); <span class="error_messages" id="widget_age_errors"><span class="regex_errors" id="widget_age_error_regex">Contains digit characters.</span></span> EOF - is( $c->javascript_xml, <<EOF, 'JavScript XML output is ok' ); + is( $c->javascript_xml, ( substr <<EOF, 0, -1 ), 'JavScript XML output is ok' ); <script type="text/javascript"> <!--


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.