Skip Menu |
 

This queue is for tickets about the Module-Install CPAN distribution.

Report information
The Basics
Id: 62350
Status: resolved
Priority: 0/
Queue: Module-Install

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 0.70
  • 0.71
  • 0.72
  • 0.73
  • 0.74
  • 0.75
  • 0.76
  • 0.77
  • 0.78
  • 0.79
  • 0.80
  • 0.81
  • 0.82
  • 0.83
  • 0.84
  • 0.85
  • 0.86
  • 0.87
  • 0.88
  • 0.89
  • 0.90
  • 0.91
  • 0.92
  • 0.93
  • 0.94
  • 0.95
  • 0.96
  • 0.97
  • 0.98
  • 0.99
  • 1.00
Fixed in: 1.08

Attachments
0001-do-not-force-anymore-the-newest-ExtUtils-MakeMaker-w.patch



Subject: EUMM minimal version should not be set to the author's installed version
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1287681090-2356-89"
Content-Length: 0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 750
Download (untitled) / with headers
text/plain 750b
A META.yml file written by Module::Install sets the minimal EUMM version to the version as found on the author's system. I think this approach is wrong, for reasons explained in Ævar's blog post http://blogs.perl.org/users/aevar_arnfjor_bjarmason/2010/10/the-cpan-client-version-less-dependency-problem.html (see his update to chromatic's post). Additionally this code leads to the test error mentioned in https://rt.cpan.org/Ticket/Display.html?id=62348 I suggest to simply set the minimum EUMM version to 0. This could be increased if there was really ever a problem with older EUMM. But if so, this should be documented. See the attached patch. This closes my today's series of RT tickets and patches for Module::Install. Regards, Slaven
Subject: 0001-do-not-force-anymore-the-newest-ExtUtils-MakeMaker-w.patch
MIME-Version: 1.0
Content-Type: text/x-diff; name="0001-do-not-force-anymore-the-newest-ExtUtils-MakeMaker-w.patch"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline; filename="0001-do-not-force-anymore-the-newest-ExtUtils-MakeMaker-w.patch"
Content-Transfer-Encoding: binary
Content-Length: 1617
From ce659f08543d9a52e4b63e860fd0acd3e54b6a99 Mon Sep 17 00:00:00 2001 From: Slaven Rezic <slaven@rezic.de> Date: Thu, 21 Oct 2010 18:43:43 +0200 Subject: [PATCH] do not force anymore the newest ExtUtils::MakeMaker without a good reason --- lib/Module/Install/Makefile.pm | 19 ++----------------- 1 files changed, 2 insertions(+), 17 deletions(-) diff --git a/lib/Module/Install/Makefile.pm b/lib/Module/Install/Makefile.pm index a3fdb00..6f05eee 100644 --- a/lib/Module/Install/Makefile.pm +++ b/lib/Module/Install/Makefile.pm @@ -210,23 +210,8 @@ sub write { . "but we need version >= $perl_version"; } - # Make sure we have a new enough MakeMaker - require ExtUtils::MakeMaker; - - if ( $perl_version and Module::Install::_cmp($perl_version, '5.006') >= 0 ) { - # MakeMaker can complain about module versions that include - # an underscore, even though its own version may contain one! - # Hence the funny regexp to get rid of it. See RT #35800 - # for details. - my $v = $ExtUtils::MakeMaker::VERSION =~ /^(\d+\.\d+)/; - $self->build_requires( 'ExtUtils::MakeMaker' => $v ); - $self->configure_requires( 'ExtUtils::MakeMaker' => $v ); - } else { - # Allow legacy-compatibility with 5.005 by depending on the - # most recent EU:MM that supported 5.005. - $self->build_requires( 'ExtUtils::MakeMaker' => 6.42 ); - $self->configure_requires( 'ExtUtils::MakeMaker' => 6.42 ); - } + $self->build_requires( 'ExtUtils::MakeMaker' => 0 ); + $self->configure_requires( 'ExtUtils::MakeMaker' => 0 ); # Generate the MakeMaker params my $args = $self->makemaker_args; -- 1.7.0.3
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-16526-1395757678-1958.62350-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 112
Download (untitled) / with headers
text/plain 112b
hardcoded set to following in Makefile.PL in 1.08 requires 'ExtUtils::MakeMaker' => '6.59'; please close
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-16526-1395757678-1958.62350-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-16526-1395757678-1958.62350-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-14640-1396001908-598.62350-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 25
Closing as fixed in 1.08


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.