Skip Menu |
 

This queue is for tickets about the Search-Sitemap CPAN distribution.

Report information
The Basics
Id: 61197
Status: open
Priority: 0/
Queue: Search-Sitemap

People
Owner: Nobody in particular
Requestors: AJGB [...] cpan.org
cjm [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.10
Fixed in: (no value)



Subject: Search::Sitemap 2.11 on github
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 490
Download (untitled) / with headers
text/plain 490b
Hi, I've fixed following bugs: 60498 Moose changes cause warning about attribute coercion 59038 $map->add() doesn't accept a DateTime object for lastmod 57260 small documentation bug 57240 Search::Sitemap::Index object can't be created 57231 minor documentation bug 56964 Can't update() a URL's priority 52742 read() seems not to read It's available on http://github.com/ajgb/search-sitemap as version 2.11. There are separate commits for each bug. Regards, Alex J. G. Burzyński
From email [...] jasonkohles.com Tue Sep 21 13: 28:05 2010
MIME-Version: 1.0 (Apple Message framework v1081)
X-Spam-Status: No, score=-10.599 tagged_above=-99.9 required=10 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-11059-1284028376-1979.61197-4-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.1081)
X-Spam-Flag: NO
References: <RT-Ticket-61197 [...] rt.cpan.org> <rt-3.8.HEAD-11059-1284028376-1979.61197-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Content-Type: text/plain; charset=utf-8
Message-ID: <13689102-ADEB-41FA-B4FF-1E64E1B08314 [...] jasonkohles.com>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -10.599
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id B052724022C for <cpan-bug+Search-Sitemap [...] hipster.bestpractical.com>; Tue, 21 Sep 2010 13:28:05 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PVym7g-g5plI for <cpan-bug+Search-Sitemap [...] hipster.bestpractical.com>; Tue, 21 Sep 2010 13:28:02 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 0382B24022A for <bug-Search-Sitemap [...] rt.cpan.org>; Tue, 21 Sep 2010 13:28:01 -0400 (EDT)
Received: (qmail 23911 invoked by uid 103); 21 Sep 2010 17:31:07 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 21 Sep 2010 17:31:07 -0000
Received: from one.mindwell.com (HELO mail.mindwell.com) (66.240.234.42) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Tue, 21 Sep 2010 10:31:05 -0700
Received: from jkohles-macpro.yojoe.local (wsip-174-78-145-234.dc.dc.cox.net [174.78.145.234]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.mindwell.com (Postfix) with ESMTPSA id 4D86E238ACA for <bug-Search-Sitemap [...] rt.cpan.org>; Tue, 21 Sep 2010 13:31:03 -0400 (EDT)
Delivered-To: cpan-bug+Search-Sitemap [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #61197] Search::Sitemap 2.11 on github
Return-Path: <email [...] jasonkohles.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Search-Sitemap [...] hipster.bestpractical.com
X-RT-Mail-Extension: search-sitemap
Date: Tue, 21 Sep 2010 13:31:02 -0400
X-Spam-Level:
To: bug-Search-Sitemap [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Jason Kohles <email [...] jasonkohles.com>
RT-Message-ID: <rt-3.8.HEAD-24885-1285090272-1607.61197-0-0 [...] rt.cpan.org>
Content-Length: 1178
Download (untitled) / with headers
text/plain 1.1k
Thanks, this is the largest patch anybody has ever sent me for one of my modules! Sorry it took so long for me to respond, I've been out of town. I'll work on getting a new release out with your fixes ASAP. Thanks again! On Sep 9, 2010, at 6:32 AM, Alex J. G. Burzynski via RT wrote: Show quoted text
> Thu Sep 09 06:32:55 2010: Request 61197 was acted upon. > Transaction: Ticket created by AJGB > Queue: Search-Sitemap > Subject: Search::Sitemap 2.11 on github > Broken in: 2.10 > Severity: (no value) > Owner: Nobody > Requestors: AJGB@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=61197 > > > > Hi, > > I've fixed following bugs: > 60498 Moose changes cause warning about attribute coercion > 59038 $map->add() doesn't accept a DateTime object for lastmod > 57260 small documentation bug > 57240 Search::Sitemap::Index object can't be created > 57231 minor documentation bug > 56964 Can't update() a URL's priority > 52742 read() seems not to read > > It's available on http://github.com/ajgb/search-sitemap as version 2.11. > > There are separate commits for each bug. > > Regards, > Alex J. G. Burzyński >
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-24885-1285090272-1607.61197-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <RT-Ticket-61197 [...] rt.cpan.org> <rt-3.8.HEAD-11059-1284028376-1979.61197-4-0 [...] rt.cpan.org> <13689102-ADEB-41FA-B4FF-1E64E1B08314 [...] jasonkohles.com> <rt-3.8.HEAD-24885-1285090272-1607.61197-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-2357-1288561561-1297.61197-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 1492
Download (untitled) / with headers
text/plain 1.4k
Hi Jason, My offer to help you with maintaining this module still holds. Search::Sitemap is a great piece of work and I'm really keen on bringing it alive again. Regards, Alex On Tue Sep 21 13:31:12 2010, email@jasonkohles.com wrote: Show quoted text
> Thanks, this is the largest patch anybody has ever sent me for one of > my modules! Sorry it took so long for me to respond, I've been out of > town. I'll work on getting a new release out with your fixes ASAP. > > Thanks again! > > On Sep 9, 2010, at 6:32 AM, Alex J. G. Burzynski via RT wrote: >
> > Thu Sep 09 06:32:55 2010: Request 61197 was acted upon. > > Transaction: Ticket created by AJGB > > Queue: Search-Sitemap > > Subject: Search::Sitemap 2.11 on github > > Broken in: 2.10 > > Severity: (no value) > > Owner: Nobody > > Requestors: AJGB@cpan.org > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=61197 > > > > > > > Hi, > > > > I've fixed following bugs: > > 60498 Moose changes cause warning about attribute coercion > > 59038 $map->add() doesn't accept a DateTime object for lastmod > > 57260 small documentation bug > > 57240 Search::Sitemap::Index object can't be created > > 57231 minor documentation bug > > 56964 Can't update() a URL's priority > > 52742 read() seems not to read > > > > It's available on http://github.com/ajgb/search-sitemap as version
> 2.11.
> > > > There are separate commits for each bug. > > > > Regards, > > Alex J. G. Burzyński > >
>
From email [...] jasonkohles.com Thu Nov 25 18: 26:49 2010
MIME-Version: 1.0 (Apple Message framework v1081)
X-Spam-Status: No, score=-6.9 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-2357-1288561561-257.61197-5-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.1081)
X-Spam-Flag: NO
References: <RT-Ticket-61197 [...] rt.cpan.org> <rt-3.8.HEAD-11059-1284028376-1979.61197-4-0 [...] rt.cpan.org> <13689102-ADEB-41FA-B4FF-1E64E1B08314 [...] jasonkohles.com> <rt-3.8.HEAD-24885-1285090272-1607.61197-5-0 [...] rt.cpan.org> <rt-3.8.HEAD-2357-1288561561-257.61197-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Content-Type: text/plain; charset=utf-8
Message-ID: <3745E0AC-7FBC-4267-AA33-216B78963AE1 [...] jasonkohles.com>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.9
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 8AC23241218 for <cpan-bug+Search-Sitemap [...] hipster.bestpractical.com>; Thu, 25 Nov 2010 18:26:49 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mUylJMLBARx4 for <cpan-bug+Search-Sitemap [...] hipster.bestpractical.com>; Thu, 25 Nov 2010 18:26:47 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 4F3E024120F for <bug-Search-Sitemap [...] rt.cpan.org>; Thu, 25 Nov 2010 18:26:46 -0500 (EST)
Received: (qmail 17259 invoked by uid 103); 25 Nov 2010 23:26:46 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 25 Nov 2010 23:26:46 -0000
Received: from one.mindwell.com (HELO mail.mindwell.com) (66.240.234.42) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Thu, 25 Nov 2010 15:26:44 -0800
Received: from jkohles-mbp.kohlesfamily.org (pool-173-72-136-84.clppva.fios.verizon.net [173.72.136.84]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.mindwell.com (Postfix) with ESMTPSA id F1310238ACA for <bug-Search-Sitemap [...] rt.cpan.org>; Thu, 25 Nov 2010 18:26:41 -0500 (EST)
Delivered-To: cpan-bug+Search-Sitemap [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #61197] Search::Sitemap 2.11 on github
Return-Path: <email [...] jasonkohles.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Search-Sitemap [...] hipster.bestpractical.com
X-RT-Mail-Extension: search-sitemap
Date: Thu, 25 Nov 2010 18:26:40 -0500
X-Spam-Level:
To: bug-Search-Sitemap [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Jason Kohles <email [...] jasonkohles.com>
RT-Message-ID: <rt-3.8.HEAD-2362-1290727610-5.61197-0-0 [...] rt.cpan.org>
Content-Length: 2116
Sorry I've forgotten about this for so long. Could I convince you to fork my existing repo and apply the changes to that, rather than creating a new repo and importing the code? Otherwise it's a lot more work to get the patches applied. Also, for the future, If you apply changes to a fork and then submit a pull request in github, then your changes will end up in my queue and I'm less likely to forget about it. On Oct 31, 2010, at 5:46 PM, Alex J. G. Burzynski via RT wrote: Show quoted text
> Queue: Search-Sitemap > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=61197 > > > Hi Jason, > > My offer to help you with maintaining this module still holds. > > Search::Sitemap is a great piece of work and I'm really keen on bringing > it alive again. > > Regards, > Alex > > > On Tue Sep 21 13:31:12 2010, email@jasonkohles.com wrote:
>> Thanks, this is the largest patch anybody has ever sent me for one of >> my modules! Sorry it took so long for me to respond, I've been out of >> town. I'll work on getting a new release out with your fixes ASAP. >> >> Thanks again! >> >> On Sep 9, 2010, at 6:32 AM, Alex J. G. Burzynski via RT wrote: >>
>>> Thu Sep 09 06:32:55 2010: Request 61197 was acted upon. >>> Transaction: Ticket created by AJGB >>> Queue: Search-Sitemap >>> Subject: Search::Sitemap 2.11 on github >>> Broken in: 2.10 >>> Severity: (no value) >>> Owner: Nobody >>> Requestors: AJGB@cpan.org >>> Status: new >>> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=61197 > >>> >>> >>> Hi, >>> >>> I've fixed following bugs: >>> 60498 Moose changes cause warning about attribute coercion >>> 59038 $map->add() doesn't accept a DateTime object for lastmod >>> 57260 small documentation bug >>> 57240 Search::Sitemap::Index object can't be created >>> 57231 minor documentation bug >>> 56964 Can't update() a URL's priority >>> 52742 read() seems not to read >>> >>> It's available on http://github.com/ajgb/search-sitemap as version
>> 2.11.
>>> >>> There are separate commits for each bug. >>> >>> Regards, >>> Alex J. G. Burzyński >>>
>>
> > >
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-18808-1306434701-1798.61197-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 376
Download (untitled) / with headers
text/plain 376b
I've exported all the changes in AJGB's repo (as of today) and imported them into a fork of your repo, Jason. I've also submitted a pull request on Github (https://github.com/jasonk/search-sitemap/pull/1). AJGB, you might consider forking my repo (https://github.com/madsen/search-sitemap) if you want to make any additional changes, so they'll be easier for Jason to merge.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.