Skip Menu |
 

This queue is for tickets about the Imager CPAN distribution.

Report information
The Basics
Id: 60242
Status: resolved
Priority: 30/
Queue: Imager

People
Owner: Nobody in particular
Requestors: TONYC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.75
Fixed in: (no value)



Subject: the png code directly accesses structure members it shouldn't
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 2817
Download (untitled) / with headers
text/plain 2.7k
Access to these members has been deprecated in recent libpng, and the functions used to access the structure members have been long enough that portability isn't an issue. Warnings: impng.c:44: warning: 'io_ptr' is deprecated (declared at /Users/tony/local/png143/include/png.h:1110) impng.c: In function 'i_writepng_wiol': impng.c:113: warning: 'jmpbuf' is deprecated (declared at /Users/tony/local/png143/include/png.h:1096) impng.c:119: warning: 'io_ptr' is deprecated (declared at /Users/tony/local/png143/include/png.h:1110) impng.c: In function 'i_readpng_wiol': impng.c:207: warning: 'jmpbuf' is deprecated (declared at /Users/tony/local/png143/include/png.h:1096) impng.c:214: warning: 'io_ptr' is deprecated (declared at /Users/tony/local/png143/include/png.h:1110) impng.c: In function 'wiol_read_data': impng.c:36: warning: 'io_ptr' is deprecated (declared at /Users/tony/local/png143/include/png.h:1110) impng.c: In function 'wiol_write_data': impng.c:44: warning: 'io_ptr' is deprecated (declared at /Users/tony/local/png143/include/png.h:1110) impng.c: In function 'i_writepng_wiol': impng.c:113: warning: 'jmpbuf' is deprecated (declared at /Users/tony/local/png143/include/png.h:1096) impng.c:119: warning: 'io_ptr' is deprecated (declared at /Users/tony/local/png143/include/png.h:1110) impng.c: In function 'i_readpng_wiol': impng.c:207: warning: 'jmpbuf' is deprecated (declared at /Users/tony/local/png143/include/png.h:1096) impng.c:214: warning: 'io_ptr' is deprecated (declared at /Users/tony/local/png143/include/png.h:1110) impng.c: In function 'wiol_read_data': impng.c:36: warning: 'io_ptr' is deprecated (declared at /Users/tony/local/png143/include/png.h:1110) impng.c: In function 'wiol_write_data': impng.c:44: warning: 'io_ptr' is deprecated (declared at /Users/tony/local/png143/include/png.h:1110) impng.c: In function 'i_writepng_wiol': impng.c:113: warning: 'jmpbuf' is deprecated (declared at /Users/tony/local/png143/include/png.h:1096) impng.c:119: warning: 'io_ptr' is deprecated (declared at /Users/tony/local/png143/include/png.h:1110) impng.c: In function 'i_readpng_wiol': impng.c:207: warning: 'jmpbuf' is deprecated (declared at /Users/tony/local/png143/include/png.h:1096) impng.c:214: warning: 'io_ptr' is deprecated (declared at /Users/tony/local/png143/include/png.h:1110) Functions that should be used: PNG_EXPORT(void,png_set_write_fn) PNGARG((png_structp png_ptr, png_voidp io_ptr, png_rw_ptr write_data_fn, png_flush_ptr output_flush_fn)); /* Replace the default data input function with a user supplied one. */ PNG_EXPORT(void,png_set_read_fn) PNGARG((png_structp png_ptr, png_voidp io_ptr, png_rw_ptr read_data_fn)); /* Return the user pointer associated with the I/O functions */ PNG_EXPORT(png_voidp,png_get_io_ptr) PNGARG((png_structp png_ptr));
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-29488-1286520557-229.60242-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 20
Fixed in Imager 0.78


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.