Skip Menu |
 

This queue is for tickets about the IO-Compress CPAN distribution.

Report information
The Basics
Id: 59506
Status: open
Priority: 0/
Queue: IO-Compress

People
Owner: Nobody in particular
Requestors: dmuey [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: trimming down imports/exports would gain speed and save memory
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 466
Download (untitled) / with headers
text/plain 466b
Hello, Thanks for your hard work on this excellent module! My boss was doing some profiling and noticed that there was a lot of unnecessary importing w/ IO::Compress. Here is a list: http://koston.org/iocompress_symbol_imports.txt We've been trimming our code down by changing this sort of thing: use XYZ; foo(); to use XYZ (); XYZ::foo(); and wanted to request the same w/ IO::Compress. Would you be willing to look over a patch? Thanks! -- Dan Muey
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-2366-1279489294-577.59506-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 620
Download (untitled) / with headers
text/plain 620b
Hi Dan, In principle I don't have a problem with what you suggest, but I'd like to have a feel for what it saves in both time & memory. The fully qualified names for variables & subs can get quite long. Rather than disabling all importing or symbols, have you looked into only importing those that are actually used? Also, one other thing to consider - my compression modules build with all versions of Perl from 5.004 onwards. Any patch must take that into account. Don't worry if you don't have a full suite of Perl binaries - I have a setup that allows me to test my modules against all Perl versions. cheers Paul
From webmaster [...] simplemood.com Sun Jul 18 17: 45:32 2010
X-Ymail-Osg: LWOkto8VM1nv20MGdju_8DledfNqY6xfsV2ZQ1YYhSS9GI. ppb3KpsAFNWAUK9Ga8Srm8.YyQxKMfAUcGnhiMc2WGfmVxqMw7zYz0R9MeSJ XpZc3HbvkfL975eo.l1F55JkqqEqgGtZdtneNVepNxQ4OZYWZKWB7N53LHcH zSP_NgrN8RqXTVtD67zqyT8ZNqUkMixc03ueFWYZXa.Vcy.4g_KwQDDN7.Ya JVsDfZ.Kds2J5dVF59pW.oz0FBoSGn2KgfgAXVC9ARlbXAw7lxYhngFXaq7d m
MIME-Version: 1.0 (Apple Message framework v1081)
X-Spam-Status: No, score=-10.599 tagged_above=-99.9 required=10 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-2366-1279489295-1215.59506-6-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.1081)
X-Spam-Flag: NO
References: <RT-Ticket-59506 [...] rt.cpan.org> <rt-3.8.HEAD-2366-1279489295-1215.59506-6-0 [...] rt.cpan.org>
X-Yahoo-SMTP: 6x4jUwiswBDh.jss0QtuHggT7XKmujVzQV6B
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Yahoo-Newman-Property: ymail-3
Content-Type: text/plain; charset="utf-8"
Message-ID: <76A54282-2933-4DAA-A891-6AD4B2171DCD [...] simplemood.com>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -10.599
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id A04A5240A3C for <cpan-bug+IO-Compress [...] hipster.bestpractical.com>; Sun, 18 Jul 2010 17:45:32 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QUCtanJVmXSk for <cpan-bug+IO-Compress [...] hipster.bestpractical.com>; Sun, 18 Jul 2010 17:45:30 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 811D4240A00 for <bug-IO-Compress [...] rt.cpan.org>; Sun, 18 Jul 2010 17:45:30 -0400 (EDT)
Received: (qmail 16174 invoked by uid 103); 18 Jul 2010 21:47:15 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 18 Jul 2010 21:47:15 -0000
Received: from smtp112.sbc.mail.mud.yahoo.com (HELO smtp112.sbc.mail.mud.yahoo.com) (68.142.198.107) by 16.mx.develooper.com (qpsmtpd/0.80) with SMTP; Sun, 18 Jul 2010 14:47:13 -0700
Received: (qmail 27459 invoked from network); 18 Jul 2010 21:47:10 -0000
Received: from [192.168.1.133] (webmaster [...] 70.140.37.101 with plain) by smtp112.sbc.mail.mud.yahoo.com with SMTP; 18 Jul 2010 14:47:10 -0700 PDT
Delivered-To: cpan-bug+IO-Compress [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #59506] trimming down imports/exports would gain speed and save memory
Return-Path: <webmaster [...] simplemood.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+IO-Compress [...] hipster.bestpractical.com
X-RT-Mail-Extension: io-compress
Date: Sun, 18 Jul 2010 16:47:10 -0500
X-Spam-Level:
To: bug-IO-Compress [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Dan Muey <webmaster [...] simplemood.com>
RT-Message-ID: <rt-3.8.HEAD-2369-1279489638-1601.59506-0-0 [...] rt.cpan.org>
Content-Length: 843
Download (untitled) / with headers
text/plain 843b
Thank you Paul, I'll gather some specifics and post details Monday. On Jul 18, 2010, at 4:41 PM, Paul Marquess via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=59506 > > > Hi Dan, > > In principle I don't have a problem with what you suggest, but I'd like > to have a feel for what it saves in both time & memory. The fully > qualified names for variables & subs can get quite long. > > Rather than disabling all importing or symbols, have you looked into > only importing those that are actually used? > > Also, one other thing to consider - my compression modules build with > all versions of Perl from 5.004 onwards. Any patch must take that into > account. Don't worry if you don't have a full suite of Perl binaries - I > have a setup that allows me to test my modules against all Perl versions. > > cheers > Paul
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-2369-1279489638-1601.59506-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
References: <RT-Ticket-59506 [...] rt.cpan.org> <rt-3.8.HEAD-2366-1279489295-1215.59506-6-0 [...] rt.cpan.org> <76A54282-2933-4DAA-A891-6AD4B2171DCD [...] simplemood.com> <rt-3.8.HEAD-2369-1279489638-1601.59506-0-0 [...] rt.cpan.org>
Content-Type: multipart/mixed; boundary="----------=_1280791463-2143-17"
Message-ID: <rt-3.8.HEAD-2143-1280791463-1615.59506-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 328
Download (untitled) / with headers
text/plain 328b
The attached report is regarding the symbols ( generated from this script http://drmuey.com/? do=page&id=102 ) Summary is: Files : 27 Imports: 88 Symbols: 579 For memory and time we've found an average of .25MB memory saving w/ the IO package. We'll work on a patch of IO::Compress for easy comparison soon, thanks!
MIME-Version: 1.0
Subject: IO-Compress-2.030.txt
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain; charset="utf-8"; name="IO-Compress-2.030.txt"
Content-Disposition: inline; filename="IO-Compress-2.030.txt"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 36912

Message body is not shown because it is too large.

MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-2143-1280791463-1615.59506-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <RT-Ticket-59506 [...] rt.cpan.org> <rt-3.8.HEAD-2366-1279489295-1215.59506-6-0 [...] rt.cpan.org> <76A54282-2933-4DAA-A891-6AD4B2171DCD [...] simplemood.com> <rt-3.8.HEAD-2369-1279489638-1601.59506-0-0 [...] rt.cpan.org> <rt-3.8.HEAD-2143-1280791463-1615.59506-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-2143-1280819681-802.59506-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 13
Thanks Daniel


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.