Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla CPAN distribution.

Report information
The Basics
Id: 57841
Status: open
Priority: 0/
Queue: Dist-Zilla

People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: Check for duplicate tarball name before uploading
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 218
Download (untitled) / with headers
text/plain 218b
It would be good to check for a duplicate tarball before uploading to CPAN. (Either in DZ or as a feature in CPAN::Uploader). This would be most useful to catch duplicate uploads on the same day with auto-versioning.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-10879-1276084575-100.57841-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 485
Download (untitled) / with headers
text/plain 485b
On 2010-05-25 23:35:01, DAGOLDEN wrote: Show quoted text
> It would be good to check for a duplicate tarball before uploading to > CPAN. (Either in DZ or as a feature in CPAN::Uploader). This would be > most useful to catch duplicate uploads on the same day with auto-versioning.
I'm not opposed, but I'm not sure where we want to look. We'd want to check "incoming" as well as figure out if there's already a file with that name, indexed, under anybody's author dir. Seems non-trivial. -- rjbs
From xdaveg [...] gmail.com Wed Jun 9 09: 43:47 2010
MIME-Version: 1.0
X-Spam-Status: No, score=-9.913 tagged_above=-99.9 required=10 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8, SPF_NEUTRAL=0.686] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-10879-1276084576-1749.57841-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
References: <RT-Ticket-57841 [...] rt.cpan.org> <rt-3.8.HEAD-10879-1276084576-1749.57841-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <AANLkTikaYJReOQ9cPhWXVNbSOSroDYsyZCbuM5YCXCT- [...] mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
X-Spam-Score: -9.913
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Authentication-Results: hipster.bestpractical.com (amavisd-new); domainkeys=pass header.sender=xdaveg [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 84D13240879 for <cpan-bug+Dist-Zilla [...] hipster.bestpractical.com>; Wed, 9 Jun 2010 09:43:47 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qoR4GB8vE+kA for <cpan-bug+Dist-Zilla [...] hipster.bestpractical.com>; Wed, 9 Jun 2010 09:43:45 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id C28E9240874 for <bug-Dist-Zilla [...] rt.cpan.org>; Wed, 9 Jun 2010 09:43:44 -0400 (EDT)
Received: (qmail 30417 invoked by uid 103); 9 Jun 2010 13:44:41 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 9 Jun 2010 13:44:41 -0000
Received: from mail-gw0-f50.google.com (HELO mail-gw0-f50.google.com) (74.125.83.50) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 09 Jun 2010 06:44:37 -0700
Received: by gwaa20 with SMTP id a20so3097890gwa.9 for <bug-Dist-Zilla [...] rt.cpan.org>; Wed, 09 Jun 2010 06:44:26 -0700 (PDT)
Received: by 10.150.160.6 with SMTP id i6mr156928ybe.43.1276091066179; Wed, 09 Jun 2010 06:44:26 -0700 (PDT)
Received: by 10.150.139.11 with HTTP; Wed, 9 Jun 2010 06:44:06 -0700 (PDT)
Delivered-To: cpan-bug+Dist-Zilla [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #57841] Check for duplicate tarball name before uploading
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:content-type :content-transfer-encoding; b=i9BVNHohluh3vvJaCOw0aCxlZP63ooMMhdl9mtktlFVcppy2jeU8LzBoQl9t1EEnUt 9uzzjBT7Ruv4i7M/g4K9hGCpys/2oHLyaWxMzaTrKcTrkXwU7RfzvqFqIaItB0YbPwZi mV7HVT4A1k/410e9DyHmPviyGFwyiMmW2SdcQ=
Return-Path: <xdaveg [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:content-type:content-transfer-encoding; bh=w4e2V4fCoufL6WV4H/a+MNqOnp8NnRM+lrmzcWugud8=; b=mTa4uqvAR/ezeuBvW/DWiRzx5IINVsW1VXmaA82bB3mp8AMvj1IdrUEtFft2qLAFpl xzXF1Dx39vBpMMVlBMRv/FDjIzLZDkNuLRJCgyvxSX0WXkfQ4jaPPJpz7nQp8Agce/Pe a0QGgvBJe1dycmqU407qQen4lu0cVirChyljY=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Dist-Zilla [...] hipster.bestpractical.com
X-RT-Mail-Extension: dist-zilla
X-Google-Sender-Auth: N8I5U0ybaIWfToq-z_CnefqcwmA
Sender: xdaveg [...] gmail.com
Date: Wed, 9 Jun 2010 09:44:06 -0400
X-Spam-Level:
To: bug-Dist-Zilla [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: David Golden <dagolden [...] cpan.org>
RT-Message-ID: <rt-3.8.HEAD-10878-1276091085-929.57841-0-0 [...] rt.cpan.org>
Content-Length: 1193
Download (untitled) / with headers
text/plain 1.1k
On Wed, Jun 9, 2010 at 7:56 AM, Ricardo Signes via RT <bug-Dist-Zilla@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=57841 > > > On 2010-05-25 23:35:01, DAGOLDEN wrote:
>> It would be good to check for a duplicate tarball before uploading to >> CPAN.  (Either in DZ or as a feature in CPAN::Uploader).  This would be >> most useful to catch duplicate uploads on the same day with auto-versioning.
> > I'm not opposed, but I'm not sure where we want to look.  We'd want to check "incoming" as well > as figure out if there's already a file with that name, indexed, under anybody's author dir.
I was thinking it could be more along the lines of checking for the tarball under the author's directory. e.g. If I'm DAGOLDEN and uploading Foo-Bar-1.23.tar.gz, to just do a HEAD check on http://$cpan_mirror/authors/id/D/DA/DAGOLDEN/Foo-Bar-1.23.tar.gz. If the CPAN mirror is a "fast" one, then as long as authors aren't uploading more than once per minute, the check would work reasonably well. Checking incoming is probably more than is necessary. And nothing will help for duplicates that were deleted but are in the PAUSE database and would be rejected. -- David
From rjbs [...] cpan.org Wed Jun 9 10: 13:35 2010
MIME-Version: 1.0
X-Spam-Status: No, score=-10.599 tagged_above=-99.9 required=10 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-10878-1276091086-1973.57841-5-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
References: <RT-Ticket-57841 [...] rt.cpan.org> <rt-3.8.HEAD-10879-1276084576-1749.57841-6-0 [...] rt.cpan.org> <AANLkTikaYJReOQ9cPhWXVNbSOSroDYsyZCbuM5YCXCT- [...] mail.gmail.com> <rt-3.8.HEAD-10878-1276091086-1973.57841-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20100609141418.GA15059 [...] cancer.codesimply.com>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -10.599
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] pobox.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id E04CC24086F for <cpan-bug+Dist-Zilla [...] hipster.bestpractical.com>; Wed, 9 Jun 2010 10:13:35 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W-3QTJAjA4LZ for <cpan-bug+Dist-Zilla [...] hipster.bestpractical.com>; Wed, 9 Jun 2010 10:13:30 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 168EF240874 for <bug-Dist-Zilla [...] rt.cpan.org>; Wed, 9 Jun 2010 10:13:29 -0400 (EDT)
Received: (qmail 4382 invoked by uid 103); 9 Jun 2010 14:14:27 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 9 Jun 2010 14:14:27 -0000
Received: from b-pb-sasl-quonix.pobox.com (HELO sasl.smtp.pobox.com) (208.72.237.35) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 09 Jun 2010 07:14:23 -0700
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 1C6F4AE654 for <bug-Dist-Zilla [...] rt.cpan.org>; Wed, 9 Jun 2010 10:14:20 -0400 (EDT)
Received: from b-pb-sasl-quonix. (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 18DD5AE653 for <bug-Dist-Zilla [...] rt.cpan.org>; Wed, 9 Jun 2010 10:14:20 -0400 (EDT)
Received: from cancer.codesimply.com (unknown [70.87.222.20]) by b-sasl-quonix.pobox.com (Postfix) with ESMTPA id ECA69AE652 for <bug-Dist-Zilla [...] rt.cpan.org>; Wed, 9 Jun 2010 10:14:19 -0400 (EDT)
Received: by cancer.codesimply.com (Postfix, from userid 1000) id 8BCB92B8BD6; Wed, 9 Jun 2010 10:14:18 -0400 (EDT)
Delivered-To: cpan-bug+Dist-Zilla [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #57841] Check for duplicate tarball name before uploading
User-Agent: Mutt/1.5.20 (2009-06-14)
Return-Path: <rjbs [...] cpan.org>
Dkim-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=date:from:to :subject:message-id:references:mime-version:content-type :in-reply-to; s=sasl; bh=hk702S6ZDteXVj8zY7DG6IhaCNQ=; b=NNE23xF yaqYQVQsNi7v6hXeZh5WGKLIyeHyunNxl0NFpM5fr0K+ARZFEs4WtJNqvQWkSyo/ 3YUrbVIrb2/PJhmajXBMLq3UWUI83xY5PG9vIJaa6IsbdvFwSn6rfdRQGD6JE8RI BlLL2fhGZbrjGitaiEUBhgsXT3/ydI40dgqk=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Dist-Zilla [...] hipster.bestpractical.com
X-RT-Mail-Extension: dist-zilla
X-Message-Flag: Warning: Your computer is currently broadcasting an IP address.
Date: Wed, 9 Jun 2010 10:14:18 -0400
X-Spam-Level:
X-Planet: Planet of the Apes
To: David Golden via RT <bug-Dist-Zilla [...] rt.cpan.org>
X-Pobox-Relay-ID: 4BC18B1E-73D1-11DF-9323-68E3016DD5F0-07314517!b-pb-sasl-quonix.pobox.com
From: Ricardo Signes <rjbs [...] cpan.org>
RT-Message-ID: <rt-3.8.HEAD-10882-1276092874-1336.57841-0-0 [...] rt.cpan.org>
Content-Length: 523
Download (untitled) / with headers
text/plain 523b
* David Golden via RT <bug-Dist-Zilla@rt.cpan.org> [2010-06-09T09:44:46] Show quoted text
> Checking incoming is probably more than is necessary. And nothing > will help for duplicates that were deleted but are in the PAUSE > database and would be rejected.
Actually, incoming is where I've heard about this problem most often, from people who have accidentally added UploadToCPAN twice. Of course, this is pretty crazy and the current behavior (throw an error when the second upload is attempted) is probably okay. So, okay. -- rjbs
From xdaveg [...] gmail.com Wed Jun 9 10: 18:43 2010
MIME-Version: 1.0
X-Spam-Status: No, score=-9.913 tagged_above=-99.9 required=10 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8, SPF_NEUTRAL=0.686] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-10882-1276092874-1667.57841-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
References: <RT-Ticket-57841 [...] rt.cpan.org> <rt-3.8.HEAD-10879-1276084576-1749.57841-6-0 [...] rt.cpan.org> <AANLkTikaYJReOQ9cPhWXVNbSOSroDYsyZCbuM5YCXCT- [...] mail.gmail.com> <rt-3.8.HEAD-10878-1276091086-1973.57841-5-0 [...] rt.cpan.org> <20100609141418.GA15059 [...] cancer.codesimply.com> <rt-3.8.HEAD-10882-1276092874-1667.57841-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <AANLkTik_oGp8zwV1UFYOCMrFgDagLQuzHY2oMAXf_sOj [...] mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
X-Spam-Score: -9.913
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Authentication-Results: hipster.bestpractical.com (amavisd-new); domainkeys=pass header.sender=xdaveg [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 28428240873 for <cpan-bug+Dist-Zilla [...] hipster.bestpractical.com>; Wed, 9 Jun 2010 10:18:43 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EIrY+qTmVe8P for <cpan-bug+Dist-Zilla [...] hipster.bestpractical.com>; Wed, 9 Jun 2010 10:18:41 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 291DD24086F for <bug-Dist-Zilla [...] rt.cpan.org>; Wed, 9 Jun 2010 10:18:41 -0400 (EDT)
Received: (qmail 5807 invoked by uid 103); 9 Jun 2010 14:19:38 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 9 Jun 2010 14:19:38 -0000
Received: from mail-gy0-f178.google.com (HELO mail-gy0-f178.google.com) (209.85.160.178) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 09 Jun 2010 07:19:37 -0700
Received: by gyh3 with SMTP id 3so3575313gyh.9 for <bug-Dist-Zilla [...] rt.cpan.org>; Wed, 09 Jun 2010 07:19:34 -0700 (PDT)
Received: by 10.150.214.1 with SMTP id m1mr87922ybg.434.1276093174180; Wed, 09 Jun 2010 07:19:34 -0700 (PDT)
Received: by 10.150.139.11 with HTTP; Wed, 9 Jun 2010 07:19:14 -0700 (PDT)
Delivered-To: cpan-bug+Dist-Zilla [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #57841] Check for duplicate tarball name before uploading
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:content-type :content-transfer-encoding; b=rYanqEAdsg9KAHICkvdvpsdgZzlA/JPclxrxpGEMFFG0FMBGaOAronwmfsYrVYmYpt jq9+JKdLSrxc1I/qzz1rT+MFkRHd0vKsoGk1mAju3GFaKpPR8qK9iLNusYgHsO5jb/Fd aV0kqweeRsVZQWAUKGDIab7/iPwcCYIEY3QjU=
Return-Path: <xdaveg [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:content-type:content-transfer-encoding; bh=/dLnAL/8BlM/uvoIKOlwbN5OCxINUwQyFs4mzYEMs+Q=; b=bu5wAymrzqub6BtqH0yEkF/+ZLoCq9RpBmFQtHZch47vyUoqIXx9J4O4bXXKqxOUSl Tb3naKIbk4W2liKcrkyjgn2eaE5a2LaxUPE3PbwTGTAQggL23tIcrerFClYdEwlJWmvP 3Uoq06CZC33G4Z9osF/fsJuf2oiCSmWM+tO/8=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Dist-Zilla [...] hipster.bestpractical.com
X-RT-Mail-Extension: dist-zilla
X-Google-Sender-Auth: a0HWfdF9UJMFdrtLDSlCX6s-Afw
Sender: xdaveg [...] gmail.com
Date: Wed, 9 Jun 2010 10:19:14 -0400
X-Spam-Level:
To: bug-Dist-Zilla [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: David Golden <dagolden [...] cpan.org>
RT-Message-ID: <rt-3.8.HEAD-10890-1276093181-1381.57841-0-0 [...] rt.cpan.org>
Content-Length: 807
Download (untitled) / with headers
text/plain 807b
On Wed, Jun 9, 2010 at 10:14 AM, Ricardo Signes via RT <bug-Dist-Zilla@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=57841 > > > * David Golden via RT <bug-Dist-Zilla@rt.cpan.org> [2010-06-09T09:44:46]
>> Checking incoming is probably more than is necessary.  And nothing >> will help for duplicates that were deleted but are in the PAUSE >> database and would be rejected.
> > Actually, incoming is where I've heard about this problem most often, from > people who have accidentally added UploadToCPAN twice.  Of course, this is > pretty crazy and the current behavior (throw an error when the second upload is > attempted) is probably okay.  So, okay.
For me, it's more likely to be forgetting N=1 with an auto-version, particularly with the TZ difference factored in. David
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-10890-1276093181-1381.57841-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <RT-Ticket-57841 [...] rt.cpan.org> <rt-3.8.HEAD-10879-1276084576-1749.57841-6-0 [...] rt.cpan.org> <AANLkTikaYJReOQ9cPhWXVNbSOSroDYsyZCbuM5YCXCT- [...] mail.gmail.com> <rt-3.8.HEAD-10878-1276091086-1973.57841-5-0 [...] rt.cpan.org> <20100609141418.GA15059 [...] cancer.codesimply.com> <rt-3.8.HEAD-10882-1276092874-1667.57841-6-0 [...] rt.cpan.org> <AANLkTik_oGp8zwV1UFYOCMrFgDagLQuzHY2oMAXf_sOj [...] mail.gmail.com> <rt-3.8.HEAD-10890-1276093181-1381.57841-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-2598-1319057562-634.57841-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 238
Download (untitled) / with headers
text/plain 238b
I'll just mention that my ArchiveRelease plugin provides a partial solution to this. It'll only catch duplicate releases made on the same machine (or at least from machines that archive to the same network share), but it might help you.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.14-3187-1374782829-1552.57841-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 332
Download (untitled) / with headers
text/plain 332b
Right now, if I upload a duplicate tarball, UploadToCPAN fails because PAUSE says "no, that's a dupe," and it gives an error response. What does this gain over that? Also, what if we just got that error message and instead of dying "509 BAD QUERY" (or whatever) we turned it into "there's already a duplicate, aborting." -- rjbs
MIME-Version: 1.0
In-Reply-To: <rt-4.0.14-3187-1374782829-1552.57841-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.14-3187-1374782829-1552.57841-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.14-3188-1374784688-1671.57841-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 529
Download (untitled) / with headers
text/plain 529b
On Thu Jul 25 16:07:09 2013, RJBS wrote: Show quoted text
> Right now, if I upload a duplicate tarball, UploadToCPAN fails because > PAUSE says "no, that's a dupe," and it gives an error response.
I wonder if that's new-ish. Show quoted text
> Also, what if we just got that error message and instead of dying "509 > BAD QUERY" (or whatever) we turned it into "there's already a > duplicate, aborting."
I like that, but are we sure 509 is always a dupe message? I'm not opposed to patching PAUSE to give a better error that we could show to users, either.
From rjbs [...] cpan.org Thu Jul 25 17: 09:27 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-5.895 tagged_above=-99.9 required=10 tests=[AWL=1.005, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-4.0.14-3188-1374784688-749.57841-5-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-57841 [...] rt.cpan.org> <rt-4.0.14-3187-1374782829-1552.57841-5-0 [...] rt.cpan.org> <rt-4.0.14-3188-1374784688-749.57841-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20130725210909.GA4166 [...] cancer.codesimply.com>
Content-Type: multipart/signed; boundary="J2SCkAp4GZ/dPZZf"; micalg="pgp-sha1"; protocol="application/pgp-signature"
X-Spam-Score: -5.895
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] pobox.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 1D0B0240FE1 for <cpan-bug+Dist-Zilla [...] hipster.bestpractical.com>; Thu, 25 Jul 2013 17:09:27 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jFiRxTzSX7nm for <cpan-bug+Dist-Zilla [...] hipster.bestpractical.com>; Thu, 25 Jul 2013 17:09:25 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 7C68D240FDA for <bug-Dist-Zilla [...] rt.cpan.org>; Thu, 25 Jul 2013 17:09:25 -0400 (EDT)
Received: (qmail 6358 invoked by alias); 25 Jul 2013 21:09:24 -0000
Received: from b-pb-sasl-quonix.pobox.com (HELO smtp.pobox.com) (208.72.237.35) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Thu, 25 Jul 2013 14:09:16 -0700
Received: from smtp.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 93F7B338BC for <bug-Dist-Zilla [...] rt.cpan.org>; Thu, 25 Jul 2013 21:09:11 +0000 (UTC)
Received: from b-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 86D25338BB for <bug-Dist-Zilla [...] rt.cpan.org>; Thu, 25 Jul 2013 21:09:11 +0000 (UTC)
Received: from cancer.codesimply.com (unknown [70.87.222.20]) by b-sasl-quonix.pobox.com (Postfix) with ESMTPA id 52062338B9 for <bug-Dist-Zilla [...] rt.cpan.org>; Thu, 25 Jul 2013 21:09:10 +0000 (UTC)
Received: by cancer.codesimply.com (Postfix, from userid 1000) id 31FAD42273D; Thu, 25 Jul 2013 17:09:09 -0400 (EDT)
Delivered-To: cpan-bug+Dist-Zilla [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #57841] Check for duplicate tarball name before uploading
User-Agent: Mutt/1.5.21 (2010-09-15)
Return-Path: <rjbs [...] cpan.org>
Dkim-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=date:from:to :subject:message-id:references:mime-version:content-type :in-reply-to; s=sasl; bh=yNiXyjATJvu0iJeyChOYeCwE67o=; b=L6U9Cm6 xFc8j13hh4jLLWInIziNUdln7yZPhSeuNqJspuO1W70Mh3PaEnUW7wmg/5RLvIwS jDerlnvv2PEUtIZ9N/pX4dFu+iw34AbLGHWi2txisnnTbKKISIONfkpdCo+iQn5e iLWGxPQ8Z4ntSkP8c+kslCgaqibIH+SzQZ5A=
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Dist-Zilla [...] hipster.bestpractical.com
X-RT-Mail-Extension: dist-zilla
X-Message-Flag: Warning: Your computer is current broadcasting an IP address.
Date: Thu, 25 Jul 2013 17:09:09 -0400
X-Spam-Level:
X-Planet: Planet of the Apes
To: David Golden via RT <bug-Dist-Zilla [...] rt.cpan.org>
X-Pobox-Relay-ID: 7341E612-F56E-11E2-88B7-E84251E3A03C-07314517!b-pb-sasl-quonix.pobox.com
From: Ricardo Signes <rjbs [...] cpan.org>
RT-Message-ID: <rt-4.0.14-17394-1374786567-853.57841-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 854
Download (untitled) / with headers
text/plain 854b
* David Golden via RT <bug-Dist-Zilla@rt.cpan.org> [2013-07-25T16:38:08] Show quoted text
> Queue: Dist-Zilla > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=57841 > > > On Thu Jul 25 16:07:09 2013, RJBS wrote:
> > Right now, if I upload a duplicate tarball, UploadToCPAN fails because > > PAUSE says "no, that's a dupe," and it gives an error response.
> > I wonder if that's new-ish.
I'm pretty sure it's been there for 5 years or so. Show quoted text
> > Also, what if we just got that error message and instead of dying "509 > > BAD QUERY" (or whatever) we turned it into "there's already a > > duplicate, aborting."
> > I like that, but are we sure 509 is always a dupe message?
I'm pretty darn sure, but I bet we can find out! ;) Show quoted text
> I'm not opposed to patching PAUSE to give a better error that we could show > to users, either.
That's good, too. -- rjbs
Content-Description: Digital signature
Content-Type: application/pgp-signature; name="signature.asc"
Content-Length: 490
Download signature.asc
application/pgp-signature 490b

Message body not shown because it is not plain text.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.