Skip Menu |
 

This queue is for tickets about the Test-Harness CPAN distribution.

Report information
The Basics
Id: 5778
Status: resolved
Priority: 0/
Queue: Test-Harness

People
Owner: Nobody in particular
Requestors: darrell [...] sirsi.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Return-Path: <andy [...] petdance.com>
Delivered-To: cpan-bug+test-harness [...] pallas.eruditorum.org
Received: from baby.petdance.com (h-68-164-161-90.chcgilgm.covad.net [68.164.161.90]) by pallas.eruditorum.org (Postfix) with ESMTP id 52AFB11292 for <bug-test-harness [...] rt.cpan.org>; Wed, 24 Mar 2004 01:02:02 -0500 (EST)
Received: by baby.petdance.com (Postfix, from userid 500) id C9FD443D9A; Wed, 24 Mar 2004 00:02:01 -0600 (CST)
X-Original-To: andy [...] petdance.com
Received: from aberlour1.sirsi.com (aberlour.sirsi.com [150.147.64.10]) by baby.petdance.com (Postfix) with ESMTP id D8A5B43D9B for <andy [...] petdance.com>; Tue, 23 Mar 2004 18:04:11 -0600 (CST)
Received: from glenlivet.sirsi.com (bushmill.sirsi.com [150.147.19.238]) by aberlour1.sirsi.com (8.12.10/8.12.10) with SMTP id i2NNnUx3020092 for <andy [...] petdance.com>; Tue, 23 Mar 2004 17:49:30 -0600 (CST)
X-Mimeole: Produced By Microsoft Exchange V6.0.6487.1
MIME-Version: 1.0
Disposition-Notification-To: "Darrell Gammill" <darrell [...] sirsi.com>
Subject: Patch to 'prove' Script Found on CPAN
Date: Tue, 23 Mar 2004 18:02:17 -0600
Message-Id: <1074B85B4E2938499546CF4FA2C3FF1604F7BF [...] glenfiddich.sirsi.pvt>
X-MS-Has-Attach:
X-MS-Tnef-Correlator:
Thread-Topic: Patch to 'prove' Script Found on CPAN
Thread-Index: AcQRM0UgvtsoOeetSYOLqnKt0xWclw==
From: "Darrell Gammill" <darrell [...] sirsi.com>
To: <andy [...] petdance.com>
X-Scanned-BY: MIMEDefang 2.39
Resent-From: andy [...] petdance.com
Resent-Date: Wed, 24 Mar 2004 00:02:01 -0600
Resent-To: bug-test-harness [...] rt.cpan.org
Resent-Message-Id: <20040324060201.C9FD443D9A [...] baby.petdance.com>
Content-Disposition: inline
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: iso-8859-1
Content-Length: 1508
Download (untitled) / with headers
text/plain 1.4k
I have a suggested change to 'prove' which I found listed with Test::Harness 2.40 on CPAN. This address differences in how Windows processes wild card characters in command line arguments verse UNIX. In UNIX, something like 'prove t/*.t' has the wildcard filenames expanded before passing them to the program. So, if t has two file, test1.t and test2.t, the command executed is as follows: prove t/test1.t t/test2.t In Windows, the wildcard is not expanded and the program is faced with something like 'open(FH, "</t*.t");' which fails. The workaround I have found works, at least in Active State's perl 5.6.1 is to 'glob' the elements of @ARGV and push the results into a separate list. the change to prove would be as follows: As reads: my @tests; @ARGV = File::Spec->curdir unless @ARGV; push( @tests, -d $_ ? all_in( $_ ) : $_ ) for @ARGV; Should read: my (@tests, @file_list); @ARGV = File::Spec->curdir unless @ARGV; foreach (@ARGV) { push @file_list, glob; } push( @tests, -d $_ ? all_in( $_ ) : $_ ) for @file_list; There maybe better ways of doing it. There are probably options I missed. If either is true, let me know. I would be interested in seeing them. Tnx, Dgg BTW: I noticed Rocco Caputo has posted an update to Test::Harness on CPAN last February since your update last December. Can there be multiple maintainers? Is this a late arrival? I'm still trying to get a handle on this CPAN thing. Tnx Darrell Gammill System Support Specialist darrell@sirsi.com
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.405 (Entity 5.404)
X-RT-Original-Encoding: iso-8859-1
Content-Length: 324
Download (untitled) / with headers
text/plain 324b
Show quoted text
> my (@tests, @file_list); > @ARGV = File::Spec->curdir unless @ARGV; > foreach (@ARGV) { push @file_list, glob; } > push( @tests, -d $_ ? all_in( $_ ) : $_ ) for @file_list;
I redid as push( @tests, -d $_ ? all_in( $_ ) : $_ ) for map { glob } @ARGV; This patch is made in 2.41_01, which I hope to release tonight.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.