Skip Menu |
 

This queue is for tickets about the PerlIO-subfile CPAN distribution.

Report information
The Basics
Id: 55502
Status: open
Priority: 0/
Queue: PerlIO-subfile

People
Owner: Nobody in particular
Requestors: SAFRONOV [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.08
Fixed in: (no value)



Subject: binmode() fix
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 595
Download (untitled) / with headers
text/plain 595b
Only in PerlIO-subfile-0.08-my: Makefile.old diff -u PerlIO-subfile-0.08/subfile.xs PerlIO-subfile-0.08-my/subfile.xs Apply this patch to address binmode(FH) problem. --- PerlIO-subfile-0.08/subfile.xs 2004-05-14 00:39:29.000000000 +0400 +++ PerlIO-subfile-0.08-my/subfile.xs 2009-04-01 00:17:26.000000000 +0400 @@ -296,7 +296,7 @@ sizeof(PerlIO_funcs), "subfile", sizeof(PerlIOSubfile), - PERLIO_K_BUFFERED, + PERLIO_K_BUFFERED|PERLIO_K_RAW, PerlIOSubfile_pushed, PerlIOBase_noop_ok, PerlIOBuf_open, Common subdirectories: PerlIO-subfile-0.08/t and PerlIO-subfile-0.08-my/t
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-24042-1498074984-1176.55502-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 975
Download (untitled) / with headers
text/plain 975b
On Fri Mar 12 12:02:49 2010, SAFRONOV wrote: Show quoted text
> Only in PerlIO-subfile-0.08-my: Makefile.old > diff -u PerlIO-subfile-0.08/subfile.xs PerlIO-subfile-0.08-my/subfile.xs > Apply this patch to address binmode(FH) problem. > > --- PerlIO-subfile-0.08/subfile.xs 2004-05-14 00:39:29.000000000 +0400 > +++ PerlIO-subfile-0.08-my/subfile.xs 2009-04-01 00:17:26.000000000 +0400
Sorry for the extremely long delay in replying - this ticket got overlooked. What would a regression test for this bug look like? Something like a test file that contains a "\r\n" sequence on disk, where the test code reads this, *and* correctly does binmode on the handle it has with the subfile layer, but the test fails (without this patch) because the data read in is "\n"? Or make sure the test file has something after the "\r\n" on disk, and what should be read in ends with the "\r\n", but without the patch what one gets ends with "\n" and a byte of trailing "garbage"? Nicholas Clark
MIME-Version: 1.0
X-Spam-Status: No, score=-4.233 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, HTML_MESSAGE=0.001, HTML_MIME_NO_HTML_TAG=0.377, MIME_HTML_ONLY=0.723, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-4.0.18-24042-1498074984-1408.55502-6-0 [...] rt.cpan.org>
X-Mailer: Yamail [ http://yandex.ru ] 5.0
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-55502 [...] rt.cpan.org> <rt-4.0.18-24042-1498074984-1408.55502-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <2164871498118458 [...] web45j.yandex.ru>
content-type: text/html; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -4.233
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] yandex.ru
Authentication-Results: mxback8o.mail.yandex.net; dkim=pass header.i= [...] yandex.ru
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 59BFA2403A0 for <cpan-bug+perlio-subfile [...] hipster.bestpractical.com>; Thu, 22 Jun 2017 04:02:52 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f4NCsnhskGWo for <cpan-bug+perlio-subfile [...] hipster.bestpractical.com>; Thu, 22 Jun 2017 04:02:50 -0400 (EDT)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id C10A12402B6 for <bug-perlio-subfile [...] rt.cpan.org>; Thu, 22 Jun 2017 04:02:49 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id C51E111D3B5 for <bug-perlio-subfile [...] rt.cpan.org>; Thu, 22 Jun 2017 01:02:48 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id 6864011D878 for <bug-perlio-subfile [...] rt.cpan.org>; Thu, 22 Jun 2017 01:02:45 -0700 (PDT)
Received: from forward2o.cmail.yandex.net (forward2o.cmail.yandex.net [37.9.109.243]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 6B47911D3B5 for <bug-perlio-subfile [...] rt.cpan.org>; Thu, 22 Jun 2017 01:02:39 -0700 (PDT)
Received: from mxback8o.mail.yandex.net (mxback8o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::22]) by forward2o.cmail.yandex.net (Yandex) with ESMTP id 83A2720D5D; Thu, 22 Jun 2017 11:00:59 +0300 (MSK)
Received: from web45j.yandex.ru (web45j.yandex.ru [5.45.198.148]) by mxback8o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Xjz8iwKCV6-0wXqXCpS; Thu, 22 Jun 2017 11:00:59 +0300
Received: by web45j.yandex.ru with HTTP; Thu, 22 Jun 2017 11:00:58 +0300
Delivered-To: cpan-bug+perlio-subfile [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #55502] binmode() fix
Return-Path: <vlad [...] yandex.ru>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1498118459; bh=A7slN8OwawYdDLxHcGh45bv2DcbsLRbP6lW6PdGQftQ=; h=From:To:In-Reply-To:References:Subject:Message-Id:Date; b=a93LvSb/PQOsU3i0qZh+xj6uujfcFEHten8lDO8XC+jBuWWUR/EKZzzfBUrEMB8Sg 6W2/GxcbXmeFn4c1pC+OUikGUhv44unVogGJ/GmJl12mlGQRHmhMcj/VhngryoQOOS SsLMQC3CeayLmJzhJsxHLVVZnnikzG5aQFzQAsRk=
X-Original-To: cpan-bug+perlio-subfile [...] hipster.bestpractical.com
X-RT-Mail-Extension: perlio-subfile
Date: Thu, 22 Jun 2017 11:00:58 +0300
X-PMX-Spam: Gauge=XIIIIII, Probability=16%, Report=' CTYPE_JUST_HTML 0.848, HTML_MIME_NO_HTML_TAG 0.8, FROM_NAME_ONE_WORD 0.05, BODYTEXTH_SIZE_10000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CTE_BASE64 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, REFERENCES 0, SINGLE_URI_IN_BODY 0, SPF_PASS 0, URI_ENDS_IN_HTML 0, URI_WITH_PATH_ONLY 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CTYPE_HTML 0, __CTYPE_IS_HTML 0, __DATE_TZ_RU 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HTML_AHREF_TAG 0, __HTML_TAG_DIV 0, __HTTPS_URI 0, __IN_REP_TO 0, __MIME_HTML 0, __MIME_HTML_ONLY 0, __MIME_TEXT_H 0, __MIME_TEXT_H1 0, __MIME_VERSION 0, __MULTIPLE_URI_TEXT 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __REFERENCES 0, __RUS_WEBMAIL_FROM 0, __RUS_WEBMAIL_RCVD 0, __SANE_MSGID 0, __SINGLE_URI_HTML 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_NO_NAME 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-Greylist: delayed 98 seconds by postgrey-1.34 at xx1.develooper.com; Thu, 22 Jun 2017 01:02:40 PDT
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.6.22.75416
To: "bug-PerlIO-subfile [...] rt.cpan.org" <bug-perlio-subfile [...] rt.cpan.org>, "SAFRONOV [...] cpan.org" <safronov [...] cpan.org>
Content-Transfer-Encoding: base64
From: Vlad. <vlad [...] yandex.ru>
RT-Message-ID: <rt-4.0.18-6024-1498118573-454.55502-0-0 [...] rt.cpan.org>
Content-Length: 1524
Ouch.. I need to recall the where exactly I hit that bug.
 
-- 
V.
 
 
 
21.06.2017, 22:56, "Nicholas Clark via RT" <bug-perlio-subfile@rt.cpan.org>:
Show quoted text

<URL: https://rt.cpan.org/Ticket/Display.html?id=55502 >

On Fri Mar 12 12:02:49 2010, SAFRONOV wrote:

 Only in PerlIO-subfile-0.08-my: Makefile.old
 diff -u PerlIO-subfile-0.08/subfile.xs PerlIO-subfile-0.08-my/subfile.xs
 Apply this patch to address binmode(FH) problem.

 --- PerlIO-subfile-0.08/subfile.xs 2004-05-14 00:39:29.000000000 +0400
 +++ PerlIO-subfile-0.08-my/subfile.xs 2009-04-01 00:17:26.000000000 +0400


Sorry for the extremely long delay in replying - this ticket got overlooked.

What would a regression test for this bug look like? Something like a test file that contains a "\r\n" sequence on disk, where the test code reads this, *and* correctly does binmode on the handle it has with the subfile layer, but the test fails (without this patch) because the data read in is "\n"?

Or make sure the test file has something after the "\r\n" on disk, and what should be read in ends with the "\r\n", but without the patch what one gets ends with "\n" and a byte of trailing "garbage"?

Nicholas Clark

MIME-Version: 1.0
X-Spam-Status: No, score=-4.233 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, HTML_MESSAGE=0.001, HTML_MIME_NO_HTML_TAG=0.377, MIME_HTML_ONLY=0.723, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-4.0.18-6024-1498118573-552.55502-6-0 [...] rt.cpan.org>
X-Mailer: Yamail [ http://yandex.ru ] 5.0
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-55502 [...] rt.cpan.org> <rt-4.0.18-24042-1498074984-1408.55502-6-0 [...] rt.cpan.org> <2164871498118458 [...] web45j.yandex.ru> <rt-4.0.18-6024-1498118573-552.55502-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <2785921498125126 [...] web49j.yandex.ru>
content-type: text/html; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -4.233
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] yandex.ru
Authentication-Results: mxback12g.mail.yandex.net; dkim=pass header.i= [...] yandex.ru
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 8D98B2403A0 for <cpan-bug+perlio-subfile [...] hipster.bestpractical.com>; Thu, 22 Jun 2017 05:52:26 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lZEIadNde3Uu for <cpan-bug+perlio-subfile [...] hipster.bestpractical.com>; Thu, 22 Jun 2017 05:52:24 -0400 (EDT)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id BD5BF2402B6 for <bug-perlio-subfile [...] rt.cpan.org>; Thu, 22 Jun 2017 05:52:23 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 91D2811D40D for <bug-perlio-subfile [...] rt.cpan.org>; Thu, 22 Jun 2017 02:52:22 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id D732011EBFC for <bug-perlio-subfile [...] rt.cpan.org>; Thu, 22 Jun 2017 02:52:20 -0700 (PDT)
Received: from forward5o.cmail.yandex.net (forward5o.cmail.yandex.net [37.9.109.249]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 6A66311D40D for <bug-perlio-subfile [...] rt.cpan.org>; Thu, 22 Jun 2017 02:52:10 -0700 (PDT)
Received: from mxback12g.mail.yandex.net (mxback12g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:91]) by forward5o.cmail.yandex.net (Yandex) with ESMTP id DEB55216A9; Thu, 22 Jun 2017 12:52:07 +0300 (MSK)
Received: from web49j.yandex.ru (web49j.yandex.ru [5.45.198.199]) by mxback12g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id KMV2TZTGYo-q6l4b0Hm; Thu, 22 Jun 2017 12:52:07 +0300
Received: by web49j.yandex.ru with HTTP; Thu, 22 Jun 2017 12:52:06 +0300
Delivered-To: cpan-bug+perlio-subfile [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #55502] binmode() fix
Return-Path: <vlad [...] yandex.ru>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1498125127; bh=WFQeYJTQGQMcIyZtmeVSfbKxVSrorpA735eh+fbb02k=; h=From:To:In-Reply-To:References:Subject:Message-Id:Date; b=D8NzT/gVL04G+37poD/aSa3aP4TZt3zimn4BJ8qbBFe5omB0HPmXy2xrnoBXsVh72 RB8vvJwHf2sDYM2TzaOl453CwzSxgCfddunvk2TUI0WUD1APZCXnNBir5rcrTJmd+M QZbX8Nvf3xTJ7MFCl/QXHVbIn1TFPtbqLtknZS1g=
X-Original-To: cpan-bug+perlio-subfile [...] hipster.bestpractical.com
X-RT-Mail-Extension: perlio-subfile
Date: Thu, 22 Jun 2017 12:52:06 +0300
X-PMX-Spam: Gauge=XXI, Probability=21%, Report=' CTYPE_JUST_HTML 0.848, HTML_MIME_NO_HTML_TAG 0.8, RU_TLD 0.5, HTML_FONT_INVISIBLE 0.1, FROM_NAME_ONE_WORD 0.05, BODYTEXTH_SIZE_10000_LESS 0, BODYTEXTH_SIZE_3000_MORE 0, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CTE_BASE64 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, REFERENCES 0, SPF_PASS 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CTYPE_HTML 0, __CTYPE_IS_HTML 0, __DATE_TZ_RU 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HIGHBITS 0, __HTML_AHREF_TAG 0, __HTML_TAG_DIV 0, __HTTPS_URI 0, __IN_REP_TO 0, __MIME_HTML 0, __MIME_HTML_ONLY 0, __MIME_TEXT_H 0, __MIME_TEXT_H1 0, __MIME_VERSION 0, __MULTIPLE_URI_HTML 0, __MULTIPLE_URI_TEXT 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __REFERENCES 0, __RUS_MAILTO_URL 0, __RUS_WEBMAIL_FROM 0, __RUS_WEBMAIL_RCVD 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_NO_NAME 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NO_WWW 0, __URI_NS , __URI_WITHOUT_PATH 0, __URI_WITH_PATH 0, __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.6.22.94516
To: "bug-PerlIO-subfile [...] rt.cpan.org" <bug-perlio-subfile [...] rt.cpan.org>, "SAFRONOV [...] cpan.org" <safronov [...] cpan.org>
Content-Transfer-Encoding: base64
From: Vlad. <vlad [...] yandex.ru>
RT-Message-ID: <rt-4.0.18-24399-1498125147-454.55502-0-0 [...] rt.cpan.org>
Content-Length: 2362
I think this one is correct:
 
"Something like a test file that contains a "\r\n" sequence on disk, where the test code reads this, *and* correctly does binmode on the handle it has with the subfile layer, but the test fails (without this patch) because the data read in is "\n"?"
 
-- 
V.
 
 
 
22.06.2017, 11:03, "vlad@yandex.ru via RT" <bug-perlio-subfile@rt.cpan.org>:
Show quoted text

<URL: https://rt.cpan.org/Ticket/Display.html?id=55502 >

Ouch.. I need to recall the where exactly I hit that bug. --
V. 21.06.2017, 22:56, "Nicholas Clark via RT" <bug-perlio-subfile@rt.cpan.org>:

  <URL: https://rt.cpan.org/Ticket/Display.html?id=55502 >

  On Fri Mar 12 12:02:49 2010, SAFRONOV wrote:

    Only in PerlIO-subfile-0.08-my: Makefile.old
    diff -u PerlIO-subfile-0.08/subfile.xs
    PerlIO-subfile-0.08-my/subfile.xs
    Apply this patch to address binmode(FH) problem.

    --- PerlIO-subfile-0.08/subfile.xs 2004-05-14 00:39:29.000000000 +0400
    +++ PerlIO-subfile-0.08-my/subfile.xs 2009-04-01 00:17:26.000000000
    +0400


  Sorry for the extremely long delay in replying - this ticket got
  overlooked.

  What would a regression test for this bug look like? Something like a test
  file that contains a "\r\n" sequence on disk, where the test code reads
  this, *and* correctly does binmode on the handle it has with the subfile
  layer, but the test fails (without this patch) because the data read in is
  "\n"?

  Or make sure the test file has something after the "\r\n" on disk, and what
  should be read in ends with the "\r\n", but without the patch what one gets
  ends with "\n" and a byte of trailing "garbage"?

  Nicholas Clark



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.