Skip Menu |
 

This queue is for tickets about the WebFetch CPAN distribution.

Report information
The Basics
Id: 55413
Status: new
Priority: 0/
Queue: WebFetch

People
Owner: Nobody in particular
Requestors: BARBIE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.13
Fixed in: (no value)



Subject: patch to fix CPAN Testers reported FAILs
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1268214357-12691-131"
Content-Length: 0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 256
Download (untitled) / with headers
text/plain 256b
Currently this distribution features many CPAN Testers FAIL reports [1,2]. This patch fixes the optional modules tests and POD tests. [1] http://stats.cpantesters.org/wpcent-recent.html (currently #4) [2] http://www.cpantesters.org/distro/W/WebFetch.html
Subject: webfetch-barbie.patch
MIME-Version: 1.0
Content-Type: text/x-patch; name="webfetch-barbie.patch"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline; filename="webfetch-barbie.patch"
Content-Transfer-Encoding: binary
Content-Length: 4816
--- WebFetch-0.13/lib/WebFetch.pm Mon Sep 21 05:57:38 2009 +++ WebFetch-0.13_01/lib/WebFetch.pm Wed Mar 10 09:39:08 2010 @@ -938,8 +938,6 @@ =back -=back - Additional valid keys may be created by modules that inherit from WebFetch by supplying a method/function named with "fmt_handler_" preceding the string used for the key. @@ -1555,6 +1553,8 @@ to catch undefined function calls for its subclasses. If the calling class provides a function by the name that was attempted, then it will be redirected there. + +=back =cut --- WebFetch-0.13/lib/WebFetch/Output/Dump.pm Mon Sep 21 05:57:55 2009 +++ WebFetch-0.13_01/lib/WebFetch/Output/Dump.pm Wed Mar 10 09:39:46 2010 @@ -57,10 +57,14 @@ structure dump from C<Data::Dumper>. It can be read again by a Perl script using C<eval>. +=over 4 + =item $obj->fmt_handler_dump( $filename ) This function dumps the data into a string for saving by the WebFetch::save() function. + +=back =cut --- WebFetch-0.13/lib/WebFetch/Output/TT.pm Mon Sep 21 05:57:58 2009 +++ WebFetch-0.13_01/lib/WebFetch/Output/TT.pm Wed Mar 10 09:40:08 2010 @@ -55,10 +55,14 @@ This module saves output via the Perl Template Toolkit. +=over 4 + =item $obj->fmt_handler_tt( $filename ) This function formats the data according to the Perl Template Toolkit template provided in the --template parameter. + +=back =cut --- WebFetch-0.13/lib/WebFetch/Output/TWiki.pm Mon Sep 21 05:57:59 2009 +++ WebFetch-0.13_01/lib/WebFetch/Output/TWiki.pm Wed Mar 10 09:42:54 2010 @@ -114,7 +114,8 @@ command-line parameter, and then brings in the rest of the configuration info from that line. An example is shown below. -=over +=over 4 + C<< ---+ !WebFetch Configuration >> C<< The following table is used by !WebFetch to configure news feeds >> @@ -126,6 +127,7 @@ C<< | twiki-twitter | Feeds | TwitterTwikiFeed | TwitterTwiki | AtomFeedTemplate | AtomFeedForm | separate_topics | Atom | http://search.twitter.com/search.atom?q=%23twiki | >> C<< | cnn | Feeds | RssCnn | RssCnn | RssFeedTemplate | RssFeedForm | separate_topics | RSS | http://rss.cnn.com/rss/cnn_topstories.rss | >> C<< %STOPINCLUDE% >> + =back The C<%STARTINCLUDE%> and C<%STOPINCLUDE%> are not required. However, if @@ -506,6 +508,18 @@ $self->no_savables_ok; 1; } + +=head1 METHODS + +=over 4 + +=item fmt_handler_twiki +=item get_twiki_config +=item write_to_twiki +=item write_to_twiki_metadata +=item write_to_twiki_topics + +=back =head1 TWiki software --- WebFetch-0.13/lib/WebFetch/Data/Store.pm Mon Sep 21 05:58:00 2009 +++ WebFetch-0.13_01/lib/WebFetch/Data/Store.pm Wed Mar 10 09:41:11 2010 @@ -81,6 +81,8 @@ return $self; } +=over 4 + =item $obj->add_fields( "field1", "field2", ... ); Add the field names in the order their values will appear in the data table. @@ -331,6 +333,8 @@ =item $obj->wk2fnum( $wk ) Obtain a field number from a well-known name. + +=back =cut --- WebFetch-0.13/lib/WebFetch/Data/Record.pm Mon Sep 21 05:58:01 2009 +++ WebFetch-0.13_01/lib/WebFetch/Data/Record.pm Wed Mar 10 09:40:41 2010 @@ -76,6 +76,8 @@ # shortcut function to top-level WebFetch object data sub data { return $_[0]->{obj}; } +=over 4 + =item $value = $obj->bynum( $field_num ); Returns the value of the field located by the field number provided. @@ -173,6 +175,8 @@ So a field named "title" can be accessed by an object method of the same name, like $obj->title . + +=back =cut --- WebFetch-0.13/t/00-load.t Mon Sep 21 05:57:31 2009 +++ WebFetch-0.13_01/t/00-load.t Wed Mar 10 09:29:09 2010 @@ -6,13 +6,28 @@ use_ok( 'WebFetch' ); use_ok( 'WebFetch::Data::Store' ); use_ok( 'WebFetch::Data::Record' ); - use_ok( 'WebFetch::Input::Atom' ); use_ok( 'WebFetch::Input::PerlStruct' ); - use_ok( 'WebFetch::Input::RSS' ); use_ok( 'WebFetch::Input::SiteNews' ); use_ok( 'WebFetch::Output::Dump' ); - use_ok( 'WebFetch::Output::TT' ); use_ok( 'WebFetch::Output::TWiki' ); + + eval "use XML::Atom::Client"; + SKIP: { + skip "Optional module 'XML::Atom::Client' not installed",1 if($@); + use_ok( 'WebFetch::Input::Atom' ); + }; + + eval "use XML::RSS"; + SKIP: { + skip "Optional module 'XML::RSS' not installed",1 if($@); + use_ok( 'WebFetch::Input::RSS' ); + }; + + eval "use Template"; + SKIP: { + skip "Optional module 'Template' not installed",1 if($@); + use_ok( 'WebFetch::Output::TT' ); + }; } diag( "Testing WebFetch $WebFetch::VERSION, Perl $], $^X" ); --- WebFetch-0.13/t/pod.t Sat Aug 15 01:12:52 2009 +++ WebFetch-0.13_01/t/pod.t Wed Mar 10 09:34:46 2010 @@ -2,7 +2,7 @@ use strict; use warnings; -use Test::More skip_all => "no pod files"; +use Test::More; # Ensure a recent version of Test::Pod my $min_tp = 1.22;


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.