Skip Menu |
 

This queue is for tickets about the Net-Ping CPAN distribution.

Report information
The Basics
Id: 52979
Status: open
Priority: 0/
Queue: Net-Ping

People
Owner: Nobody in particular
Requestors: toddr [...] null.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.36
Fixed in: (no value)



Subject: Net::Ping tests fail under fakeroot
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Charset: utf8
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1261512548-22627-28"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 122
Download (untitled) / with headers
text/plain 122b
Need to add check to appropriate tests to skip if in fakeroot since there won't be sufficient privileges. Patch provided
Subject: t_net_ping_icmp.patch
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1261512548-22627-27"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Charset: utf8
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: application/octet-stream; name="t_net_ping_icmp.patch"
Content-Disposition: inline; filename="t_net_ping_icmp.patch"
Content-Transfer-Encoding: base64
Content-Length: 1009
Download t_net_ping_icmp.patch
text/x-diff 1009b
diff --git a/lib/Net/Ping/t/110_icmp_inst.t b/lib/Net/Ping/t/110_icmp_inst.t index 14a7f12..d77f1f0 100755 --- a/lib/Net/Ping/t/110_icmp_inst.t +++ b/lib/Net/Ping/t/110_icmp_inst.t @@ -23,6 +23,8 @@ if (($> and $^O ne 'VMS' and $^O ne 'cygwin') skip "icmp ping requires root privileges.", 1; } elsif ($^O eq 'MacOS') { skip "icmp protocol not supported.", 1; +} elsif ($ENV{'FAKEROOTKEY'}) + skip "icmp tests not supported under fakeroot", 1; } else { my $p = new Net::Ping "icmp"; ok !!$p; diff --git a/lib/Net/Ping/t/500_ping_icmp.t b/lib/Net/Ping/t/500_ping_icmp.t index db20ac9..8884577 100755 --- a/lib/Net/Ping/t/500_ping_icmp.t +++ b/lib/Net/Ping/t/500_ping_icmp.t @@ -23,6 +23,8 @@ if (($> and $^O ne 'VMS') skip "icmp ping requires root privileges.", 1; } elsif ($^O eq 'MacOS') { skip "icmp protocol not supported.", 1; +} elsif ($ENV{'FAKEROOTKEY'}) + skip "icmp tests not supported under fakeroot", 1; } else { my $p = new Net::Ping "icmp"; ok $p->ping("127.0.0.1");
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-22627-1261512709-836.52979-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 118
Download (untitled) / with headers
text/plain 118b
Sorry, The patches provided patch perl 5.10 dist. You'll need to correct the file paths in the patch for this module.
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-22627-1261512709-836.52979-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Charset: utf8
References: <rt-3.6.HEAD-22627-1261512709-836.52979-0-0 [...] rt.cpan.org>
Content-Type: multipart/mixed; boundary="----------=_1261523803-22627-32"
Message-ID: <rt-3.6.HEAD-22627-1261523803-1589.52979-0-0 [...] rt.cpan.org>
From: toddr [...] null.net
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 25
Attaching corrected patch
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: multipart/mixed; boundary="----------=_1261523803-22627-31"
Charset: utf8
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: application/octet-stream; name="t_net_ping_icmp.patch"
Content-Disposition: inline; filename="t_net_ping_icmp.patch"
Content-Transfer-Encoding: base64
Content-Length: 987
diff --git a/lib/Net/Ping/t/110_icmp_inst.t b/lib/Net/Ping/t/110_icmp_inst.t index 14a7f12..d77f1f0 100755 --- a/t/110_icmp_inst.t +++ b/t/110_icmp_inst.t @@ -23,6 +23,8 @@ if (($> and $^O ne 'VMS' and $^O ne 'cygwin') skip "icmp ping requires root privileges.", 1; } elsif ($^O eq 'MacOS') { skip "icmp protocol not supported.", 1; +} elsif ($ENV{'FAKEROOTKEY'}) { + skip "icmp tests not supported under fakeroot", 1; } else { my $p = new Net::Ping "icmp"; ok !!$p; diff --git a/lib/Net/Ping/t/500_ping_icmp.t b/lib/Net/Ping/t/500_ping_icmp.t index db20ac9..8884577 100755 --- a/lib/Net/Ping/t/500_ping_icmp.t +++ b/lib/Net/Ping/t/500_ping_icmp.t @@ -23,6 +23,8 @@ if (($> and $^O ne 'VMS') skip "icmp ping requires root privileges.", 1; } elsif ($^O eq 'MacOS') { skip "icmp protocol not supported.", 1; +} elsif ($ENV{'FAKEROOTKEY'}) { + skip "icmp tests not supported under fakeroot", 1; } else { my $p = new Net::Ping "icmp"; ok $p->ping("127.0.0.1");


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.