Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 52647
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: daxim [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.35_13
Fixed in: 0.36



Subject: need an easy way to disable share_dir
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain
Charset: utf8
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 632
Download (untitled) / with headers
text/plain 632b
The distro Xacobeo has a share directory, but uses it in a different way than intended by the share_dir feature. We also have darkpan distros that are structured the same way. Once M::B has detected a share/ subdir, it can't be easily persuaded to not copy the files to auto/. Things that work: setting share_dir to a nonsense value/not existing directory; subclassing M::B and nuking the functionality. Inhibiting should be easier. My colleague has a stronger opinion: that by default M::B should not magically act on a share/ alone, but require an explicit trigger, e.g. setting the share_dir option manually in Build.PL.
MIME-Version: 1.0
X-Spam-Status: No, hits=0.0 required=8.0 tests=DK_SIGNED,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-9877-1260448487-362.52647-4-0 [...] rt.cpan.org>
References: <RT-Ticket-52647 [...] rt.cpan.org> <rt-3.6.HEAD-9877-1260448487-362.52647-4-0 [...] rt.cpan.org>
Message-ID: <5d4beb40912100523v2f0f0623p9486c113702f9a3b [...] mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id 684BA4D8025 for <bug-Module-Build [...] rt.cpan.org>; Thu, 10 Dec 2009 08:24:08 -0500 (EST)
Received: (qmail 26276 invoked by uid 103); 10 Dec 2009 13:24:07 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 10 Dec 2009 13:24:07 -0000
Received: from mail-pw0-f54.google.com (HELO mail-pw0-f54.google.com) (209.85.160.54) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Thu, 10 Dec 2009 05:24:05 -0800
Received: by pwi14 with SMTP id 14so3515989pwi.13 for <bug-Module-Build [...] rt.cpan.org>; Thu, 10 Dec 2009 05:24:02 -0800 (PST)
Received: by 10.143.25.39 with SMTP id c39mr2210076wfj.10.1260451442609; Thu, 10 Dec 2009 05:24:02 -0800 (PST)
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #52647] need an easy way to disable share_dir
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:content-type :content-transfer-encoding; b=wdtUWw5LqutwS76UB1g9mswBebHXkP3H2nrTqUtgH6FVtorQqxrDTZjsMAZXvMcI7U 8QMZI8Qvr4wfYW8hN3UtjVlE9smunkFVFEtkFLDYuB8rov1gY8HWOjs3GXVK+ds2yI7E RkplGD6AH7S9+0+9O++NEiCX+QnM+vNLCTW/8=
Return-Path: <xdaveg [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:from:date:x-google-sender-auth:message-id:subject:to :content-type:content-transfer-encoding; bh=fuPNG5Lm53h8wCVKomeB+Dkr7rQbZncUvEW2Jxcrzr0=; b=dd35AclvPqB13Lbeb5Vu5dk3+vRzYjI5zdP66LMK6jizvTLU8hrQKABT3Jcz8KCjr+ 7Nc38xSQCX2SVm/dWuboHgDrZsNbRzgcdCmTMxrJEtU/ZrKtGC9Ybn8+b3+ooVkNv6PR zrbZzEG++t8mbeoxrz6Y5/n5G/lfQ9scwNjVY=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
X-Google-Sender-Auth: fc723073cc4c57a3
Date: Thu, 10 Dec 2009 08:23:42 -0500
Sender: xdaveg [...] gmail.com
X-Spam-Level: *
To: bug-Module-Build [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: David Golden <dagolden [...] cpan.org>
RT-Message-ID: <rt-3.6.HEAD-9877-1260451467-920.52647-0-0 [...] rt.cpan.org>
Content-Length: 930
Download (untitled) / with headers
text/plain 930b
On Thu, Dec 10, 2009 at 7:34 AM, Lars Dɪᴇᴄᴋᴏᴡ 迪拉斯 via RT <bug-Module-Build@rt.cpan.org> wrote: Show quoted text
> Once M::B has detected a share/ subdir, it can't be easily persuaded to > not copy the files to auto/. Things that work: setting share_dir to a > nonsense value/not existing directory; subclassing M::B and nuking the > functionality. Inhibiting should be easier. > > My colleague has a stronger opinion: that by default M::B should not > magically act on a share/ alone, but require an explicit trigger, e.g. > setting the share_dir option manually in Build.PL.
The general trend in Perl distribution generation is more auto-sensing and less manual maintenance in *.PL. This is a louder "demand" from the author community. That said, disabling the behavior should be easier *and* documented. It should probably issue a note to the terminal as well so users aren't taken by surprise. I'll look into it. -- David
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-13462-1261086268-789.52647-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 120
Download (untitled) / with headers
text/plain 120b
I have disable 'share_dir' using 'share' as a default in 0.35_14. 'share_dir' now always has to be specified explicitly


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.