Skip Menu |
 

This queue is for tickets about the Test-WWW-Selenium CPAN distribution.

Report information
The Basics
Id: 51739
Status: resolved
Priority: 0/
Queue: Test-WWW-Selenium

People
Owner: Nobody in particular
Requestors: frequency [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 1.20
Fixed in: (no value)



Subject: Superfluous build dependency: Test::Pod
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain
Charset: utf8
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 290
Download (untitled) / with headers
text/plain 290b
I thought I should file this as a separate bug since it's a separate issue. You removed the POD tests, however, Test::Pod is still in your build_requires. It doesn't really affect anything; but since the module isn't needed, it's probably more polite not to install it. Cheers, Jonathan
MIME-Version: 1.0
X-Spam-Status: No, hits=0.0 required=8.0 tests=DK_SIGNED,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-6514-1258654014-1911.51739-4-0 [...] rt.cpan.org>
References: <RT-Ticket-51739 [...] rt.cpan.org> <rt-3.6.HEAD-6514-1258654014-1911.51739-4-0 [...] rt.cpan.org>
Message-ID: <d51525740911191909m69346048o9de3f5ec2114d801 [...] mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id 1FD9A4D801E for <bug-Test-WWW-Selenium [...] rt.cpan.org>; Thu, 19 Nov 2009 22:09:14 -0500 (EST)
Received: (qmail 2964 invoked by uid 103); 20 Nov 2009 03:09:13 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 20 Nov 2009 03:09:13 -0000
Received: from mail-pw0-f54.google.com (HELO mail-pw0-f54.google.com) (209.85.160.54) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Thu, 19 Nov 2009 19:09:12 -0800
Received: by pwj2 with SMTP id 2so1989941pwj.13 for <bug-Test-WWW-Selenium [...] rt.cpan.org>; Thu, 19 Nov 2009 19:09:09 -0800 (PST)
Received: by 10.140.134.9 with SMTP id h9mr54902rvd.43.1258686549428; Thu, 19 Nov 2009 19:09:09 -0800 (PST)
Delivered-To: cpan-bug+Test-WWW-Selenium [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #51739] Superfluous build dependency: Test::Pod
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=fX9F2+oRrMXtrqYwZGmq6hb2iJBXzqdjLBVa366m2nB5gW9uzYF84UGXqf2Nenm7OI nH7cxcUfyBIujVwHJFWsS2ysLkthK8T/ALiqSUdgG/c641SSTNqZXNbcg+aTTnGERu0E O5C7pFDoQttY6XWwXu5iFeCqv9lEALZwVSo8c=
Return-Path: <lukecloss [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=T0vWLxfoUuYeMFQY11PC3QvyDb3RGMPbCum39Ryclco=; b=u/kuJWEO/ETllzJz5Uc/2QEscDO5vKhUESbu2N7G//Ra4i02woAq9MqB15kVllJJtZ v02AOUNCEcC6xaWXWq+7wzvQMh4xIewM7xM9yI+SVAYsmJxXti8czd9/0MnIyw31USZD Jiby8xeMrGnTsue7/0QDAqsdHX/7XthA/yaB0=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Test-WWW-Selenium [...] rt.cpan.org
Date: Thu, 19 Nov 2009 19:09:09 -0800
X-Spam-Level: *
To: bug-Test-WWW-Selenium [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Luke Closs <lukecloss [...] gmail.com>
RT-Message-ID: <rt-3.6.HEAD-6514-1258686564-229.51739-0-0 [...] rt.cpan.org>
Content-Length: 872
Download (untitled) / with headers
text/plain 872b
Jonathan are you on Github? I'll give you a commit bit if so. Luke On Thu, Nov 19, 2009 at 10:06 AM, Jonathan Yu via RT <bug-Test-WWW-Selenium@rt.cpan.org> wrote: Show quoted text
> Thu Nov 19 13:06:49 2009: Request 51739 was acted upon. > Transaction: Ticket created by FREQUENCY >       Queue: Test-WWW-Selenium >     Subject: Superfluous build dependency: Test::Pod >   Broken in: 1.20 >    Severity: Wishlist >       Owner: Nobody >  Requestors: frequency@cpan.org >      Status: new >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=51739 > > > > I thought I should file this as a separate bug since it's a separate issue. > > You removed the POD tests, however, Test::Pod is still in your > build_requires. > > It doesn't really affect anything; but since the module isn't needed, > it's probably more polite not to install it. > > Cheers, > > Jonathan >
MIME-Version: 1.0
X-Spam-Status: No, hits=0.0 required=8.0 tests=DK_SIGNED,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-6514-1258686564-229.51739-6-0 [...] rt.cpan.org>
References: <RT-Ticket-51739 [...] rt.cpan.org> <rt-3.6.HEAD-6514-1258654014-1911.51739-4-0 [...] rt.cpan.org> <d51525740911191909m69346048o9de3f5ec2114d801 [...] mail.gmail.com> <rt-3.6.HEAD-6514-1258686564-229.51739-6-0 [...] rt.cpan.org>
Message-ID: <d1b732a70911240604l73ae11eaq43c1d29652ef481f [...] mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id 2AF814D8026 for <bug-Test-WWW-Selenium [...] rt.cpan.org>; Tue, 24 Nov 2009 09:04:45 -0500 (EST)
Received: (qmail 2889 invoked by uid 103); 24 Nov 2009 14:04:44 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 24 Nov 2009 14:04:44 -0000
Received: from mail-ew0-f228.google.com (HELO mail-ew0-f228.google.com) (209.85.219.228) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Tue, 24 Nov 2009 06:04:42 -0800
Received: by ewy28 with SMTP id 28so3588713ewy.37 for <bug-Test-WWW-Selenium [...] rt.cpan.org>; Tue, 24 Nov 2009 06:04:39 -0800 (PST)
Received: by 10.216.87.144 with SMTP id y16mr2134428wee.95.1259071478771; Tue, 24 Nov 2009 06:04:38 -0800 (PST)
Delivered-To: cpan-bug+Test-WWW-Selenium [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #51739] Superfluous build dependency: Test::Pod
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=Bez5T4QcoOUr/RRAo9cQ0gq4mXcBRP2ZWovvjO3CrPhR4nM5zdroAkh6CfA3uK2Rw5 rjXjke2V+9vSA/lGdHZNr3pTSXOzmz9p0egJKdh1irkgntWgRjuDHwPQ8sxp9RefpFPS nUJeYfrTrSCHeAzVzTy622lja5zjCINtH1JPA=
Return-Path: <jonathan.i.yu [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to :content-type:content-transfer-encoding; bh=XhZwXG8oiCCFBlT9ajDvOP2MPz9dpJ0HFOQlRRYuMe8=; b=V/Y+Tw+8aNSbUAqqsH+4J3Y7WwfXxwSYEHC1yARwJxzbPa1W3aExNxrWTGMDVrRi4V KSorqXBz704TVm0+ybItX5K4gNxIeuN4hMDnRnj+os74PH/s4N757POGOmomenRZQReW miSkulYu4wNKe1M9AqCzG+9mdGvp2GbJxiY0w=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Test-WWW-Selenium [...] rt.cpan.org
X-Google-Sender-Auth: 6f50ec8fd1cd1d2d
Date: Tue, 24 Nov 2009 09:04:38 -0500
Sender: jonathan.i.yu [...] gmail.com
X-Spam-Level: *
To: bug-Test-WWW-Selenium [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Jonathan Yu <frequency [...] cpan.org>
RT-Message-ID: <rt-3.6.HEAD-17744-1259071495-991.51739-0-0 [...] rt.cpan.org>
Content-Length: 1559
Download (untitled) / with headers
text/plain 1.5k
On Thu, Nov 19, 2009 at 10:09 PM, Luke Closs via RT <bug-Test-WWW-Selenium@rt.cpan.org> wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=51739 > > > Jonathan are you on Github?  I'll give you a commit bit if so.
Technically, yes, but not really. You see, I do have an account on github, but I don't really know how to use git properly yet, and I haven't had the time to learn. I also don't think I'd be the best candidate for a commit bit, since I don't use Test::WWW::Selenium myself; I am just on the team that helps package it for Debian, and that's about my only experience with it. If you're too busy to fix this yourself, I can figure out how to use git. My username on github is jawnsy. Cheers! Show quoted text
> > Luke > > On Thu, Nov 19, 2009 at 10:06 AM, Jonathan Yu via RT > <bug-Test-WWW-Selenium@rt.cpan.org> wrote:
>> Thu Nov 19 13:06:49 2009: Request 51739 was acted upon. >> Transaction: Ticket created by FREQUENCY >>       Queue: Test-WWW-Selenium >>     Subject: Superfluous build dependency: Test::Pod >>   Broken in: 1.20 >>    Severity: Wishlist >>       Owner: Nobody >>  Requestors: frequency@cpan.org >>      Status: new >>  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=51739 > >> >> >> I thought I should file this as a separate bug since it's a separate issue. >> >> You removed the POD tests, however, Test::Pod is still in your >> build_requires. >> >> It doesn't really affect anything; but since the module isn't needed, >> it's probably more polite not to install it. >> >> Cheers, >> >> Jonathan >>
> >
MIME-Version: 1.0
Subject: patch ready for both of these and fix for t/test_default_server
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-2908-1276745139-594.51739-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 771
Download (untitled) / with headers
text/plain 771b
Luke, I have combined these two patches plus added a fix that makes t/test_default_server.t independent of where the selenium-core distribution is; it downloads it and tests with the downloaded copy. (Currently it uses t/selenium-core for this, but that could be changed. I like it that way because it remains cached for further tests.) I've also made the POD fix and moved pod.t into xt/. This way the POD tests are still available but don't require casual users to run them. (We could remove the BuildRequires for Test::Pod as well, since developers will not fall over if they see that they need to download an extra module to run developer tests.) I can branch your project at github and push this fix to the branch so you can vet it before pulling into your master.
From lukecloss [...] gmail.com Wed Jun 16 23: 48:16 2010
MIME-Version: 1.0
X-Spam-Status: No, score=-7.475 tagged_above=-99.9 required=10 tests=[AWL=2.438, BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8, SPF_NEUTRAL=0.686] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-2908-1276745140-1618.51739-5-0 [...] rt.cpan.org>
X-Spam-Flag: NO
References: <RT-Ticket-51739 [...] rt.cpan.org> <rt-3.8.HEAD-2908-1276745140-1618.51739-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <AANLkTilPo5dyVxjz2I5GkEd3uvsMqVE84Otlmnzr8fJV [...] mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -7.475
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Authentication-Results: hipster.bestpractical.com (amavisd-new); domainkeys=pass header.from=lukecloss [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 91FD3240880 for <cpan-bug+Test-WWW-Selenium [...] hipster.bestpractical.com>; Wed, 16 Jun 2010 23:48:16 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NqL4KJiT0kM9 for <cpan-bug+Test-WWW-Selenium [...] hipster.bestpractical.com>; Wed, 16 Jun 2010 23:48:14 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id F1D9224085F for <bug-Test-WWW-Selenium [...] rt.cpan.org>; Wed, 16 Jun 2010 23:48:13 -0400 (EDT)
Received: (qmail 23049 invoked by uid 103); 17 Jun 2010 03:49:19 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 17 Jun 2010 03:49:19 -0000
Received: from mail-iw0-f178.google.com (HELO mail-iw0-f178.google.com) (209.85.214.178) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 16 Jun 2010 20:49:18 -0700
Received: by iwn40 with SMTP id 40so6283580iwn.9 for <bug-Test-WWW-Selenium [...] rt.cpan.org>; Wed, 16 Jun 2010 20:49:15 -0700 (PDT)
Received: by 10.231.170.1 with SMTP id b1mr10143594ibz.13.1276746555238; Wed, 16 Jun 2010 20:49:15 -0700 (PDT)
Received: by 10.231.158.85 with HTTP; Wed, 16 Jun 2010 20:49:15 -0700 (PDT)
Delivered-To: cpan-bug+Test-WWW-Selenium [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #51739] patch ready for both of these and fix for t/test_default_server
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=FZpPCYP9Shum7k6WIG3L2Zs+BePAIaYauD/4+uBvWyYVYInskP8xGCY+FklbEZfVts GrTUIo4en5ox/3Msn3Z/xVhYEYo2f/9t/U2PggArJJ7SaRW01ok2UcsE1r+ndf7MYUWw Zk+Mq0tUdfsxY9mjfDq3YibCmJqMWOZ9W3kX8=
Return-Path: <lukecloss [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=86sEuV0cjis9yjitHgPlPO41Zv3ieeI1wn1qH83w3XI=; b=dqBS9F+56j+ZOVVJL73iQhgK8d4FH1na16Oid+t4KR87XPJLqhQe51QoBzCnJC1rRE 4vTyhwNVEvRSYjzEmrQRTksYzuj/V6hU+WQWdy8gQkjVbcpGZxe+vMZ8W3N6yZbZRS6p CDducM9DyiX3bpPi+21N8bfsWDJDi6tO2kCMQ=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Test-WWW-Selenium [...] hipster.bestpractical.com
X-RT-Mail-Extension: test-www-selenium
Date: Wed, 16 Jun 2010 20:49:15 -0700
X-Spam-Level:
To: bug-Test-WWW-Selenium [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Luke Closs <lukecloss [...] gmail.com>
RT-Message-ID: <rt-3.8.HEAD-2911-1276746565-676.51739-0-0 [...] rt.cpan.org>
Content-Length: 1214
Download (untitled) / with headers
text/plain 1.1k
Joe, Would you like to take over maintainership for this module? I don't have much time for it lately. I would be more than happy to give you a commit bit to my repo and/or make you a maintainer on CPAN. Luke On Wed, Jun 16, 2010 at 8:25 PM, Joe McMahon via RT <bug-Test-WWW-Selenium@rt.cpan.org> wrote: Show quoted text
>       Queue: Test-WWW-Selenium >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=51739 > > > Luke, I have combined these two patches plus added a fix that makes > t/test_default_server.t independent of where the selenium-core > distribution is; it downloads it and tests with the downloaded copy. > (Currently it uses t/selenium-core for this, but that could be changed. > I like it that way because it remains cached for further tests.) > > I've also made the POD fix and moved pod.t into xt/. This way the POD > tests are still available but don't require casual users to run them. > (We could remove the BuildRequires for Test::Pod as well, since > developers will not fall over if they see that they need to download an > extra module to run developer tests.) > > I can branch your project at github and push this fix to the branch so > you can vet it before pulling into your master. >
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-18808-1303488105-1284.51739-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 81
this is fixed in the repo and will be fixed in the upcoming 1.25 release. Thanks


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.