Skip Menu |
 

This queue is for tickets about the CGI-Session CPAN distribution.

Report information
The Basics
Id: 51192
Status: resolved
Priority: 0/
Queue: CGI-Session

People
Owner: MARKSTOS [...] cpan.org
Requestors: rpv [...] nikolas.ru
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



MIME-Version: 1.0
X-Spam-Status: No, hits=3.5 required=8.0 tests=REPTO_OVERQUOTE_THEBAT,SPF_PASS
X-Mailer: The Bat! (v3.71.04) Professional
content-type: text/plain; charset="utf-8"
Message-ID: <1546318663.20091108002914 [...] nikolas.ru>
Reply-To: "Pavel V. Rochnyack" <rpv [...] nikolas.ru>
X-Virus-Scanned: Debian amavisd-new at nikolas.ru
Organization: LLC Nikolas Group
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id BDDBD4D801D for <bug-CGI-Session [...] rt.cpan.org>; Sat, 7 Nov 2009 13:29:14 -0500 (EST)
Received: (qmail 19189 invoked by uid 103); 7 Nov 2009 18:29:14 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 7 Nov 2009 18:29:14 -0000
Received: from mail2.nikolas.ru (HELO mail.nikolas.ru) (62.68.141.43) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Sat, 07 Nov 2009 10:29:12 -0800
Received: from localhost (localhost [127.0.0.1]) by mail.nikolas.ru (Postfix) with ESMTP id 22A1B58006 for <bug-CGI-Session [...] rt.cpan.org>; Sun, 8 Nov 2009 00:29:09 +0600 (NOVT)
Received: from mail.nikolas.ru ([127.0.0.1]) by localhost (mail.nikolas.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dgRyulKAF1Lh for <bug-CGI-Session [...] rt.cpan.org>; Sun, 8 Nov 2009 00:29:08 +0600 (NOVT)
Received: from YOUR-123456 (unknown [62.68.141.2]) (Authenticated sender: rpv [...] nikolas.ru) by mail.nikolas.ru (Postfix) with ESMTPA id CA7D158005 for <bug-CGI-Session [...] rt.cpan.org.>; Sun, 8 Nov 2009 00:29:07 +0600 (NOVT)
Delivered-To: cpan-bug+CGI-Session [...] diesel.bestpractical.com
Subject: _SESSION_EXPIRE_LIST created for every session, wasting space [patch]
Return-Path: <rpv [...] nikolas.ru>
X-Original-To: bug-CGI-Session [...] rt.cpan.org
X-Spam-Check-BY: 16.mx.develooper.com
X-Priority: 3 (Normal)
Date: Sun, 8 Nov 2009 00:29:14 +0600
X-Spam-Level: ***
To: bug-CGI-Session [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: "Pavel V. Rochnyack" <rpv [...] nikolas.ru>
X-RT-Original-Encoding: us-ascii
Content-Length: 920
Download (untitled) / with headers
text/plain 920b
Hi all! Because of absent check, load() creates _SESSION_EXPIRE_LIST key for each session data. I assume that it is incorrect behavior. --- CGI/Session.pm.orig<--->2009-03-21 07:59:06.000000000 +0600 +++ CGI/Session.pm<>2009-11-08 00:19:21.000000000 +0600 @@ -757,10 +759,12 @@ . # checking expiration tickers of individuals parameters, if any: my @expired_params = (); - while (my ($param, $max_exp_interval) = each %{ $self->{_DATA}->{_SESSION_EXPIRE_LIST} } ) { + if ( $self->{_DATA}->{_SESSION_EXPIRE_LIST} ) { + while (my ($param, $max_exp_interval) = each %{ $self->{_DATA}->{_SESSION_EXPIRE_LIST} } ) { if ( ($self->{_DATA}->{_SESSION_ATIME} + $max_exp_interval) <= time() ) { push @expired_params, $param; } + } } $self->clear(\@expired_params) if @expired_params; -- Best regards, Pavel V. Rochnyack mailto:rpv@nikolas.ru
MIME-Version: 1.0
In-Reply-To: <1546318663.20091108002914 [...] nikolas.ru>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <1546318663.20091108002914 [...] nikolas.ru>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-2362-1288747209-1100.51192-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 80
Thanks for the patch. It has been applied and will appear in the next release.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.