Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 50301
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: MARKSTOS [...] cpan.org
Requestors: michaelb [...] travelpod.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: CGI::Fast changed without incrementing $VERSION
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain
Charset: utf8
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 1011
Download (untitled) / with headers
text/plain 1011b
CGI::Fast changed between CGI versions 3.45 and 3.47 but the $VERSION for CGI::Fast remained the same at 1.07. This provided much fun this morning trying to understand what changed to produce new warnings when the version number for CGI::Fast remained constant :-) Also, and this may be a further bug, the way that setting warnings was changed in the CGI v3.47 version of CGI::Fast causes scripts that don't have "use warnings" set to start emitting warnings ... which is how we discovered this in the first place. For reference, here are two versions of CGI::Fast 1.07: http://cpansearch.perl.org/src/LDS/CGI.pm-3.45/lib/CGI/Fast.pm http://cpansearch.perl.org/src/LDS/CGI.pm-3.47/lib/CGI/Fast.pm I'm not sure what the preferred patch syntax is, but the trivial solution to this ticket is to bump the $VERSION of CGI::Fast :-) ... and perhaps add a note to the CGI::Fast CHANGELOG or POD to reflect that CGI::Fast version 1.08 will force a global "use warnings" context on your scripts. -Michael
MIME-Version: 1.0
X-Spam-Status: No, hits=-0.0 required=8.0 tests=SPF_PASS
In-Reply-To: <rt-3.6.HEAD-2295-1254930369-781.50301-4-0 [...] rt.cpan.org>
X-Mailer: Claws Mail 3.7.2 (GTK+ 2.12.9; i486-pc-linux-gnu)
References: <RT-Ticket-50301 [...] rt.cpan.org> <rt-3.6.HEAD-2295-1254930369-781.50301-4-0 [...] rt.cpan.org>
Message-ID: <20091007115329.5a7605f1 [...] summersault.com>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id 9C3FF19B8311 for <bug-CGI.pm [...] rt.cpan.org>; Wed, 7 Oct 2009 11:53:38 -0400 (EDT)
Received: (qmail 24053 invoked by uid 103); 7 Oct 2009 15:53:38 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 7 Oct 2009 15:53:38 -0000
Received: from tanagra.summersault.com (HELO tanagra.summersault.com) (12.161.105.149) by 16.mx.develooper.com (qpsmtpd/0.80) with SMTP; Wed, 07 Oct 2009 08:53:32 -0700
Received: (qmail 61429 invoked from network); 7 Oct 2009 11:53:29 -0400
Received: from simba.summersault.com (HELO localhost) (192.168.97.182) by tanagra.summersault.com with SMTP; 7 Oct 2009 11:53:29 -0400
Delivered-To: cpan-bug+CGI.pm [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #50301] CGI::Fast changed without incrementing $VERSION
Return-Path: <mark [...] summersault.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-CGI.pm [...] rt.cpan.org
Date: Wed, 7 Oct 2009 11:53:29 -0400
X-Spam-Level: *
To: bug-CGI.pm [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Mark Stosberg <mark [...] summersault.com>
RT-Message-ID: <rt-3.6.HEAD-2295-1254930829-1190.50301-0-0 [...] rt.cpan.org>
Content-Length: 770
Download (untitled) / with headers
text/plain 770b
Show quoted text
> CGI::Fast changed between CGI versions 3.45 and 3.47 but the $VERSION for CGI::Fast > remained the same at 1.07. > > This provided much fun this morning trying to understand what changed to produce new > warnings when the version number for CGI::Fast remained constant :-)
That certainly sounds frustrating. Thanks for the report-- we'll get this updated. Show quoted text
> Also, and this may be a further bug, the way that setting warnings was changed in the CGI > v3.47 version of CGI::Fast causes scripts that don't have "use warnings" set to start emitting > warnings ... which is how we discovered this in the first place.
So, you get a warning when you haven't asked to "use warnings"? That's interesting. Could you provide a sample of the warning received? Mark
MIME-Version: 1.0 (Apple Message framework v936)
X-Spam-Status: No, hits=0.0 required=8.0 tests=
In-Reply-To: <rt-3.6.HEAD-2295-1254930829-1190.50301-6-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.936)
References: <RT-Ticket-50301 [...] rt.cpan.org> <rt-3.6.HEAD-2295-1254930369-781.50301-4-0 [...] rt.cpan.org> <20091007115329.5a7605f1 [...] summersault.com> <rt-3.6.HEAD-2295-1254930829-1190.50301-6-0 [...] rt.cpan.org>
Message-ID: <B6C6D0E4-5D5A-469E-8C86-25D2C2CD7F4D [...] travelpod.com>
Content-Type: text/plain; charset="utf-8"; delsp="yes"; format="flowed"
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id 6177119B8351 for <bug-CGI.pm [...] rt.cpan.org>; Wed, 7 Oct 2009 12:09:18 -0400 (EDT)
Received: (qmail 26970 invoked by uid 103); 7 Oct 2009 16:09:17 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 7 Oct 2009 16:09:17 -0000
Received: from mail-fx0-f215.google.com (HELO mail-fx0-f215.google.com) (209.85.220.215) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 07 Oct 2009 09:09:11 -0700
Received: by fxm11 with SMTP id 11so4741569fxm.15 for <bug-CGI.pm [...] rt.cpan.org>; Wed, 07 Oct 2009 09:09:07 -0700 (PDT)
Received: by 10.86.231.19 with SMTP id d19mr131091fgh.48.1254931747602; Wed, 07 Oct 2009 09:09:07 -0700 (PDT)
Received: from ?192.168.2.12? (OTWAON23-1168101039.sdsl.bell.ca [69.159.206.175]) by mx.google.com with ESMTPS id 4sm811796fge.2.2009.10.07.09.09.05 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 07 Oct 2009 09:09:06 -0700 (PDT)
Delivered-To: cpan-bug+CGI.pm [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #50301] CGI::Fast changed without incrementing $VERSION
Return-Path: <michaelb [...] travelpod.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-CGI.pm [...] rt.cpan.org
Date: Wed, 7 Oct 2009 12:09:03 -0400
X-Spam-Level: *
To: bug-CGI.pm [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Michael Burns <michaelb [...] travelpod.com>
RT-Message-ID: <rt-3.6.HEAD-2295-1254931769-407.50301-0-0 [...] rt.cpan.org>
Content-Length: 1357
Download (untitled) / with headers
text/plain 1.3k
Show quoted text
>> Also, and this may be a further bug, the way that setting warnings >> was changed in the CGI >> v3.47 version of CGI::Fast causes scripts that don't have "use >> warnings" set to start emitting >> warnings ... which is how we discovered this in the first place.
> > So, you get a warning when you haven't asked to "use warnings"? That's > interesting. Could you provide a sample of the warning received?
Using CGI v3.45's CGI::Fast, a trivial example producing no errors: Show quoted text
> [me@machine ~]$ perl -MCGI::Fast -e '"foo" == 1;' > [me@machine ~]$
(exhibits bad form certainly :-) but no warnings, as expected) Using CGI v3.47's CGI::Fast, the same example produces a warning despite the code not issuing a "use warnings": Show quoted text
> [me@machine ~]$ perl -MCGI::Fast -e '"foo" == 1;' > Argument "foo" isn't numeric in numeric eq (==) at -e line 1. > [me@machine ~]$
We noticed this as we have a few old scripts that aren't "use warnings" which started spewing warnings after upgrading CGI. It looks to be due to the direct setting of $^W (which is a global setting IIRC) in the newer CGI::Fast. Let me know if I can provide any further information. Cheers, Michael P.S. -- As with all serendipity, these non "use warnings" scripts are scheduled to be retired in a few weeks, after which we'd likely not have noticed this issue at all...
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-6514-1258600035-154.50301-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 44
Thanks, this is patched in my git repo now.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-2597-1321061927-238.50301-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 100
Download (untitled) / with headers
text/plain 100b
I think this fix was released some time ago. Re-open if you see an issue with the current release.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.