Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 49599
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: Nobody in particular
Requestors: jdhedden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] Fix t/fast.t
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Charset: utf8
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1252602872-23678-1"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 215
Download (untitled) / with headers
text/plain 215b
t/fast.t fails instead of skips if FCGI.pm is not available. The 'use CGI::Fast' needs to be reverted to 'use_ok(CGI::Fast)', and the test counts need to be adjusted accordingly. The attached patch fixes all this.
Subject: cgi.patch
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1252602871-23678-0"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Charset: utf8
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: text/x-patch; name="cgi.patch"
Content-Disposition: inline; filename="cgi.patch"
Content-Transfer-Encoding: binary
Content-Length: 678
Download cgi.patch
text/x-diff 678b
--- CGI.pm-3.47/t/fast.t.orig 2009-09-10 13:10:06.288510500 -0400 +++ CGI.pm-3.47/t/fast.t 2009-09-10 13:11:41.398692700 -0400 @@ -7,16 +7,16 @@ $fcgi = $@ ? 0 : 1; } -use Test::More tests => 10; +use Test::More tests => 11; # Shut up "used only once" warnings. () = $CGI::Q; () = $CGI::Fast::Ext_Request; SKIP: { - skip( 'FCGI not installed, cannot continue', 7 ) unless $fcgi; + skip( 'FCGI not installed, cannot continue', 11 ) unless $fcgi; - use CGI::Fast; + use_ok( CGI::Fast ); ok( my $q = CGI::Fast->new(), 'created new CGI::Fast object' ); is( $q, $CGI::Q, 'checking to see if the object was stored properly' ); is( $q->param(), (), 'no params' );
MIME-Version: 1.0
X-Spam-Status: No, hits=-0.0 required=8.0 tests=SPF_PASS
In-Reply-To: <rt-3.6.HEAD-23678-1252602891-136.49599-4-0 [...] rt.cpan.org>
X-Mailer: Claws Mail 3.7.2 (GTK+ 2.12.9; i486-pc-linux-gnu)
References: <RT-Ticket-49599 [...] rt.cpan.org> <rt-3.6.HEAD-23678-1252602891-136.49599-4-0 [...] rt.cpan.org>
Message-ID: <20090910132310.6c1e9b7e [...] summersault.com>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id 84FCB19B8274 for <bug-CGI.pm [...] rt.cpan.org>; Thu, 10 Sep 2009 13:23:20 -0400 (EDT)
Received: (qmail 30851 invoked by uid 103); 10 Sep 2009 17:23:19 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 10 Sep 2009 17:23:19 -0000
Received: from tanagra.summersault.com (HELO tanagra.summersault.com) (12.161.105.149) by 16.mx.develooper.com (qpsmtpd/0.80) with SMTP; Thu, 10 Sep 2009 10:23:14 -0700
Received: (qmail 180 invoked from network); 10 Sep 2009 13:23:10 -0400
Received: from simba.summersault.com (HELO localhost) (192.168.97.182) by tanagra.summersault.com with SMTP; 10 Sep 2009 13:23:10 -0400
Delivered-To: cpan-bug+CGI.pm [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #49599] [PATCH] Fix t/fast.t
Return-Path: <mark [...] summersault.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-CGI.pm [...] rt.cpan.org
Date: Thu, 10 Sep 2009 13:23:10 -0400
X-Spam-Level: *
To: bug-CGI.pm [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Mark Stosberg <mark [...] summersault.com>
RT-Message-ID: <rt-3.6.HEAD-27252-1252603413-381.49599-0-0 [...] rt.cpan.org>
Content-Length: 389
Download (untitled) / with headers
text/plain 389b
Show quoted text
> t/fast.t fails instead of skips if FCGI.pm is not available. The 'use > CGI::Fast' needs to be reverted to 'use_ok(CGI::Fast)', and the test > counts need to be adjusted accordingly.
Thanks. This fix looks reasonable to me. I'll plan to have it appear in the next release with credit to "Jerry D. Hedden" in the Changes file. Let me know if you'd prefer a different credit. Mark
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-27252-1252603413-381.49599-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
References: <RT-Ticket-49599 [...] rt.cpan.org> <rt-3.6.HEAD-23678-1252602891-136.49599-4-0 [...] rt.cpan.org> <20090910132310.6c1e9b7e [...] summersault.com> <rt-3.6.HEAD-27252-1252603413-381.49599-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-2295-1255227833-745.49599-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
RT-Send-CC: perl5-porters [...] perl.org
Content-Length: 579
Download (untitled) / with headers
text/plain 579b
On Thu Sep 10 13:23:33 2009, mark@summersault.com wrote: Show quoted text
>
> > t/fast.t fails instead of skips if FCGI.pm is not available. The 'use > > CGI::Fast' needs to be reverted to 'use_ok(CGI::Fast)', and the test > > counts need to be adjusted accordingly.
> > Thanks. This fix looks reasonable to me. I'll plan to have it appear > in the next release with credit to "Jerry D. Hedden" in the Changes file. > Let me know if you'd prefer a different credit. >
I've now upgraded blead with 3.48, but this fix didn't make it, so that test will now fail in smokes. Any chance of a 3.49?
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-10123-1263353355-1382.49599-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 91
Thanks for the feedback, Steve. I have another attempted fix in my git repo row. Mark
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-14813-1265426763-755.49599-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 87
I believe a fix for this was released in the latest 3.49 release that happened today.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.