Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the HTML-FormHandler CPAN distribution.

Report information
The Basics
Id: 49560
Status: resolved
Priority: 0/
Queue: HTML-FormHandler

People
Owner: gshank [...] cpan.org
Requestors: carlachambers [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Render::Simple bug with prefiling radio groups.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Charset: utf8
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1252507835-29880-1"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 604
Download (untitled) / with headers
text/plain 604b
There's a small bug with HTML::FormHandler::Renderer::Simple applying defaults to radio groups. It doesn't seem to work due to the comparison being made using $self->fif instead of the field ($field->fif) being iterated over. Specifically, the method render_radio_group contains the following line of code (line 319), used to apply the "checked" attribute to the input tag: output .= ' checked="checked"' if $option->{value} eq $self->fif; This, as far as I can tell, should be: output .= ' checked="checked"' if $option->{value} eq $field->fif; There's a patch attached if you need. Cheers
Subject: patch.diff
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1252507835-29880-0"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Charset: utf8
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: text/x-patch; name="patch.diff"
Content-Disposition: inline; filename="patch.diff"
Content-Transfer-Encoding: binary
Content-Length: 163
Download patch.diff
text/x-diff 163b
319c319 < $output .= ' checked="checked"' if $option->{value} eq $self->fif; --- > $output .= ' checked="checked"' if $option->{value} eq $field->fif;
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-9877-1259772332-413.49560-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 81
Not sure when this was fixed, but it was a while back... definitely fixed in 0.29


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.