Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 49350
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: CRAKRJACK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.35
Fixed in: 0.36



Subject: new_from_context inlines 'Build.PL'
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain
Charset: utf8
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 572
Download (untitled) / with headers
text/plain 572b
->new_from_context() inlines Build.PL, which means that if a Build script elects to terminate early, that causes the perl environment further up the chain to exit as well. For example, Params::Classify 0.007 has an "exit 0" at the end of it's Build.PL, which ensures that if ->new_from_context is ever called on that module, it will exit early. Since Build.PL is touted as a "script", I think it should be treated as such as much as possible, and we should not let the product of a Build.PL pollute the environment above that, whether that's M::B, CPANPLUS, or whatever.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-27252-1251858247-784.49350-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 530
Download (untitled) / with headers
text/plain 530b
The partner to this bug in Params::Classify is here; https://rt.cpan.org/Ticket/Display.html?id=49351 For now, I am using the following workaround. I hope it doesnt have any other unintended side-effects :-) ## hackery for https://rt.cpan.org/Ticket/Display.html?id=49350 ## and https://rt.cpan.org/Ticket/Display.html?id=49351 my $old_new_from_context = \&Module::Build::Base::new_from_context; local *Module::Build::Base::new_from_context = sub { local *CORE::GLOBAL::exit = sub { return @_ }; $old_new_from_context->(@_); };
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-27252-1251859842-1667.49350-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 367
Download (untitled) / with headers
text/plain 367b
new_from_context as implemented is really no longer necessary. After discussion on #toolchain with ewilhelm, our thought is to deprecate new_from_context and add a load_from_build_pl() class method that runs Build.PL in a separate process and then resumes it the same way the Build script would. (Lowering severity to "normal" as this is not a release-blocking bug)
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-27252-1251859842-1667.49350-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
References: <rt-3.6.HEAD-27252-1251859842-1667.49350-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-27252-1251863452-132.49350-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 448
Download (untitled) / with headers
text/plain 448b
On Tue Sep 01 22:50:42 2009, DAGOLDEN wrote: Show quoted text
> new_from_context as implemented is really no longer necessary. After > discussion on #toolchain with ewilhelm, our thought is to deprecate > new_from_context
Thanks... so if new_from_context is depreciating, I guess CPANPLUS should stop using it. Would you be willing to file an RT over there for this? You'd probably be better at explaining how to upgrade that code than I... Cheers, Tyler
MIME-Version: 1.0
X-Spam-Status: No, hits=0.0 required=8.0 tests=DK_SIGNED,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-27252-1251863452-132.49350-5-0 [...] rt.cpan.org>
References: <RT-Ticket-49350 [...] rt.cpan.org> <rt-3.6.HEAD-27252-1251859842-1667.49350-5-0 [...] rt.cpan.org> <rt-3.6.HEAD-27252-1251863452-132.49350-5-0 [...] rt.cpan.org>
Message-ID: <5d4beb40909020233l26ef5df0s69557a9b5ee40f5e [...] mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id 41D1E19B82E6 for <bug-Module-Build [...] rt.cpan.org>; Wed, 2 Sep 2009 05:33:55 -0400 (EDT)
Received: (qmail 16341 invoked by uid 103); 2 Sep 2009 09:33:54 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 2 Sep 2009 09:33:54 -0000
Received: from mail-yx0-f203.google.com (HELO mail-yx0-f203.google.com) (209.85.210.203) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 02 Sep 2009 02:33:49 -0700
Received: by yxe41 with SMTP id 41so967440yxe.27 for <bug-Module-Build [...] rt.cpan.org>; Wed, 02 Sep 2009 02:33:46 -0700 (PDT)
Received: by 10.150.114.3 with SMTP id m3mr13554448ybc.56.1251884026080; Wed, 02 Sep 2009 02:33:46 -0700 (PDT)
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #49350] new_from_context inlines 'Build.PL'
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:content-type; b=wpl4gwCK7nzsQ//5s9Ix+LEzyeXj8V3srD+B0bQoImmhBIC2LMwM34z18wZAXDxccx kkxYQXd93c5L6nGFNXmno65+oqVmsbKq4Kok1oD0zmkFGi/0rSbMrqZ/JkCo27cCE6Ly Ewx3HSasGACy4hhvTYTZWnEYBvxGF4Tvd3vf8=
Return-Path: <xdaveg [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:from:date:x-google-sender-auth:message-id:subject:to :content-type; bh=GsM+YYCMNjfFu8QRhm0fSJBptU1SLTwhbEznAulAMa0=; b=q65sxRvzWL2WFOOPMxH3hwcPzJZbOXSqZl1GcTF5AhRhV/3Ai7oCbvv+ekg6I7U0Dx KJhMcRDmZ/66IHexqkYEUrDJJPGDzTZom2tOn099yOBqFA/3Jj0qFbdvPHVPO4mEMe32 Z8SK/ps+0c6P9W215SmxHJO+hfRmLBjb29eek=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
X-Google-Sender-Auth: 4f0f7971cdc10722
Date: Wed, 2 Sep 2009 05:33:26 -0400
Sender: xdaveg [...] gmail.com
X-Spam-Level: *
To: bug-Module-Build [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
RT-Message-ID: <rt-3.6.HEAD-27252-1251884044-1225.49350-0-0 [...] rt.cpan.org>
Content-Length: 411
Download (untitled) / with headers
text/plain 411b
On Tue, Sep 1, 2009 at 11:50 PM, CRAKRJACK via RT<bug-Module-Build@rt.cpan.org> wrote: Show quoted text
> Thanks... so if new_from_context is depreciating, I guess CPANPLUS > should stop using it. Would you be willing to file an RT over there for > this? You'd probably be better at explaining how to upgrade that code > than I...
CPANPLUS::Dist::Build no longer uses new_from_context (since about version 0.08 in March 2009).
MIME-Version: 1.0
X-Spam-Status: No, hits=0.0 required=8.0 tests=DK_SIGNED,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-27252-1251859842-1667.49350-5-0 [...] rt.cpan.org>
References: <RT-Ticket-49350 [...] rt.cpan.org> <rt-3.6.HEAD-27252-1251859842-1667.49350-5-0 [...] rt.cpan.org>
Message-ID: <6a7ee8cc0909020647p29f8df45o818e30eca332bb10 [...] mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id B3F8A4D811A for <bug-Module-Build [...] rt.cpan.org>; Wed, 2 Sep 2009 09:47:14 -0400 (EDT)
Received: (qmail 3910 invoked by uid 103); 2 Sep 2009 13:47:14 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 2 Sep 2009 13:47:14 -0000
Received: from mail-iw0-f204.google.com (HELO mail-iw0-f204.google.com) (209.85.223.204) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 02 Sep 2009 06:47:09 -0700
Received: by iwn42 with SMTP id 42so358195iwn.33 for <bug-Module-Build [...] rt.cpan.org>; Wed, 02 Sep 2009 06:47:06 -0700 (PDT)
Received: by 10.231.5.23 with SMTP id 23mr8474499ibt.45.1251899226174; Wed, 02 Sep 2009 06:47:06 -0700 (PDT)
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #49350] new_from_context inlines 'Build.PL'
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=ZaiW52gTzs/Lhk3L03j6GYvoc4lw5S0Iuejg4uPRLJ1NVGjYCvdT+gZZKpTipmyrwT 7OEzRxUiqf9G55KfI3WUlniK96Yf0BEgyKr+EF9J4BpjnEm4WQtz4qLcanxVlLly+zEU dAZVgIcS2cYuNvHunMcHigWxP5T9ZBkQZ9wug=
Return-Path: <kenahoo [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to :content-type:content-transfer-encoding; bh=r2aoJVoroRK4euCHiDuiPz24ti4R/SuXrAmX6dEFu5Q=; b=dQX48QE2zibWpKvZUY5g+kbar7DtJCeuch4WYcdDaEEoMDZG4KJxJqOtLmj4e+uMal 2ikwoR81FjAO5Y5ltxLou7INporFYBhfBnHlsqW88UVxFS3xUhDNgMwsOHAee7JvzFL0 KjwNvWmHzBD5DZFDC2q1jpHpcqPEZfpuk17qA=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
X-Google-Sender-Auth: 55da96cc7ed5e6fa
Date: Wed, 2 Sep 2009 08:47:06 -0500
Sender: kenahoo [...] gmail.com
X-Spam-Level: *
To: bug-Module-Build [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Ken Williams <kwilliams [...] cpan.org>
RT-Message-ID: <rt-3.6.HEAD-27252-1251899244-15.49350-0-0 [...] rt.cpan.org>
Content-Length: 630
Download (untitled) / with headers
text/plain 630b
On Tue, Sep 1, 2009 at 9:50 PM, David Golden via RT<bug-Module-Build@rt.cpan.org> wrote: Show quoted text
>       Queue: Module-Build >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=49350 > > > new_from_context as implemented is really no longer necessary.  After > discussion on #toolchain with ewilhelm, our thought is to deprecate > new_from_context and add a load_from_build_pl() class method that runs > Build.PL in a separate process and then resumes it the same way the > Build script would.
Seems like a good idea. I'd even be in favor of keeping the method name the same and just swapping out the implementation. -Ken
MIME-Version: 1.0
X-Spam-Status: No, hits=0.0 required=8.0 tests=DK_SIGNED,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-27252-1251899244-15.49350-5-0 [...] rt.cpan.org>
References: <RT-Ticket-49350 [...] rt.cpan.org> <rt-3.6.HEAD-27252-1251859842-1667.49350-5-0 [...] rt.cpan.org> <6a7ee8cc0909020647p29f8df45o818e30eca332bb10 [...] mail.gmail.com> <rt-3.6.HEAD-27252-1251899244-15.49350-5-0 [...] rt.cpan.org>
Message-ID: <5d4beb40909020753r4a9123day440dd8a20f497351 [...] mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id C8AFE4D811A for <bug-Module-Build [...] rt.cpan.org>; Wed, 2 Sep 2009 10:54:03 -0400 (EDT)
Received: (qmail 20317 invoked by uid 103); 2 Sep 2009 14:54:02 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 2 Sep 2009 14:54:02 -0000
Received: from mail-vw0-f195.google.com (HELO mail-vw0-f195.google.com) (209.85.212.195) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 02 Sep 2009 07:53:58 -0700
Received: by vws33 with SMTP id 33so801675vws.33 for <bug-Module-Build [...] rt.cpan.org>; Wed, 02 Sep 2009 07:53:55 -0700 (PDT)
Received: by 10.150.15.42 with SMTP id 42mr14028516ybo.266.1251903235089; Wed, 02 Sep 2009 07:53:55 -0700 (PDT)
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #49350] new_from_context inlines 'Build.PL'
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:content-type :content-transfer-encoding; b=P29GTBJSfyNkWGyPoNBBb2ZCVmHCB3N7h90/sqrPHJ4rWrgpqqDM3iY40EYkfVDygt /LkeYw2QbM2e65M/4Rm4cZkIKiMJ3slvaK1IM+1NRQF8Tau5ZCZQ+nMBxczhLDg94r3D YiQF0iF3lH95krU8gNrRbItLuRHGSlF7dC5M4=
Return-Path: <xdaveg [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:from:date:x-google-sender-auth:message-id:subject:to :content-type:content-transfer-encoding; bh=+QvymF/SolmfDMYvJ8XwHZwZ8JZ/occlmi5AYX5/K1A=; b=O8o0fhglwtdJNZyRhR98j2SMTngOFmB3CaVDH5TG4XAh3Vg+5bS0Jw5uFmE36ozxJ1 PIHgQC9nm/t7nlHQ6SpSQsJTwtAmZMhc++2bwhODJShGuNFRNMol0sc3wrX2lJ6JXeEW XHEWmEUFPK5ubOBXddoX/TEhcIDlzvzi1TzN4=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
X-Google-Sender-Auth: e1c303062a871d45
Date: Wed, 2 Sep 2009 10:53:35 -0400
Sender: xdaveg [...] gmail.com
X-Spam-Level: *
To: bug-Module-Build [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: David Golden <dagolden [...] cpan.org>
RT-Message-ID: <rt-3.6.HEAD-27252-1251903253-770.49350-0-0 [...] rt.cpan.org>
Content-Length: 532
Download (untitled) / with headers
text/plain 532b
On Wed, Sep 2, 2009 at 9:47 AM, Ken Williams via RT<bug-Module-Build@rt.cpan.org> wrote: Show quoted text
> Seems like a good idea.  I'd even be in favor of keeping the method > name the same and just swapping out the implementation.
We we're being cautious because of a scary comments you put in about why it needed to happen that way. (Which we think are now stale given other implementation changes, particularly around preserving things added to @INC.) So if you support the change, I'm all for changing the guts of new_from_context. David
MIME-Version: 1.0
X-Spam-Status: No, hits=0.0 required=8.0 tests=DK_SIGNED,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-27252-1251903253-770.49350-5-0 [...] rt.cpan.org>
References: <RT-Ticket-49350 [...] rt.cpan.org> <rt-3.6.HEAD-27252-1251859842-1667.49350-5-0 [...] rt.cpan.org> <6a7ee8cc0909020647p29f8df45o818e30eca332bb10 [...] mail.gmail.com> <rt-3.6.HEAD-27252-1251899244-15.49350-5-0 [...] rt.cpan.org> <5d4beb40909020753r4a9123day440dd8a20f497351 [...] mail.gmail.com> <rt-3.6.HEAD-27252-1251903253-770.49350-5-0 [...] rt.cpan.org>
Message-ID: <6a7ee8cc0909020920x74d0c650sb93223b1ce1edc13 [...] mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id 17C214D811A for <bug-Module-Build [...] rt.cpan.org>; Wed, 2 Sep 2009 12:20:59 -0400 (EDT)
Received: (qmail 8230 invoked by uid 103); 2 Sep 2009 16:20:58 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 2 Sep 2009 16:20:58 -0000
Received: from mail-iw0-f199.google.com (HELO mail-iw0-f199.google.com) (209.85.223.199) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 02 Sep 2009 09:20:52 -0700
Received: by iwn37 with SMTP id 37so391235iwn.28 for <bug-Module-Build [...] rt.cpan.org>; Wed, 02 Sep 2009 09:20:50 -0700 (PDT)
Received: by 10.231.28.143 with SMTP id m15mr8667078ibc.23.1251908450080; Wed, 02 Sep 2009 09:20:50 -0700 (PDT)
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #49350] new_from_context inlines 'Build.PL'
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=C7zG46Ry/CgjERommRlL9BM07Zsjixt+YgFMbP7tzBkGpI+C7jNtJATX/2IAqTVsZL hPs7t4Z9mclHEPU66Lz8DzofxoBmzd6SDGLEtNGt1tu0H9CMInWsXqv83KM8OZUVLND7 5zJ3BKt/GwaOIvunNVUueym28aQLVdPATLEgE=
Return-Path: <kenahoo [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to :content-type:content-transfer-encoding; bh=i0vM8oRV1ffb+xyFuProC2yoy5wfqv7bAaf4qA1Y8FI=; b=hl3Rf0w5tXUWH+vMMx9LQ1YjSW873fiztrGgJixng9VG0/8keb7INNs/SW+VJLFfzU AgogKVOCBAY/RMzTu1ednQqStJ5kDuwz5pLvE1bssJJWSHWKB9sA7E5OaXWqC/zh2zKR dpDZwS5NuZTHN+MACcfSrif8bqtWDZ6SfDoEo=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
X-Google-Sender-Auth: 975b1dbdccdeefbe
Date: Wed, 2 Sep 2009 11:20:50 -0500
Sender: kenahoo [...] gmail.com
X-Spam-Level: *
To: bug-Module-Build [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Ken Williams <kwilliams [...] cpan.org>
RT-Message-ID: <rt-3.6.HEAD-27252-1251908471-1623.49350-0-0 [...] rt.cpan.org>
Content-Length: 494
Download (untitled) / with headers
text/plain 494b
On Wed, Sep 2, 2009 at 9:54 AM, David Golden via RT<bug-Module-Build@rt.cpan.org> wrote: Show quoted text
> We we're being cautious because of a scary comments you put in about > why it needed to happen that way.  (Which we think are now stale given > other implementation changes, particularly around preserving things > added to @INC.)
Reading that comment, I'm not sure what I meant by "make sure that the environment is the same". All the cases I can think of should be fine. So I say go for it. -Ken
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-27252-1251909988-396.49350-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 16
Patched in trunk


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.